From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx120.postini.com [74.125.245.120]) by kanga.kvack.org (Postfix) with SMTP id 3F5FF6B0044 for ; Sat, 4 Aug 2012 09:53:33 -0400 (EDT) Received: by vbkv13 with SMTP id v13so1847326vbk.14 for ; Sat, 04 Aug 2012 06:53:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1343875991-7533-4-git-send-email-laijs@cn.fujitsu.com> References: <1343875991-7533-1-git-send-email-laijs@cn.fujitsu.com> <1343875991-7533-4-git-send-email-laijs@cn.fujitsu.com> Date: Sat, 4 Aug 2012 21:53:31 +0800 Message-ID: Subject: Re: [RFC PATCH 03/23 V2] procfs: use N_MEMORY instead N_HIGH_MEMORY From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Lai Jiangshan Cc: Mel Gorman , Paul Menage , Rob Landley , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Greg Kroah-Hartman , Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Christoph Lameter , Pekka Enberg , Matt Mackall , Jarkko Sakkinen , Matt Fleming , Andrew Morton , Yinghai Lu , David Rientjes , Bjorn Helgaas , Wanlong Gao , Petr Holasek , Djalal Harouni , Jiri Kosina , Laura Vasilescu , WANG Cong , Hugh Dickins , Naoya Horiguchi , Konstantin Khlebnikov , Sam Ravnborg , Paul Gortmaker , Rusty Russell , Peter Zijlstra , Jim Cromie , Pawel Moll , Henrique de Moraes Holschuh , Oleg Nesterov , Dan Magenheimer , Michal Nazarewicz , Mel Gorman , Gavin Shan , Wen Congyang , Rik van Riel , KOSAKI Motohiro , Wang Sheng-Hui , Minchan Kim , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, containers@lists.linux-foundation.org On Thu, Aug 2, 2012 at 10:52 AM, Lai Jiangshan wrote: > N_HIGH_MEMORY stands for the nodes that has normal or high memory. > N_MEMORY stands for the nodes that has any memory. > > The code here need to handle with the nodes which have memory, we should > use N_MEMORY instead. > > Signed-off-by: Lai Jiangshan > --- Acked-by: Hillf Danton > fs/proc/kcore.c | 2 +- > fs/proc/task_mmu.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c > index 86c67ee..e96d4f1 100644 > --- a/fs/proc/kcore.c > +++ b/fs/proc/kcore.c > @@ -249,7 +249,7 @@ static int kcore_update_ram(void) > /* Not inialized....update now */ > /* find out "max pfn" */ > end_pfn = 0; > - for_each_node_state(nid, N_HIGH_MEMORY) { > + for_each_node_state(nid, N_MEMORY) { > unsigned long node_end; > node_end = NODE_DATA(nid)->node_start_pfn + > NODE_DATA(nid)->node_spanned_pages; > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 4540b8f..ed3d381 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1080,7 +1080,7 @@ static struct page *can_gather_numa_stats(pte_t pte, struct vm_area_struct *vma, > return NULL; > > nid = page_to_nid(page); > - if (!node_isset(nid, node_states[N_HIGH_MEMORY])) > + if (!node_isset(nid, node_states[N_MEMORY])) > return NULL; > > return page; > @@ -1232,7 +1232,7 @@ static int show_numa_map(struct seq_file *m, void *v, int is_pid) > if (md->writeback) > seq_printf(m, " writeback=%lu", md->writeback); > > - for_each_node_state(n, N_HIGH_MEMORY) > + for_each_node_state(n, N_MEMORY) > if (md->node[n]) > seq_printf(m, " N%d=%lu", n, md->node[n]); > out: > -- > 1.7.1 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org