From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx180.postini.com [74.125.245.180]) by kanga.kvack.org (Postfix) with SMTP id 3A0716B0031 for ; Fri, 19 Jul 2013 01:40:39 -0400 (EDT) Received: by mail-ob0-f171.google.com with SMTP id dn14so4754294obc.2 for ; Thu, 18 Jul 2013 22:40:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1374183272-10153-8-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1374183272-10153-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1374183272-10153-8-git-send-email-n-horiguchi@ah.jp.nec.com> Date: Fri, 19 Jul 2013 13:40:38 +0800 Message-ID: Subject: Re: [PATCH 7/8] memory-hotplug: enable memory hotplug to handle hugepage From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Hugh Dickins , KOSAKI Motohiro , Andi Kleen , Michal Hocko , Rik van Riel , "Aneesh Kumar K.V" , linux-kernel@vger.kernel.org, Naoya Horiguchi On Fri, Jul 19, 2013 at 5:34 AM, Naoya Horiguchi wrote: > @@ -518,9 +519,11 @@ static struct page *dequeue_huge_page_node(struct hstate *h, int nid) > { > struct page *page; > > - if (list_empty(&h->hugepage_freelists[nid])) > + list_for_each_entry(page, &h->hugepage_freelists[nid], lru) > + if (!is_migrate_isolate_page(page)) > + break; > + if (&h->hugepage_freelists[nid] == &page->lru) For what is this check? > return NULL; > - page = list_entry(h->hugepage_freelists[nid].next, struct page, lru); > list_move(&page->lru, &h->hugepage_activelist); > set_page_refcounted(page); > h->free_huge_pages--; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org