From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D59CC54FD3 for ; Wed, 25 Mar 2020 14:43:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 166C6215A4 for ; Wed, 25 Mar 2020 14:43:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="YUccMzib" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 166C6215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=szeredi.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9BB886B0005; Wed, 25 Mar 2020 10:43:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D4B6B000C; Wed, 25 Mar 2020 10:43:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85B8B6B000D; Wed, 25 Mar 2020 10:43:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id 6E9106B0005 for ; Wed, 25 Mar 2020 10:43:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3BD7F18017AA3 for ; Wed, 25 Mar 2020 14:43:15 +0000 (UTC) X-FDA: 76634152350.30.dogs23_39718eed5421f X-HE-Tag: dogs23_39718eed5421f X-Filterd-Recvd-Size: 3950 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Mar 2020 14:43:14 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id c19so2455678ioo.6 for ; Wed, 25 Mar 2020 07:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BYoi0GgKGrZ5Iy05aE5oc1zP5UUaQTjapju/izAR4hI=; b=YUccMzib2IwajwEuyLBHygiEi2x+yWevlxfsequqpaIt/Mza/TxUmFkitS3U4FkfKx P1XwXxBJ8Cx5HEmhYoBLdWFHhmr6xou5YR2utppkELKcqyaDd4EOavtJNBW3boLnPkzx WgZmdQ9YRsyheNZWEZrba/miSYKYdDAaziYyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BYoi0GgKGrZ5Iy05aE5oc1zP5UUaQTjapju/izAR4hI=; b=Imq9fOfOpHW7/QUtfwzm5ryBT1Fz6Y3aeqCuLK9Euo/25ycBdw5hbdBGDKNRkh+33N bREtUPYi8br5uc9mdk7bkRMxS4q6OmQgnVhNeKYZ3o162dIDzwI5K8MOOIjO1njcRkEN hs8hjaZHBxX/u6fDfs3i7iUAwoyTnmGTsi75Se0qfG1S+lDS7gQQH1dO7bgghaFsajhe NOXbRalWmgwvvLovejQrOvaMYjddhrMbk6UTqpRQFA5KS9LP9QM0u/EXkRKHBf65T7HO wDKIpbfH3jb/IU1nHneDOHbczN+k5Dd9DvEM0N4ZESS1RsMTy7GH8QGIbzmOCvg188RL 6rRg== X-Gm-Message-State: ANhLgQ3v4OrhEngpo3H/aJ4gGZ//wp/xq0gss8mBxLELzwbwwbeX1lp6 uRLrsnNOZVZ/zKy/jQslRzfXbdbhXiiv9a5a9cYplA== X-Google-Smtp-Source: ADFU+vsgMMqodCZqPGFNfCT+HdNRTtLLlUdy5AMnDcVBoatxWj+vZY48emoAVNd+HvHliFjTkg/kdF6pmkOGcZxuC6s= X-Received: by 2002:a6b:3a07:: with SMTP id h7mr3235359ioa.191.1585147393572; Wed, 25 Mar 2020 07:43:13 -0700 (PDT) MIME-Version: 1.0 References: <20200323202259.13363-1-willy@infradead.org> <20200323202259.13363-25-willy@infradead.org> <20200325120254.GA22483@bombadil.infradead.org> In-Reply-To: <20200325120254.GA22483@bombadil.infradead.org> From: Miklos Szeredi Date: Wed, 25 Mar 2020 15:43:02 +0100 Message-ID: Subject: Re: [PATCH v10 24/25] fuse: Convert from readpages to readahead To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs , Dave Chinner , William Kucharski Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 1:02 PM Matthew Wilcox wrote: > > On Wed, Mar 25, 2020 at 10:42:56AM +0100, Miklos Szeredi wrote: > > > + while ((page = readahead_page(rac))) { > > > + if (fuse_readpages_fill(&data, page) != 0) > > > > Shouldn't this unlock + put page on error? > > We're certainly inconsistent between the two error exits from > fuse_readpages_fill(). But I think we can simplify the whole thing > ... how does this look to you? Nice, overall. > > - while ((page = readahead_page(rac))) { > - if (fuse_readpages_fill(&data, page) != 0) > + nr_pages = min(readahead_count(rac), fc->max_pages); Missing fc->max_read clamp. > + ia = fuse_io_alloc(NULL, nr_pages); > + if (!ia) > return; > + ap = &ia->ap; > + __readahead_batch(rac, ap->pages, nr_pages); nr_pages = __readahead_batch(...)? This will give consecutive pages, right? Thanks, Miklos