From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680B0D0E6DD for ; Mon, 21 Oct 2024 10:15:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C7E46B0083; Mon, 21 Oct 2024 06:15:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9776A6B008A; Mon, 21 Oct 2024 06:15:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 819276B008C; Mon, 21 Oct 2024 06:15:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 678006B0083 for ; Mon, 21 Oct 2024 06:15:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 44EEA1C6FC1 for ; Mon, 21 Oct 2024 10:15:33 +0000 (UTC) X-FDA: 82697203092.02.A2615A1 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf14.hostedemail.com (Postfix) with ESMTP id 2A57B100012 for ; Mon, 21 Oct 2024 10:15:31 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=POELhCR6; spf=pass (imf14.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.160.169 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729505600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XQXMo1DFMeFg7OubTtKklZar6mxzRSvb3HbKBHc2oxw=; b=al/psoV+monXN75AsEADCgJ4DULzi6C+S8nd84Qh89B2cUNHfMMYWB7DxM0uh6lBJskvnW OEHrrwpYtL4Zw2lVr9wENaP2KGXY9bFtHzWL7s/bsirQl1DKGETYngVeOD3YVTgyv0W7lI 8XuVtUohbIkRG3b1ksEmynVqBYssk/8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729505600; a=rsa-sha256; cv=none; b=gIedEGURPNL6Nit+zIimNcZC/DlOOFDqxbTFA77usT8s1peVZA3e09aDnJhViHnNmjoZbT JO7XfmrzPBK+/ono1cnTuCzZ+u5vEY5EbI9y7AEz78r8whgqv4jgHeMq/F5dq+rBFz6lp2 xg+jfnOQwaSaQ0xISa03mLDVKJt+m/E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=POELhCR6; spf=pass (imf14.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.160.169 as permitted sender) smtp.mailfrom=miklos@szeredi.hu; dmarc=pass (policy=quarantine) header.from=szeredi.hu Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-460ace055d8so24505911cf.1 for ; Mon, 21 Oct 2024 03:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1729505747; x=1730110547; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XQXMo1DFMeFg7OubTtKklZar6mxzRSvb3HbKBHc2oxw=; b=POELhCR62Gr2Hi9IvQXISrqMME+68+NQpx5a/uZ4u2b+s1VEGNSCXK1qwbgNBs7EpO 5UbBnsC40lIlrPPIhM1ZT6E9/ksUnoBVbCoxr9OKkoYbio9UdVQ7VQtyjJNQUAkVReCC v91Gv9iRyTNdXX5pEx+BUquWWD4M+XS0kFAlY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729505747; x=1730110547; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XQXMo1DFMeFg7OubTtKklZar6mxzRSvb3HbKBHc2oxw=; b=FLDVx0847gI6I0/JKTQN1L7LkAArjKt+GCijhXsvY4HhrU3WQuBElXX3V7gfvDi9/X UQb27m4NoJjZW8H7rqEDdvRS/9JpJ0BpatbWXF9a9yxfg03RYsPTaYChrITeXDw6IPwz SrxQ9gyaI7SYMwTQvRI1W1+kmrimC3nw07aLoRNj/XmG/CJLEQqunCzV4+YbjAQjEvH8 yppgflpjkYS4cknU+pd2Ixdd/Ya2Vakdxhu3JLsGdc2E/JuXFfVghl9XyednEX3M+wjd dRRG7q0yjQMBu5TSI+zDEYwMMqXQrdH+BUlhzsV9c1eAiZLNkpV5Hdo1JPyfHqEr8gBG 4lBA== X-Forwarded-Encrypted: i=1; AJvYcCVM73TZxwJJzAYtn9MG6GLRIt4Wu5nTRX6JIDfewp0ZYCgKmO0cFUU3EVvLBtGf/qmIfXJH3DKAZg==@kvack.org X-Gm-Message-State: AOJu0Ywx3zXOpVL6D3RqwNMuuNe61XUXc0i7AdV1y5ZS3NQhkrFd9SNC ZplYToy/2Z2dIbDaRPsT4FhwL/N+7eK/e4uFniv7TcQUKZxRR/X+Ry1FkpBhHXaHk0mkxDIWzNQ XkSWyjQn9tUUkYawyf1ppgmRs68JclyWaGbYdHQ== X-Google-Smtp-Source: AGHT+IGNFq8P9pVugplCf3PEIYHCEWzuYOITZsc46LJ3iqiN8mrrFIp4UkMN0Sbn5njLCnKRIcTAXY61v0qBsR5ZVgQ= X-Received: by 2002:a05:622a:299a:b0:460:9b2b:5440 with SMTP id d75a77b69052e-460aecd06c0mr153221341cf.5.1729505747632; Mon, 21 Oct 2024 03:15:47 -0700 (PDT) MIME-Version: 1.0 References: <20241014182228.1941246-1-joannelkoong@gmail.com> <20241014182228.1941246-3-joannelkoong@gmail.com> In-Reply-To: From: Miklos Szeredi Date: Mon, 21 Oct 2024 12:15:36 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Shakeel Butt Cc: Joanne Koong , linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, bernd.schubert@fastmail.fm, jefflexu@linux.alibaba.com, hannes@cmpxchg.org, linux-mm@kvack.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2A57B100012 X-Stat-Signature: jczzh4wtgskmz461pfpmeujrsncb79ct X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729505731-608704 X-HE-Meta: U2FsdGVkX1+SeWcJUgpjeBF6hwEDEvRd+T4BVXX0vJoELkwBPY5W5bkyjlao27iAICyRPbVvou5VXG91p7Y8dHCFfMZ2qmwLTAb86V9eMYRRN0L0pWP/DW9nPQpkmqsmciZ5Nc3tmIUdr659qBql1joll7oeEVZaVTuF156zT3Ca8G476aezRwmsMh4pA0n+dsBv6yDGmo0OhoYfZKZECMbfsCw8lHxV823qDAZAsD73KDL05M3P6QB74SisKiCzyUhJqygMBieeICBqmYxdV4NAl69KtQvCvXdjgYeJAmi33e9DI3eQ8LTw7GACfc7OD5TuMlsjskYzJm6oCz2xvoAfjQ3LqQDBYFeHYqa0zOTloMBJ02VEbf3o0o24eW5+LCgChbehiR+1N/kZ8t3Ow1/Bt25q2KfXIlVaTGazPmZ/sMzu+SSFwrcKQQTDGpk0YEsIHjzGKEqG4baDVjbp3noCbxz1/FMA59DwjsGzWHQq5Q8LQbxdBQ/lItehvMKa4LH8Uy09M2oPSmFwexLHOK5bhE/spxzkoIrpATLir9XCVoAmjOeZjb0imMlj2QR0LMqFSIV8mVoOpAZ8p1tOTh/33bFPImOgySODlwT2WcStITidrWgcDR3cCgYRe5FE9+I43T8jUxeA/6CtDcCaux1wrfdTPklWSfP+JAXoE612Amlie9Z4J7AoX8BWRmf0Wt5yjWC4EbZ7h92sdqOHSl5u6dcGfBZYy1EbCAl/5e2oo83qSgfVCPZ+Voe6YuKgaOz3trOszeFqM0nWbkbu7QKvw1YGkvGjX/jwediHanlZmvTTmJIh8sx0L+9D7HOGNaJwT6J0q4SFjLSshX3EzhDhB/H/c0OsqRfKxICuxf6XLbNKpKxW6eQzKu6y03cFkrCFm4GkUvGYBfAY8tbb7pinvmuceAdnj3wTat7KyLTLmxOhHiWFiS+xgN9sHWezlDPgUYBsCrntPXPNENx zEtamzPK xtHw54kXeixvTevPoFMUseRX9Z/PrGymkcJgS5cTcKEzVVZHWm1x92q+xbt76NW9Z3e+FWQth/TOyyTGv4NwSEBGQmphkXOIkWe9Umw3ZG3iShH7Z591Bki0nK2avQK62dEJaxgwJGuxRXneH/xENAS2iwNkng5NFPFN1kf3NrA560OjotlmzUxfa3ItEJK0THNoY X-Bogosity: Ham, tests=bogofilter, spamicity=0.030142, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 18 Oct 2024 at 07:31, Shakeel Butt wrote: > I feel like this is too much restrictive and I am still not sure why > blocking on fuse folios served by non-privileges fuse server is worse > than blocking on folios served from the network. Might be. But historically fuse had this behavior and I'd be very reluctant to change that unconditionally. With a systemwide maximal timeout for fuse requests it might make sense to allow sync(2), etc. to wait for fuse writeback. Without a timeout allowing fuse servers to block sync(2) indefinitely seems rather risky. Thanks, Miklos