From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70258C636D4 for ; Wed, 15 Feb 2023 15:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 021D66B0072; Wed, 15 Feb 2023 10:50:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F14B06B0073; Wed, 15 Feb 2023 10:50:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDC686B0074; Wed, 15 Feb 2023 10:50:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CB9DB6B0072 for ; Wed, 15 Feb 2023 10:50:18 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9E18E40FD9 for ; Wed, 15 Feb 2023 15:50:18 +0000 (UTC) X-FDA: 80469962916.10.19FEADE Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf09.hostedemail.com (Postfix) with ESMTP id BD645140008 for ; Wed, 15 Feb 2023 15:50:16 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=fUwRQoso; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf09.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.46 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676476216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gxx4XcKwvyNpOp3VEGiE+719FH+KggeO1TDcZH8XIXc=; b=OeUSeGuDRVuymEaC74N4aWR4EKeSHPQLxMMwNJMkeI42GbLbVpD+GFqBVTG/HAO9Z3YaC8 VvDgAQgaKBn7Rujpa7xgJ36CtamHjUuZM7nbgFfOJPdaWPAb5nkZDubMDqIVmJUD29rh6C MhyNNQFNYZi/+Ee3vNGEeQErMyqQ7sA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=szeredi.hu header.s=google header.b=fUwRQoso; dmarc=pass (policy=quarantine) header.from=szeredi.hu; spf=pass (imf09.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.208.46 as permitted sender) smtp.mailfrom=miklos@szeredi.hu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676476216; a=rsa-sha256; cv=none; b=ql8eXBqSestc7IEaTGRwiYLugK6zGnhcx/PWAsTLAIpOEOWz4dYEVwT42+qQnm/VBV5vT+ TFfLMZlrULQO8BJwZD1xuBIUWY3ctIzwIUfXhRoQoEZTbNpnblqSo3DaSjfrIBMgr+7LMB wlQUEF2L3x3q+6nY9e6KnX53TK9dkKk= Received: by mail-ed1-f46.google.com with SMTP id s11so15031379edd.10 for ; Wed, 15 Feb 2023 07:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gxx4XcKwvyNpOp3VEGiE+719FH+KggeO1TDcZH8XIXc=; b=fUwRQosoarROxeHu1csL4um6cmJozX9RvBTdZqgdbzyF8Barwc8bIYcCdoDTmo/GS3 IrM2E/JJIeMfYbsTW+034l9vqtsfBsV6SKeI/tbgP1heCoXj5YxjirQn7a2KEY1Q5MRe 3QmYbDaieDTABhmer07N0SUOHXk1nlNqWCtBw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gxx4XcKwvyNpOp3VEGiE+719FH+KggeO1TDcZH8XIXc=; b=OCImtXqIhjXT1PnucHwQBDuYgRTAOxcjmTHwSr5xAyXdk0bCmrKfyTutJVkjc3ES/2 evBUaeNgYvFg/gMllJcostqKdFFQlbrUuiuPn/Ip4ZJHRaGYS+X/HjWfdups8bhJVgTv 9M1Qc0vi0pgJnTh6N45T75vCGqRD+lqvLGWnDjKyD/IlD4bIBkzBm8KmvkQ1X6jOMvyI HC758Bk/Qz/XNgoqmphI77BJxc8Lw82DC6Dz619USCQrAk0UPEz2cZeDbtuE5RO8b4ZA MD3V8oIevwIPRJaIJvKr3WX29ZqBusXQqPNBAjOugJBbBld0lp5VAYT8ls/Owa8pnuUs dkbw== X-Gm-Message-State: AO0yUKUiebVEK09JPuydg4mZ+fdYJyPZv/YjxmMhNYCcjM4kiTCWGEWw q9xHDw3oE7LNEYgbNXxk9ytF8Jbv22jc5/SZitfYqQ== X-Google-Smtp-Source: AK7set/c1PSjKuHwb5HoUktp2BYZfMk+QVL6t/16rqfQYUzXFAPu8C+88H0jVH04WKFY9zcgUpkjnk6LsbMVdzmu3MI= X-Received: by 2002:a50:99c1:0:b0:4aa:b30f:c784 with SMTP id n1-20020a5099c1000000b004aab30fc784mr1318317edb.8.1676476215115; Wed, 15 Feb 2023 07:50:15 -0800 (PST) MIME-Version: 1.0 References: <20230214171330.2722188-1-dhowells@redhat.com> <20230214171330.2722188-6-dhowells@redhat.com> <3370085.1676475658@warthog.procyon.org.uk> In-Reply-To: <3370085.1676475658@warthog.procyon.org.uk> From: Miklos Szeredi Date: Wed, 15 Feb 2023 16:50:04 +0100 Message-ID: Subject: Re: [PATCH v15 05/17] overlayfs: Implement splice-read To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BD645140008 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: z1x6f5dshfonfmgfw7cfs98eow7s3npy X-HE-Tag: 1676476216-789859 X-HE-Meta: U2FsdGVkX19f0CBVoeC1YfLylNzutjD2UzuAmJeZRq0h3KfqqZLKml548Zo3KBhch0ZVOdmueRBrvvj6DzTC6E0akdrKA6QKI8Co8KGKpxb0rtd3jPP61DDnwmUJP5s8BK7t62sUxoniQMYfuId9WwkVzjJwp4J4ooFSCSoddHWFkzlQd1uwxfoM1FhckHDThXSoqSBdMRRPkw2h1SdY2Hc2oWGDwDXxz7ka0/FEqQJDwXFfo1UGzR1/Ec9b/Q6RoNB2MvwaudpGZIpXWjezxrYnd6HAbtoTF02r19nLqFza9a9VE4wuy3CVQHErSBszosG5/15ok+0Qf0tjgPfzjWHDMywtMoz54gYVRnKG+blJO7LoND3waZbr20kbLXOYSjbzhB4m13eNTt5zbABDIOjYOjtBs+MSB/TvQUt/12NF4L64ht3Uj31hYi8b1+29dH8n+ptGEU/Tl2+YO56sj881BNoIWGbYD2mHM0hW0aK/pcq2rPq4qwWLCkas2/MOSCJeSUOAkWme0c9qt/P0uCIs23rLhG55jAETJpwYtFjfYbftgBfDM+Qdsn/5UnDywTt47ZWUUhr+5OlG+4vREB8ioNvBOYh8sHWzxQB3zh7ziSNNCTIAOivuyQRtC7DkmjkDVPhN6TCze/o1iA/JezmkA91bXErx7h1DDCOdn4/j71PUgNU6aF3RKXcVHpsrpswAKCHxibfW2F3SMD48aY5/V92bW4oOOiXFdNKB9iZsRh7MLwZbiPirH47XMZMrhM52OHD9S5FhFTZ3IAJyLT/Re51ThtQHGknV0+X1BZkptDbsVJyWGMIfc4nMrh8+YLPF/RddPmMn1A2ga2eacTmfdU03hXGIM6o11wYjAzhfzrEfDiee44rv822/o73ZCmYbPdVSEQgVvpmwLK7ZRjZ+pk0Hqe810rNNa1SHUaZyuOOgCCWK9mS7Cnrcl8tizetzf66zbKgXmIoahM0 vrhdjGlC 6F63NbgqL9aayolfRsQ55oDlFbTuv80dzmvL1JcL78nZFlU4ixpRhGGtkt6ZC5l73y8ZTa7z09RN2dLXSjsqymBZgwWFZYIUZLso3MOx6JBq6fB2d72vsHUnY/HJ8mEZetZxLeUTsSC9tzb0Z4Gt8vXiPy1RwYq+Yh36kXCZwRyBrohkoa5107spqEX3GM0ilwxg0hBsWsOvJq5y7b1q46vINSju7NyA+o+34fZ52DpNxXr23aryDHOB3wdljJOY7smkxkn+JRIHriK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 15 Feb 2023 at 16:41, David Howells wrote: > > How about the attached then? > > David > --- > overlayfs: Implement splice-read > > Implement splice-read for overlayfs by passing the request down a layer > rather than going through generic_file_splice_read() which is going to be > changed to assume that ->read_folio() is present on buffered files. Looks good. One more suggestion: add a vfs_splice() helper and use that from do_splice_to() as well. Thanks, Miklos