From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8383FC433F5 for ; Thu, 19 May 2022 00:20:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7A806B0072; Wed, 18 May 2022 20:20:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C27466B0073; Wed, 18 May 2022 20:20:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B15EB6B0074; Wed, 18 May 2022 20:20:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A19526B0072 for ; Wed, 18 May 2022 20:20:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6EDB231302 for ; Thu, 19 May 2022 00:20:32 +0000 (UTC) X-FDA: 79480586304.18.E659F3C Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 31D96400D5 for ; Thu, 19 May 2022 00:20:07 +0000 (UTC) Received: by mail-qt1-f172.google.com with SMTP id v14so3812402qtc.3 for ; Wed, 18 May 2022 17:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=FfSGeGLsTGa/kN0tZZMhQzuZST7aaZkoCseqfn8igks=; b=Qoo2GAm1GcS9vr9qvOXmUufnaVX1H7cVYwMNkjhhTlYdOEeWcRpS5J/w2bbRafsAz5 fOqxGsggoCgmSux73CsRcliZ1CWDoHg/vSPSro39VoUSZlXJO5uvTZ9ZruRzJio1RBL3 5AUqHVbSehF4mYOZUvbhXiXbWhEKJmhNeUls91eP9TK8/sMeiYNiDdIVaK3fwxjrhTxF PZpKR0E9b/ZO4RZzx6kTIeJhYsYwmc8w0Pj+DzsUswk9YaOv8EHevjGeMWe3H0gXTOnx N5mj2jrirO5QmOsz1vANmm+8LWnYKZTIAyzTQTywXBkgyEwFMKY6rCvNxWlR6aqEsLM0 KZCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FfSGeGLsTGa/kN0tZZMhQzuZST7aaZkoCseqfn8igks=; b=tkrL1QDlYdb9esCRaTkjQ00P9L9yLHX4s1t2c1T1RrzIuNWTiLNwFPnBVFGQ4E/I2D JWrm/8ExbOrmqaTNuApdDm3niKGufU4KLjmeFpWRDE1g0sy25uALYbElFsFKL3MBor89 FuBw1c9SX4zhHT+KFS6Slf7/WGgPT4WEo1KQb8FWipbQC+E0milLPVfU/DMpce8eSl21 gbXHxVL+CyQFvYDjEI3Q0bdBUnMBrcqOQq0VKdc4Ew5zJ3oEKyZ8xi+ULU8MnZ5rAROn mDCHVx5OFB+PiTNKhRsYRwGSgpZQPSmvgd/22Fw82bLNlEj+1JeGtL+rdNma5SRO1qbk 7PuA== X-Gm-Message-State: AOAM531lJdVqMjamDi7lhvL6vr/aGuX8Mr2L/36y6ddNVk9NYRoY+nxy 6lGtiWoYgyyosX6Btjq0QsiQxvl0h0+AzdryWm4= X-Google-Smtp-Source: ABdhPJxDek2LF7DP9dQwX8JsUtw5IjZ7CSYqmNP1d7EoPpSzK2QvG0oE35HNRG+acwZBCFxDmSTzHlpcQz+HRWeMW0M= X-Received: by 2002:a05:622a:1746:b0:2f3:e05f:ade6 with SMTP id l6-20020a05622a174600b002f3e05fade6mr2001007qtk.479.1652919631137; Wed, 18 May 2022 17:20:31 -0700 (PDT) MIME-Version: 1.0 References: <20220509074330.4822-1-jaewon31.kim@samsung.com> <20220516173321.67402b7f09eacc43d4e476f4@linux-foundation.org> In-Reply-To: From: Jaewon Kim Date: Thu, 19 May 2022 09:20:20 +0900 Message-ID: Subject: Re: [RFC PATCH] page_ext: create page extension for all memblock memory regions To: Mike Rapoport Cc: Andrew Morton , Jaewon Kim , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 31D96400D5 X-Stat-Signature: ncsrg1831aa8d9wsoazzpn1rpcxhaqtq X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Qoo2GAm1; spf=pass (imf17.hostedemail.com: domain of jaewon31.kim@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=jaewon31.kim@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1652919607-462963 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As I said it is v5.10 based kernel. ; Actually I am using v5.10 based source tree on an arm64 device. Thank you Jaewon Kim 2022=EB=85=84 5=EC=9B=94 18=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 10:31, = Mike Rapoport =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Tue, May 17, 2022 at 10:10:20PM +0900, Jaewon Kim wrote: > > 64 > > 59 > > > > 2022=EB=85=84 5=EC=9B=94 17=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 9:5= 5, Mike Rapoport =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > > > > > On Tue, May 17, 2022 at 08:38:18PM +0900, Jaewon Kim wrote: > > > > Hello Mike Rapoport > > > > Thank you for your comment. > > > > > > > > Oh really? Could you point out the code or the commit regarding 'al= l > > > > struct pages in any section should be valid and > > > > properly initialized' ? > > > > > > There were several commits that refactored the memory map initializat= ion, > > > freeing of the unused memory map and abuse of pfn_valid() as a substi= tute > > > of "is memory valid" semantics. > > > > > > > Actually I am using v5.10 based source tree on an arm64 device. > > > > > > Then most probably your change is not relevant for the upstream kerne= l. > > > Did you observe any issues with page_ext initialization on v5.18-rcN > > > kernels? > > > > Actually I observed only 59 sections were initialized for page_ext and > > missed 5 sections. > > It should be totally 64 sections * 128 MB =3D 8,192 MB > > Does this happen with v5.10 based kernel or with v5.18-rcN based kernel? > > > > > I tried to look up and found the following commit in v5.16-rc1, did > > > > you mean this? > > > > 3de360c3fdb3 arm64/mm: drop HAVE_ARCH_PFN_VALID > > > > > > Yes, this is one of those commits. > > > > > > > I guess memblock_is_memory code in pfn_valid in arch/arm64/mm/init.= c, v5.10 > > > > might affect the page_ext_init. > > > > > > Yes. In 5.10 the pfn_valid() test in page_ext_init() will skip an ent= ire > > > section if the first pfn in that section is not memory that can be ma= pped > > > in the linear map. > > > > > > But again, this should be fixed in the latest kernels. > > > > Great! Thank you for your explanation. > > I will check it someday later when I use the latest kernel on our devic= es. > > The next version on our devices seems to be v5.15 though. > > > > Thank you > > Jaewon Kim > > -- > Sincerely yours, > Mike.