From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2EEC54E58 for ; Fri, 15 Mar 2024 15:44:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 045A380131; Fri, 15 Mar 2024 11:44:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3863800B4; Fri, 15 Mar 2024 11:44:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD92E80131; Fri, 15 Mar 2024 11:44:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CEF40800B4 for ; Fri, 15 Mar 2024 11:44:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A2531A0604 for ; Fri, 15 Mar 2024 15:44:11 +0000 (UTC) X-FDA: 81899694702.07.A7F4DB4 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf18.hostedemail.com (Postfix) with ESMTP id DB2E41C0003 for ; Fri, 15 Mar 2024 15:44:08 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hCbWfaRW; spf=pass (imf18.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710517448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=clGRLHEdZJU1hIbUHWzW6z0FfJkCL+OJ6aU0ekE5bnA=; b=vEPMqhCZ+fkq+S1IJpQ7dcwS55/DLf+gKrc5BWws0v6ZU7uL/y74VtmrpkJo+xlQl8Mcon 5ppY52HNRrkgiJQEbEl1Cvir5BU6cOJH7/keZ6wol0olgatfyrSiYc6CkwcIqk28o1inCh kT01YX06KDtpdFELxmwaIE5Wq/y1A5A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710517448; a=rsa-sha256; cv=none; b=uzVZQh5aZgHNDJ6zPRurjAx6W55Q5EohF8pZCSXfFSaLFW7Vps5snShrkK3g183rk/8bLE B58Nz5DtZW41cfZdauoxxIbqPgqEP65VnSu00Wv2R6Xrg6knHRn5rqBCQvpAws/mhi38oU 0SAAUdCHm5p5UUUDYNqmeIs6wcS44Zg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hCbWfaRW; spf=pass (imf18.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-dd161eb03afso1953913276.0 for ; Fri, 15 Mar 2024 08:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710517448; x=1711122248; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=clGRLHEdZJU1hIbUHWzW6z0FfJkCL+OJ6aU0ekE5bnA=; b=hCbWfaRWROcO0plWuspk66pVFQmxTHxjSa0gdvgR3mKX69q6FS5nwI/JGnTWns8rMN iuStwRtV6KhPgKJ8DCoG2WtMc9Kpv0G+Q7VKVg7gI6jE7mwDbm2WjGeXHuWePlVQghRA BeDw482hIhzAdWv7RZr6k8Ib2en1BOtq2v5GZu2HI5SLnS0Ca8efNf48xCaTjcsGjxBz SU01vXoHi/pZ7MKoH747mPCPrBx3Xa6Als1psNJkEwPOT7iQbj4d5+SIV2eQyoRvy4LX Xs+kckhIPMHzwByFT9NNrP5UjvwLsH4jgS2q1S519/0BsCTitlQvepvg1kNlcIJmZT9A WQKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710517448; x=1711122248; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=clGRLHEdZJU1hIbUHWzW6z0FfJkCL+OJ6aU0ekE5bnA=; b=ZH8IS7SgSl3nHrDpJTpYdIzcTuh8DyRmrlI40aKYTb+62A4vgUpuINVdTBdyqF+Xfm zfcB1viP6VF1Gd0sdRH4V8H9NawUYfxgAjJDGaQ7TW0n4YWXdHuAZYSPcQZGzwnSjcBB DtcwU0QU4VY90oodhueR7hI2OC0PXq6ZWRcD9UEvrUTtEzREtlEJll9P1RSSVAu+1vqJ +u7UQRcheSjX28mN9Vexc3zhcAJmKJeAicN+B5Fgas/xZTe2k7HaHDo5dpqLtxDy2BsO kFyAAGNM2DDWRFos0NmEAM83rBltPl4fmtDvvJOKi1Oqw1gZhSfPhaXJ4ZbqRzayCWaz cykQ== X-Forwarded-Encrypted: i=1; AJvYcCVIeLiBPjkKCPuB5cST/0kEb+Z5mszphGrSx7sitpGWxoyUekGXRNJhB4lkmMJQJQb1y8XWb2xl4f0UrAV/2pPo8xU= X-Gm-Message-State: AOJu0YwFdRfn7O7SQXniCYlMB9kqpUBr8PtvdftShbclxD5mGTECNzh1 zCCQn5HyEBShVhf+SID/1dQ4fgWHJ3Udiamf5cWEGRl/EuoicHH2sQJpfR8TtT2+ihREofbvaRh HNWcbTfvuNauSAGXQRxMA/R2ZgehSFlowlLOC X-Google-Smtp-Source: AGHT+IGAJ13N7pVvU4k2+lrRs5QxLZCCWdNXmROcACjXHKoXZPNi1NEiRR6CnqJxwRRq0iV9XWDMKjHgawP1NzMi2X0= X-Received: by 2002:a25:2fc2:0:b0:dd0:e439:cec6 with SMTP id v185-20020a252fc2000000b00dd0e439cec6mr4700323ybv.18.1710517447501; Fri, 15 Mar 2024 08:44:07 -0700 (PDT) MIME-Version: 1.0 References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-24-surenb@google.com> <1f51ffe8-e5b9-460f-815e-50e3a81c57bf@suse.cz> In-Reply-To: <1f51ffe8-e5b9-460f-815e-50e3a81c57bf@suse.cz> From: Suren Baghdasaryan Date: Fri, 15 Mar 2024 08:43:53 -0700 Message-ID: Subject: Re: [PATCH v5 23/37] mm/slab: add allocation accounting into slab allocation and free paths To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DB2E41C0003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mt9g4gs9du9s7nym3rngrmr493hg5cor X-HE-Tag: 1710517448-929248 X-HE-Meta: U2FsdGVkX1/n6Z6e9+OnDHlJrUrp837MJCL7QOZINZD2dt/l9+Er46TEllB6WbDyu0bLh8X/5FqHtWp3p38mUFuYRtv2bcZPUw7yPbRhIxLruB7ITerbgBexQ+fiqJOW9xY8JForGZ4V99tM5984BNYNLCXjkGD0McWlFOr2NGyXbJDpAw6lAAZQtTD56PowtU6fxNgz8yUAE73zgeUD0DNloOoITbmnOBC1AEP/s2XgUAv4PPqLRkJVHu6M/d1ErlanaK6BXs2cJ8JLZc3JwV3r9F2q3tTq51zBl+OSdGMLjfbXulZkk1gLsL7UoU+tU808A10uug4w1NV3tT/tOmuuirFOOOHQj8m7dUbs4j2ZzZ4t1etbmVj7RvBeRsHY2/drBALb1F5JT3es7URP3X6uFHX1ZtmqqsRZuFIEND2FqDFh4J4XYxogjd4X1EaJXcKIJBzWxZM6hkRNezCakKalMmBgif1AvzefgPCslGGjgKoHlEObLc//oWePS6z83YQBbVTKkQa0u42B+AJdenvsuFvz5jR3XpT+b2E5ZGI+koSBHQhHqIv2fgCYAFX1YhLhu9EDfILErtGrsRSqGqctwGP1XINkwpKS5kwtugM1/8Q5AgJ5sV4pjmlf1E657QNlcRV9eI8L86iyUWEBlAuFFyV6YFLFI65/GrxWEgzYZc+Pb8bLO35GOFT6nvng184VtI1PikyZ6EMmn7wlAFriMl8Etc7kzOCxhYQLouJ1ElFJhi7HD8K5o5IfbLWBEocP810e7g/6rRrymwWcEQ4vHmF0m7tTRAI50Ee6nfYuQmA6FhtV7jw/QOGFe9z8vl6GPtwp+ZMVrIkH1WucrEeImgG7NwYX4LBOQf2I7K4pOf3HOBlCBF2FsTF1HRhN7hrD46oawdw01y1SAPPXovQE3U1RMZbTOKVbTtDkzILe6dnic8pMDjAsrsNbU9UlChE3663wOCgte6wrOMo f/44LHqu GqVbA4oAE3xABvW+nSaA7MTXS1v3ERke8OExiRQQbL53SXr/Ehd62bvmtdIAoaZizxtwl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 15, 2024 at 3:58=E2=80=AFAM Vlastimil Babka wr= ote: > > On 3/6/24 19:24, Suren Baghdasaryan wrote: > > Account slab allocations using codetag reference embedded into slabobj_= ext. > > > > Signed-off-by: Suren Baghdasaryan > > Co-developed-by: Kent Overstreet > > Signed-off-by: Kent Overstreet > > Reviewed-by: Kees Cook > > Reviewed-by: Vlastimil Babka > > Nit below: > > > @@ -3833,6 +3913,7 @@ void slab_post_alloc_hook(struct kmem_cache *s, s= truct obj_cgroup *objcg, > > unsigned int orig_size) > > { > > unsigned int zero_size =3D s->object_size; > > + struct slabobj_ext *obj_exts; > > bool kasan_init =3D init; > > size_t i; > > gfp_t init_flags =3D flags & gfp_allowed_mask; > > @@ -3875,6 +3956,12 @@ void slab_post_alloc_hook(struct kmem_cache *s, = struct obj_cgroup *objcg, > > kmemleak_alloc_recursive(p[i], s->object_size, 1, > > s->flags, init_flags); > > kmsan_slab_alloc(s, p[i], init_flags); > > + obj_exts =3D prepare_slab_obj_exts_hook(s, flags, p[i]); > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + /* obj_exts can be allocated for other reasons */ > > + if (likely(obj_exts) && mem_alloc_profiling_enabled()) > > + alloc_tag_add(&obj_exts->ref, current->alloc_tag,= s->size); > > +#endif > > I think you could still do this a bit better: > > Check mem_alloc_profiling_enabled() once before the whole block calling > prepare_slab_obj_exts_hook() and alloc_tag_add() > Remove need_slab_obj_ext() check from prepare_slab_obj_exts_hook() Agree about checking mem_alloc_profiling_enabled() early and one time, except I would like to use need_slab_obj_ext() instead of mem_alloc_profiling_enabled() for that check. Currently they are equivalent but if there are more slab_obj_ext users in the future then there will be cases when we need to prepare_slab_obj_exts_hook() even when mem_alloc_profiling_enabled()=3D=3Dfalse. need_slab_obj_ext() will be easy to extend for such cases. Thanks, Suren. > > > } > > > > memcg_slab_post_alloc_hook(s, objcg, flags, size, p); > > @@ -4353,6 +4440,7 @@ void slab_free(struct kmem_cache *s, struct slab = *slab, void *object, > > unsigned long addr) > > { > > memcg_slab_free_hook(s, slab, &object, 1); > > + alloc_tagging_slab_free_hook(s, slab, &object, 1); > > > > if (likely(slab_free_hook(s, object, slab_want_init_on_free(s)))) > > do_slab_free(s, slab, object, object, 1, addr); > > @@ -4363,6 +4451,7 @@ void slab_free_bulk(struct kmem_cache *s, struct = slab *slab, void *head, > > void *tail, void **p, int cnt, unsigned long addr) > > { > > memcg_slab_free_hook(s, slab, p, cnt); > > + alloc_tagging_slab_free_hook(s, slab, p, cnt); > > /* > > * With KASAN enabled slab_free_freelist_hook modifies the freeli= st > > * to remove objects, whose reuse must be delayed. >