From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18228EB64DC for ; Mon, 17 Jul 2023 16:18:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A80B16B0072; Mon, 17 Jul 2023 12:18:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0A0C8D0001; Mon, 17 Jul 2023 12:18:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D2B56B0075; Mon, 17 Jul 2023 12:18:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 803426B0072 for ; Mon, 17 Jul 2023 12:18:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4CE821C8D33 for ; Mon, 17 Jul 2023 16:18:51 +0000 (UTC) X-FDA: 81021612462.01.12D5F30 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 665B5140024 for ; Mon, 17 Jul 2023 16:18:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rUEFODFk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689610729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zPld35tg/88s+aC92Jlr/bLPaQcHtcJDXofog7vdTC0=; b=PS0KoRWv/O/OVPYJOQG6XY/MWAeJ9jJEqaNEkk9DlQlkLfpSX4OuA2OD6aAvJ8+mO+6jxz nqsPYTwI2d64WPsagTWhkhFjZx6XB99qG/bWDblwsHnwVDQMv306XEhnjrU+wWzjqMJ/zy 7r8iHX/TPSR3mEIhDkk4RSRxly281ZI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rUEFODFk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689610729; a=rsa-sha256; cv=none; b=iOe/HkCqMcimXQeB35SFKTarUf3T0ZSafc4fR4m98NchiWKYILawpGP5HGAdI5qrSae2Rv gWv0+q9X9ErL3njaYcdGF9ybiaLBxDWuRnmuMTnGfIycrqweN2BBczt8H2mS0m8ZsVa+7m BOmhIr+vIkbLWj1CCIHvsR/osyi382s= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-bd61dd9a346so4915377276.2 for ; Mon, 17 Jul 2023 09:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689610728; x=1692202728; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zPld35tg/88s+aC92Jlr/bLPaQcHtcJDXofog7vdTC0=; b=rUEFODFkoYgdZSNmZYu0WAAiBX+7zwMN9DaWeFJq9S8JMu1VgwDFfM7ZEbFHFey4NT Hi30/ZocrZjnNQgu+KUSEX6K1MnmrV0Ata1AQ8r5YPgGvJOYrFGhSf4PuZdBa2fbpGnP T+VKG1rBxyPCArzbJzjMdgwjaDAxp2gpwrb3pf3016w9aqCnp/IQP1xTOyAZydI+Wd1b 3jLIvmJXigWtAcyKe/9XqOpq9Ws/k0ykHfSVJferOgd/vLWeifR5H51KPPsFl3qhhPmp w5mp8A5T2L9rwpf0QnIgpq0QNHjLoWI9rAwVrfZJUIHvF6gaDC+m6Z3tRd06Rhc6cR+Q BzJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689610728; x=1692202728; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zPld35tg/88s+aC92Jlr/bLPaQcHtcJDXofog7vdTC0=; b=e4feL8HC7/6N/sTjj4XCbx3NvodB4eN97lQtodRwfH8wCofouDLlafZnxaYq2I1zTs EaBQilhTRsqTYbVilHGEFi/aVjfOm7bK9Ca1VYKZKSUxBvb6PUlZ9TM1RFPiuIjPyKk9 4CTkkSAw5DYekaIUpPgWYaANGODIGYF8u68efA3Js4baKdY7xtlPRlBkmv0TNKDqQWPg fCsJYLUQwq7s+liBwsyD+Bddi/c1twE1jE7NdhhcanZEuev8Er8UVepjFVOoCeDdZlsS oxidB2Hr7b6a0LpJYD9MlmdugkCKKRa5mLtxqq1FWmBGiuGSXM1Bhf+R4zUUyOOj/fMZ gZrQ== X-Gm-Message-State: ABy/qLZ8dgcIdpAIdkOIC4EPFhMHdMuvYYCSgirOHuHa9sHaDxzFc+xj Wq8afRhQ/lT32r8KgwRZrrjS1yhmTD4acsPtvEz4iQ== X-Google-Smtp-Source: APBJJlFcDJsJ4IT8rxAHkj+tB3hIZLB7KNJGC3aAFo9EOLIuoyo1zON9sZyTNFVQzgYPI/6dCVeXFCltsRuHhgwEXGA= X-Received: by 2002:a25:9187:0:b0:cc7:c3ab:c4e0 with SMTP id w7-20020a259187000000b00cc7c3abc4e0mr6755897ybl.36.1689610728199; Mon, 17 Jul 2023 09:18:48 -0700 (PDT) MIME-Version: 1.0 References: <331201b2-5f13-8e81-b5d4-b17f8784d498@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 17 Jul 2023 09:18:34 -0700 Message-ID: Subject: Re: [bug report] mm: replace vma->vm_flags direct modifications with modifier calls To: Yan Zhao Cc: David Hildenbrand , Matthew Wilcox , Dan Carpenter , linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Laurent Dufour , Michel Lespinasse , Jerome Glisse , Michal Hocko , Vlastimil Babka , Johannes Weiner , Peter Xu , Dimitri Sivanich , Mike Travis , Steve Wahl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 665B5140024 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: eo9ehigpnaogzrzhb7th14s1kd1edsaz X-HE-Tag: 1689610729-74529 X-HE-Meta: U2FsdGVkX186F+4+EAOHuSFXKx9O1fID1B20SxcQwslxZHbruX2veGoL+P5u6dOhXToPmwnKBtQsof7t5qeYt+E3TDP4EjDDZli9gVDAnopG8N3xgE57XqxZiaHBoTqqry7zN9fBHueicwUoXkAJ7s+Pr/E1M+H5tiJ/EhZCJpbOCxalVQ8BjvHuJXZFtjL+/UvUrVj5yLHZyXJGBRD+YQG+8MNZyfdHqgiGdZN2qTB/SC+8yZNJwM9XT4PdPoo1jhztz/BbvQHTwDokQCsaa/aT+B5cg2xe9WPWZnKFjOR0YzmznPLJI7NvPyuEwB+NCF60aINmfpUAz3GKnPkHJnS//SWOSUfFK3dv+ZxMyJvIceD9iql5sJJf4ukm+YkEuEzrYDzp+rVGwOCcgCUN8ktCKwY5DvHQO3+XJR4x4qhalY8yFZpQ4YJ7H3f6d3zOM+xpSpO9F3bHltcD3O4x/QqoAPKvoGd4UBJ3+e9QWI/TqKgJ0bqGZ0oB2G3MpRUXSDlRLaIr3vW3WKSWlYokw4kbkt47VA8L56D6MZeYUZ7SS/ajn5z7iJQnow5CqQUgpZEjb2DvsQhoYTsK+XYZMSYKgA3KetA9+KxMK+Gt1ioSp+9oM2ra0SaZQFpQstsOJd4rb4qKklQOiDOa+7o1cQM4gaC9eYrQPJl26/cXu1lxcEluYojUxwuFufrXvHdM5bYy8s4OoBVELtuAMDnBEubZCrDE0kR1tkCmbM4uGAEiuPCaZ8CUCIog2GC4hrEzmib3yT8kf1jlRG0G/iW0oxA76eOxaUoA3xlpnnl9y8K1XDgR21dmjLMFnDRvAWkavf3QNFnAtfZS6FCYRUTZbbjm+mqbsVzu5Ffdwjh2RoqqnyG5qi2FkfL+zGev8/OD2iAh0brOkLKCxVQUbnK4o6rBYYLMraWlpKVdCZ5wMYsERydhcGftwCxY2ohjBVvh2L7RWXGcze3zud3V2EJ lGVPLy6U 83P+GB6ZzjY26bjYGH4MEW7aQhLWEEtfYBxeYFT6gQE/Z1HDDh4av2+2+2MyjdTzqw/epzVpTiRtrnbVyNBxx7Pn+wlTE458Kd/Qfyz8Gof2dckdS7BTTiQE7exeKaxCAFfGCnzzZW0ArvbLIsGUIbc7kIfT0l/GUU0fh0qRskJWKzFcD2sUYUfY84etCFwlzEeBQA9ZfkIjfkv9wNjmAuvywTNqjC1eb9RRrcsVnFqXQhDEJsTy4aa32zMtZ7RPxNm9XqbPYNvwcuzzRND9JAB6DiyFkEQ0tTaXAfN5hGOed/Ic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 16, 2023 at 11:40=E2=80=AFPM Yan Zhao wr= ote: > > On Wed, Jul 12, 2023 at 07:48:06PM +0000, Suren Baghdasaryan wrote: > > > Would we be able to fix it in stable simply by not triggering the > > > vm_flags_set() in case these flags are already set? > > > > I think we can do that. gru_file_mmap() sets all the flags that are > > set by remap_pfn_range_notrack() (VM_IO | VM_PFNMAP | VM_DONTEXPAND | > > VM_DONTDUMP), so we can check if all bits are already present and skip > > the vm_flags_set() call. > > > But on x86, remap_pfn_range() also sets flag VM_PAT. (in track_pfn_remap(= )). > > Is there any interface to allow device driver to pre-set this flag in .mm= ap() > before .fault()? e.g. export track_pfn_remap() ? Driver should be able to call vm_flags_set() in its .mmap(). >