From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AEEEC54E67 for ; Fri, 15 Mar 2024 15:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9225680132; Fri, 15 Mar 2024 11:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FA95800B4; Fri, 15 Mar 2024 11:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C1C780132; Fri, 15 Mar 2024 11:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6E20F800B4 for ; Fri, 15 Mar 2024 11:47:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 278F8140C0C for ; Fri, 15 Mar 2024 15:47:14 +0000 (UTC) X-FDA: 81899702388.22.3736DF6 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf11.hostedemail.com (Postfix) with ESMTP id 562384000B for ; Fri, 15 Mar 2024 15:47:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="eCAZ/p8m"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710517632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5hTYJR/EPYVQveJbg5FctPr1PKFKWOQ5oCn+BSWzHW0=; b=xonZT62cchksTrcmY+YL7G/kBG+RuQ20SnVytmx/imfl00YHBDRgliNq8fnRrweKiuEOHg JHUhkLWYF193RF3JhL81ZLe9U4hIIAmL9kixl5S3tHm4YLbZ42oMpz+Gkc1KLFXn8mbvc5 6TfudLscqgCFlMq5pU9lolRGymfq+6o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="eCAZ/p8m"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710517632; a=rsa-sha256; cv=none; b=zPoMZobX34NPZrQf7qWQyD/ZMvgsOJsLGWb6Cipm8pbxv1zNhWlSAcgO2nKvqGxMYQXp2Q 8l4pxQsuj8tA18318lHpL2fUaFfwL3/1Kmg8WlLHA6jEUANLKsJBtn7mNM1g/G7RI8DtNV AphOZ6hbKSYUJXpwtXQqDt1HTsvZmC8= Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-dc74435c428so2080070276.2 for ; Fri, 15 Mar 2024 08:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710517631; x=1711122431; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5hTYJR/EPYVQveJbg5FctPr1PKFKWOQ5oCn+BSWzHW0=; b=eCAZ/p8mrkt0cBAgVJcFbLcM5iHBVqAkp3jTlpmr+dX5oHUCsYIIynndoT7UMmn7oW CXEs/xm6HMJGne8XVaOPuxs/s81C0JQZZ3K/QrbshFW+5tqChC5L30XZL0WNeUybSMuc 0FNUL111HA0RF99VF3dfirMdgbG4bRrrYXasrhXbpIryia+AP1lcjslcACeqOryQ7bKs He1IUjAlzsm6ZZLaYFym16oGp+xiCqXqZ3cFuYH7ijDYK+ne6u19i6RQifRRIpDnkgNg TteVvT1A9a61rAiROEOEILRjt+Eqc6ZGw/iv5elp0bCCwZeCgB0hUAWSXfNvD1rEkMF1 fRXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710517631; x=1711122431; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5hTYJR/EPYVQveJbg5FctPr1PKFKWOQ5oCn+BSWzHW0=; b=OUwtR6kxqi/CULZTi9hS1VHt29pg5X96+dnWBXbVCjjYTKE37/3O5GipLhcQhA3rJJ zRgSYA8SM98pV8Z6DEk/Efc9VvncYXjy9hw3UGxFW8PekeFfVkQWsk0Kr6z/BzeyWgB7 vd84dpk+RkyBAgBUoj+PYEPV2qXRIaU8PZIqwBjXw8LHvOTj4H5BpgE5URLKgeZg4C2F kpcdm3YA7bo7gnQ+NFjSS71PTWjGDjbBCgg3BegjwXv0j+8g611T+dDgDfeBexGqMEQ+ 2d4su3aLmbmKtFywQkYQz/4dBH5AU7TYNUSIOl0txmdP2BW19jYVoduOjdHfkxMa9iqL QDpw== X-Forwarded-Encrypted: i=1; AJvYcCVLjJY+uKj9TbdpfRjtD3lYi8hiA36pg4S81m7y1zFLcxxLbXul4/Y3mv9pu8NbDsMsVSgJSshCgVzDm+VcE1QkR9M= X-Gm-Message-State: AOJu0YwM1mB4kyW27VCqLZ8JGcB3dIBPD5QveSdRKAq3ciybzpXwjeZ+ OE5KmwLb2/uMImgLiQM7y4BqzO5jpADycCR6I8lQa+x7GgbA8b48oqw2NlaaPu3d20pzMWHmrKa N4qoTDTteFO4v+bp1eXFUDyqoLzEZMg7pmr2n X-Google-Smtp-Source: AGHT+IEwiyjib3jLb0fcW3RfIFy8PuKVxjXiqnQa/2aHEZk0YzBmdn1yExjQqvOF2tJR6SyIA+70XUnt7nI7TF8fE6Y= X-Received: by 2002:a25:ad5f:0:b0:dc7:4f61:5723 with SMTP id l31-20020a25ad5f000000b00dc74f615723mr4966380ybe.39.1710517631010; Fri, 15 Mar 2024 08:47:11 -0700 (PDT) MIME-Version: 1.0 References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-15-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 15 Mar 2024 08:47:00 -0700 Message-ID: Subject: Re: [PATCH v5 14/37] lib: introduce support for page allocation tagging To: Matthew Wilcox Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ruiwk5yuapyfkah8g1tqqumtbbfejifd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 562384000B X-HE-Tag: 1710517632-660665 X-HE-Meta: U2FsdGVkX19K5ulIYqJEq3RGhesacw2X12Rsav/xPDRDGu6uKe20PU3SfWJU0OHYyDjRxpwLRPLv/sJhbBQEjqWbVVO/SfFAJQp/sl6G3LU/OqkSxjAR1JSPZP+vODm/SWQFMLJ2DA0F91Kuo9lRZ+EwfvdLXAGyr5Yk4VFU9zr7mIQcckaA6nKYG04MyRt17Zj02sAI1qVKE35CkWGuft1aPTZyBMC3gz1z4niAkaAtPsNPlzOBzMa7tRu/H0YrSO+M0Dlan3LID897+zpgSrk0LeZ7jSLpZ6M9p6vSFb9kL2L8fCBKaldgRbHeqH7y0qIJErLbqG3OWbPEWW5K4BtWoh+TPmMqsZWUvFwD5lh9qjlz6yk+oBciinEaPlW9tQ9tEPdDAi3BX7xkQqr8hxnEUT+YuD7oc50C8Pi6fYj/WRdOsrT1SB2ySHizLNXx4LXeF7yNZwyNuuR0NlSaf2GizMFG8rbV+Ek34+zx552yP3WbQc189LgSE9zUU0mhC1SaOkgggAWxnycvLMbQm7hzuXGxD3g56AazjYCvzt8pNt3xA+Jz/J8AyE67tTQ2k3lTdkqbdNuc21w351rvAtV+AixcZrZCd7hziZ8nkMUmI8VTfZ291pKnsw2ffGN0f19EnRtQ8YN8EvF2Jk3HtOLYzC0u7z9P3FiSBqJd8U2ti5ZEr8UueQpBA8OPdLGfBgvrLi2b1oIOh62hjmhW6dYMkk1N5pcESr94ydVBLZnmTTSKuuMP3SdTU7zbU9DLiLCZUZ1e6NfQ1nif1xv2Vm5HrQQZDaoJhy5czfDKg//TcBkqdoton+XNNZ7CiA0r+135UNpBH7W3YUDEz4tNWD8DKS75D2FrYqmRcyYX/7ogYBVTJqspL59S1MXwAWsg7+5l7fuXszT/IjPzwOPW1YsABQ/m+n2aEclT5cT9n8m+Q8EN6ZLFv3puxhAXIqQLG62/NsiYgjvfVbFaMWm wyKmkLIE rvmsSk0GtyDTxh5XSYmqF8x2P08N+1hVltGtE+7ijuqEDw9gcq4jdc9J/Vow2RK7xMPahpDKYnlVE7rV+r269/A1LpG9jH4s8srN6ZjzJJUtaUxGAuGT4xBReUyq6+8WqX/2vic30IeVfFeYhkDLrKI6QXu+ThcqUm8x8tp2FSt1GND33qdUXdPk9hPx4bndPsv31yEixU4WwT5pL9FOJ4FMG/NU7epeSX1cNuI7yR3m25HMKPc58WBXrYTq6sUlEVTfn5yw261Xkt4quO+XK3Kx8Zhz84ddRtp88t6j/JFA97Z+XdjCH7c0iKR65GJri41zYPoyEytaqNE3GNGhH7Pvy2y2BuslgKw2YavveoLpXFdQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 15, 2024 at 7:24=E2=80=AFAM Matthew Wilcox wrote: > > On Wed, Mar 06, 2024 at 10:24:12AM -0800, Suren Baghdasaryan wrote: > > +static inline void pgalloc_tag_add(struct page *page, struct task_stru= ct *task, > > + unsigned int order) > > If you make this "unsigned int nr" instead of order, (a) it won't look > completely insane (what does adding an order even mean?) and (b) you > can reuse it from the __free_pages path. Sounds good to me. > > > @@ -1101,6 +1102,7 @@ __always_inline bool free_pages_prepare(struct pa= ge *page, > > /* Do not let hwpoison pages hit pcplists/buddy */ > > reset_page_owner(page, order); > > page_table_check_free(page, order); > > + pgalloc_tag_sub(page, order); > > Obviously you'll need to make sure all the callers now pass in 1 << > order instead of just order. Ack. >