From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A26BCC30658 for ; Wed, 3 Jul 2024 01:58:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3651E6B0093; Tue, 2 Jul 2024 21:58:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 315416B0096; Tue, 2 Jul 2024 21:58:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 203516B009A; Tue, 2 Jul 2024 21:58:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F2D3D6B0093 for ; Tue, 2 Jul 2024 21:58:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9D1A480638 for ; Wed, 3 Jul 2024 01:58:21 +0000 (UTC) X-FDA: 82296781602.12.2E10238 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf01.hostedemail.com (Postfix) with ESMTP id C82B140006 for ; Wed, 3 Jul 2024 01:58:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ytzbTuTG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719971880; a=rsa-sha256; cv=none; b=rYMvBluL2SijtX++oi33KoerwgOFplN7+69pLyvOEx2TNXl1vYo1afaP6/1muQ1kkH2bCO 9RmQeV5LbcEgiKvSFen6h38/qbI8XvrzEtJCls8UhfOvl46C6aQPA7n4aqy5lvtgREiMj9 SkmpbCwru8FZmbXC53E9LC39Swva8RY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ytzbTuTG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719971880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uk0GJoRHfWkj7+H1v6+2c9m8FurjseDBIprPtk/NzQo=; b=yBVOTq49eMWzihn4wrPsgkEtQgMTmCAZCRhzBx1yuuHr6mZ/KsTgsQu+wUMcYp0pY2kIXM ufnMP9G0dH0TcPB5q43gleGVpW7VCcArLRADNknW80bmKgQdTlQ1J1ei1T1I0fiVSZV6wA i6Ov7wVvJCe6qLmOMYAKLy2sbJ9+DbQ= Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-64f4fd64773so26826667b3.0 for ; Tue, 02 Jul 2024 18:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719971899; x=1720576699; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uk0GJoRHfWkj7+H1v6+2c9m8FurjseDBIprPtk/NzQo=; b=ytzbTuTGi1dorO/V1rt9A4WhROi3I48uDG0OE8FO8TAde6zIx0w2EfGeoBLIJR/Sjq FLZenfK2hYw+67AgUhrPYHsli9MasDTUFbr8k/H5A4szt5kbjsg41Ume81JcLiXZWFkp Bel+VLHWIZ4PHPZ47CThdVXxFsIiRrmmZ1G5ibvfInZ61PylVE3vnOVNop5Ylalbu01U w3EUFFfW80C+jfAkl9X0OMEyHqkNYsRBg2TEplYIyjY+fK+L3ldxR5XTXOGcqHDgxOBT VGGq+w6g3sz5y9XyPxttQ43B+KvnKzH/Qmsl70lD6jH/QDr8M6P95x8dezf6YSGCPjvu Rajw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719971899; x=1720576699; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uk0GJoRHfWkj7+H1v6+2c9m8FurjseDBIprPtk/NzQo=; b=tLX8PwY2iBA2XyX/5oCEezBrXtet54zVkjFtEeggdP9F32VTJAXNpEWF0wxSKT9iRl Dm24Mrw4PvS5pLz1JAvFtSo5SDDRpD6wvnBAM/Jd28emKUtPsL3UiWOa7HNM+szDGyMc ZQwjv9lfTQcnQIXkbivNXf8BanfSUcssc6Q5nxrOEXRJBnpR4LQ7QoeBzzoqVXm+lDWh 172+lNJTUfJFBmsGGHMCi8NSIR7WKkCPhUDpn+42KMHR/e7pFG95lLMnEXj2AQZDeHxx DGGCfqaJ1NXGsU7fQA7LZV/LyN9RaNYs9qCWJ1BeCGZ164RS9tTvntmyAB7pA/fn42Er zwvg== X-Forwarded-Encrypted: i=1; AJvYcCU3elE5BKgPxmZkiiQnlQQgWFIazYrmAC4xL9M6RpMjDuPqXLOv9/l/g62kXi+BSn4sd+ezrKOohyfM5RtC9UPqDoU= X-Gm-Message-State: AOJu0Yx6Y4WFIh6w9f/xiSIt2xOvC2KjYTHSizH8r8Q3csVDgVtKN1Tl pAm0ZmsmN3a/mkuFYahc9YToxripWMZZ/8/yzYW2Bt23iXY5rUq9mMGNsnJbcsKKHeuRGHZB5BZ +kS5d0Z+PoExP8y3p6lplUax5pjQpdV5KdJYg X-Google-Smtp-Source: AGHT+IE8CJ8oZ/bFRW+PT5mM0jYJyPu79xaWWoRxA+P2hfKfYSP71RYPrsSK3I1bMf+QJ/tWAKxB6EBa4neIA7TmBoM= X-Received: by 2002:a81:ae18:0:b0:650:a40c:acb1 with SMTP id 00721157ae682-650a40cadb0mr29215107b3.28.1719971898541; Tue, 02 Jul 2024 18:58:18 -0700 (PDT) MIME-Version: 1.0 References: <20240614225951.3845577-1-surenb@google.com> <18a30d5c-abf3-4ceb-a7fd-2edfd8bee2a8@suse.cz> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 2 Jul 2024 18:58:05 -0700 Message-ID: Subject: Re: [PATCH 1/1] mm/slab: fix 'variable obj_exts set but not used' warning To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C82B140006 X-Stat-Signature: q5mpx4y4bc5yhx4yjwbkcp46a7npunsi X-Rspam-User: X-HE-Tag: 1719971899-872605 X-HE-Meta: U2FsdGVkX1+aEySnr7bHm1axa4bYRYIqEDnV0DhqbV3aD14cDnJERhwwRQDEF8+SwEjgM4kFbUA+F2vwdCTuacVAGBc+UQjLK1i1wxGWopcD5aKVUuv80zBFdCRiPsndSCS5Cfoc54rJkkXbe/TCmIDyZCoOaWwzFmCJY0C4kAQgJfbn4qSoqQdg7HidlMPIqEpeG0997dHKCDpremo5rN3O7xNorDLzDXH1mTd1wGEXAGrasqpciwuVwH3gBjNjj2QkiupcTHp2cvt2UUH0W6YNaBeZYpXZUgoZ8hhNif5AiJAE8vCImmmvvvNooWBDlMaN5s2tKA3hwg3FoaCrC7jGNVBRHl69fqLN/Js8Mtrz8E8+Owj3Dvlf9qkwaIhwOkoXz6jQbdZuBHtDMKCyp5HGvUTolFOiUogboJ/x9OzUL5ek48sBuE51DmaiDyaa8Sd36m/YFUTh3gTDSolrJcG3iWG2gCz5q7GE1irVAH1Ilz2+tOm7pXmL2Mvzqx0IG9LuDy1tT+s38qCRITMQht9dlzDHKZv+/+6s58qiqa4TTy91/fk0kYIhJwPkzQF/ZjZd9bUcKdqR8WVzTRuhr/4eEyLEjKsyyuVnawPsnP/lxwgrYKvfB4wp44NDEDmQognTDdOmxyl/jy8ZmoGrUYk4SgJBaG9phDtMAebre+hSCXBLH05v1PvL8Au5w9hkO7/qzve7o8tn8Z0MDn9iHagLBhOKnDmOXXdV+ju2Pe8K4nnSoxfRyhr3fTB+DpZtMC2rCHZs9U749cw/GUNyam0xM0XvT1rjSWX9DPyZ7Cm4EJ+YnqdAfaubBwLkYNz+9ai2eSlpjaYIJU0teGxz8QeWAoXe81flXB66xcWwNkonuQoG/L85gcdt83X39t/svK4iFdiupORv+SxjP7KE3yXpxf/G9nHqzf4Ohr5T8es9Da8Po18Q9VbRfqB+M5i/sjl1zxt6baCRbcLt5PG L6Klqt61 H4Ja4cgvnfhsyKRZGfQuUulfavD+VEoF2dqZKex3oCNB0CXRsUP/lTO6eklL079ds+B9Yy57V/PPCKwdjq3UbuQhbmG3mLzda8RhbtujHw2COw6rCiMp3Zc8PufcfAWeRpQjYu9v/wVD7PYrpbny1aNKeLh2vZ5NB0mpD57xLEUtz1PJVASbZegUzIN/NN1LsQia0rrdAlBiSAT2zQDlb4XKDrodBx+yDkoq8sz2Yt3DAXviIfow9mPW/QQG575ToBRqsA72hp+NbHSrJbCw/T81kaawOzbck/eOlAmazZKz/NPhfx7Wf/omyikli0E7LxZzn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 2, 2024 at 8:16=E2=80=AFAM Suren Baghdasaryan wrote: > > On Tue, Jul 2, 2024 at 9:31=E2=80=AFAM Vlastimil Babka w= rote: > > > > On 6/30/24 9:20 PM, Suren Baghdasaryan wrote: > > > On Mon, Jun 17, 2024 at 3:04=E2=80=AFAM Vlastimil Babka wrote: > > >> > > >> On 6/15/24 12:59 AM, Suren Baghdasaryan wrote: > > >> > slab_post_alloc_hook() uses prepare_slab_obj_exts_hook() to obtain > > >> > slabobj_ext object. Currently the only user of slabobj_ext object = in > > >> > this path is memory allocation profiling, therefore when it's not = enabled > > >> > this object is not needed. This also generates a warning when comp= iling > > >> > with CONFIG_MEM_ALLOC_PROFILING=3Dn. Move the code under this conf= iguration > > >> > to fix the warning. If more slabobj_ext users appear in the future= , the > > >> > code will have to be changed back to call prepare_slab_obj_exts_ho= ok(). > > >> > > > >> > Fixes: 4b8736964640 ("mm/slab: add allocation accounting into slab= allocation and free paths") > > >> > Reported-by: kernel test robot > > >> > Closes: https://lore.kernel.org/oe-kbuild-all/202406150444.F6neSai= y-lkp@intel.com/ > > >> > Signed-off-by: Suren Baghdasaryan > > >> > > >> Acked-by: Vlastimil Babka > > >> > > >> But it seems to me we could remove the whole #ifdef if current->allo= c_tag > > >> (which doesn't exist with !MEM_ALLOC_PROFILING) had an access helper= , or > > >> there was a alloc_tag_add_current() variant? > > > > > > Hmm. I'll check if current->alloc_tag is the only reason for this > > > ifdef. If so then you are correct and we can simplify this code. > > > > The fix is now in mm-hotfixes-stable but we can cleanup for the future = as a > > non-hotfix. > > Yes, it's on my TODO list now. Thanks! obj_exts->ref was also undefined when !MEM_ALLOC_PROFILING, so I moved that call into a separate hook. It's posted at https://lore.kernel.org/all/20240703015354.3370503-1-surenb@google.com/ Thanks, Suren. > > >