From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F7FC48BEB for ; Wed, 14 Feb 2024 22:36:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C44FD6B009E; Wed, 14 Feb 2024 17:36:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCDE96B009F; Wed, 14 Feb 2024 17:36:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20446B00A0; Wed, 14 Feb 2024 17:36:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8CA486B009E for ; Wed, 14 Feb 2024 17:36:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 59A83807C7 for ; Wed, 14 Feb 2024 22:36:21 +0000 (UTC) X-FDA: 81791869362.24.AC2CD9E Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf17.hostedemail.com (Postfix) with ESMTP id 87A794001A for ; Wed, 14 Feb 2024 22:36:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XtgVIc3P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707950179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mIZ+3Vimc+Fu9uNEqwRF3MpLhrYbsxAAnrlrt3WNttw=; b=XJXlqBfzp3FBpI8plXjYN7h+sObP4tSS1BjtnQoMF0QBHXbFODayEo75Eg598Bqnp8ufzL JKX6c21s6b8o/9IUTkzlqiNeyEG3nvxgPRIp2ckaNdbA1Dixr7MQKfO1s9A7psI57f6Co6 Gtxzd4+5P1xE9192I0fxkRy3kDqYwbs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XtgVIc3P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707950179; a=rsa-sha256; cv=none; b=a9rltlroZVWPYT+ODpWPxO+dQ2spktlkWlbceNiB6O7w1VhlNrdMNIP7wxWuAo7RhTVCRb sHT1vJoOoFGNEDcV2K//n6WdThlqxG/Q1TYreh1GO+PL4T3vh9pXGO2TDwvWHeV0ZuIDPo K6ufCtJNqqmk4WVglnjL1AmRCLZDV+M= Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-dc6d8bd612dso205193276.1 for ; Wed, 14 Feb 2024 14:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707950178; x=1708554978; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mIZ+3Vimc+Fu9uNEqwRF3MpLhrYbsxAAnrlrt3WNttw=; b=XtgVIc3P9RuArCF9vQIKWfLHqc5k0Zs1o7d3YaLTT1him5o/DfaVRJWFqBOoQTkGLc NWZSxkiZLBNSOfygrOp7Tnn0z6/Vug922SZ4VP5lcTbSaOJIg6rUGaf0xmeWING1jB+w h70bT/EGzV1+1VbZrWqxOPzsRcPiPq3VIGsGv/hRwahzF2OWIyuioiQ25vcQTuRYP2sJ vI0QdXbyM7HzsF57rttAd0T2RUEu/+ghcJwxH+BIayQFIB7wszLWHQaHmaCzeHMReNE7 ExVG0ge4SAUg5psJwbmbh8YLVVuILmzJFqvBH3WEdIYecppOtIavdmeRlTANDTL55rz1 bQCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707950178; x=1708554978; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mIZ+3Vimc+Fu9uNEqwRF3MpLhrYbsxAAnrlrt3WNttw=; b=RLCPdd2AzKBDRhU3A8/+Ypjv7P+zrlwbRFwXx6qur7jWk+uB18edHqk7iC32TlkHnJ WDFXKpIoqEl+O9aYq3+e0Ycx4I8K/ZBTMhM7/IEbsWuk11atLAdHGLMDPWODWkhuOGc9 9XdA+yCszg3v4ms6NEvsfXtaQ1Dx//2r8ja+6mD+z8uDJ0zOQQCuUFbEm3pqRQasP/ra +TprQ3EHBYTJj+u4ojMKuW8BSo5XtspQzCgzH4zadWuowz5viqYDkncrk6qWOLe5LmJT RytBMcVcZgca1LZVR3QseiuIblEXXnmwzIE4ENf3K2Q2jA2662RPZaetsO6qWMdB/p63 QJcw== X-Forwarded-Encrypted: i=1; AJvYcCVv0Hs1iWmnSxICIm9dnbY7A6BdGg07UYYG7AG8GrdYfryWgY2ozw87Sxb73dhc6AtZLcQ9piCMz64i8pb68LclA94= X-Gm-Message-State: AOJu0YxpRdFKm34QvryHbIjuJCz2GhtYBVvk++5PKYsFZDEaYyZHUOIy qE0me93Nrh8Sob9c+lhfjUL1WxEnvddPhJ0g1xD4jSjlauEKVZjRPn1MZaQjLmyX6LNo4nN9IMm 3BOJEx0pioL1ijvt/d1Nmwc3HH5LzNiVyTc5j X-Google-Smtp-Source: AGHT+IFGMo5QMzgB4haA8j4PHefAYH0QGMXhhajKI9bA2/lcKpgWtoNuuV25DDWG2rPEqNS3u8mi+lX2wk/W+0Ufusg= X-Received: by 2002:a25:208:0:b0:dc6:9c4f:9e85 with SMTP id 8-20020a250208000000b00dc69c4f9e85mr3483617ybc.49.1707950178324; Wed, 14 Feb 2024 14:36:18 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-26-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 14 Feb 2024 14:36:06 -0800 Message-ID: Subject: Re: [PATCH v3 25/35] xfs: Memory allocation profiling fixups To: Dave Chinner Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 87A794001A X-Stat-Signature: hc8y6uf8m99inqad197micbiubutywxd X-Rspam-User: X-HE-Tag: 1707950179-935083 X-HE-Meta: U2FsdGVkX1/y5N4kARmobCz5+wBUuMl91gPaCn8A3W/JdyzkreqhOIFio6CItEK4W890gthTaOCqHGKJME8Y9o8szmRvFOCeUK0Cj8HDJtvAekdEbwv2nz/A11dscePuW1WO5gD9YELNbZbC9690OM3ah7fscfveVUg1d/LZZwJQ0XJWohs7d93FZAIVzdUPft2hKMa+afk2pJHkTZiGDodtM6z/P7rIuhduQFVrlpoNoswXQ9VCHItffzwl+PeQjyILb/bSznMCBLdXcECDifQ+YelsrApxl6H/UysmnFSV7Li4g06F0zNjo9YjTQGP8XV8u12lnvIEOue1K0aefLiKXXqbLspMJ4yyj5/XLtZCalyLAcOZL9dd2vw5PFXo3cgHnDDQqlTGajKw+t9lM10u2eCzK2/yTF0KFcr/f4/+B/IXv3GXTHDO6DYkzKY47OwhFtYPu3i+AfVQnaZ1ALUUFkmGyo12yoaZZEkO6dof/0fNvcaFGyFw9JZytm6JOBNJPqdG6xRA+r0rojFKVPM8WtaDoPzQHKGkvcx4pFJ+Td7ZgYbKmskmzt1lJArktWoZjJm8ERFgfva9vGWLg+HdikNx7Hl8xBDteqTC3WCftpOXmw8E0e8lxDLYQRgiEa5Oh4XHYZKpluJPVkzXggqxvx2Pu1AU4pXa1vg65asZCjAer016R5B4dBhDBMaHOSk0FvnqW689sP+bMlOUrQoWKEhKUm6HaZon5L4Q4vYO2tRUbOoY5KmaLZwFhDPl3U806JMjqAlt3qlvQIjdfDxakP4m9SbNLvMrxersAM868WehuQwf1MqYk3Vud6+gu8+hpPh9irFwNgrmWvQyKLQ5I17qiWxUdD7woixQKxOiQhYmsCTFjFPVz7KPgrQJiahWYtay7KCX8pwHLBhZZ4NPZ0N0G+XfgLhOhaOrwwXOyE0Rmju306qPyX0JetLs8mawVppYVRjoRyRO2R3 vkYChrp4 dSQV+d6sMAUPYp+lLhMEmP7MqFLX46rq1L5j/jGN1q3Wu82+tPgCmZFgVhHYTPWu9UXU6SFNHsPN53G9sMsR9Zb6QNyc4s0WsJAp+gKWpht5fXZJBxgbdonrnMAxlNP6KxX7tcxot9AkuEk9QfeS+1zOmbUZuHx31c0Kkr1LEuFKcOjHXHahkISmZJOTjBsFWI+80dT50HnFafWZnd6zup18Sc3F4yk5jQ+K/UuPq8RQsZb/FsRvy/9b+9/kryZboZyq1R0jPUpcG19Nx3FcVSykqRUw8CbA74jUg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 14, 2024 at 2:22=E2=80=AFPM Dave Chinner = wrote: > > On Mon, Feb 12, 2024 at 01:39:11PM -0800, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > This adds an alloc_hooks() wrapper around kmem_alloc(), so that we can > > have allocations accounted to the proper callsite. > > > > Signed-off-by: Kent Overstreet > > Signed-off-by: Suren Baghdasaryan > > --- > > fs/xfs/kmem.c | 4 ++-- > > fs/xfs/kmem.h | 10 ++++------ > > 2 files changed, 6 insertions(+), 8 deletions(-) > > > > diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c > > index c557a030acfe..9aa57a4e2478 100644 > > --- a/fs/xfs/kmem.c > > +++ b/fs/xfs/kmem.c > > @@ -8,7 +8,7 @@ > > #include "xfs_trace.h" > > > > void * > > -kmem_alloc(size_t size, xfs_km_flags_t flags) > > +kmem_alloc_noprof(size_t size, xfs_km_flags_t flags) > > { > > int retries =3D 0; > > gfp_t lflags =3D kmem_flags_convert(flags); > > @@ -17,7 +17,7 @@ kmem_alloc(size_t size, xfs_km_flags_t flags) > > trace_kmem_alloc(size, flags, _RET_IP_); > > > > do { > > - ptr =3D kmalloc(size, lflags); > > + ptr =3D kmalloc_noprof(size, lflags); > > if (ptr || (flags & KM_MAYFAIL)) > > return ptr; > > if (!(++retries % 100)) > > diff --git a/fs/xfs/kmem.h b/fs/xfs/kmem.h > > index b987dc2c6851..c4cf1dc2a7af 100644 > > --- a/fs/xfs/kmem.h > > +++ b/fs/xfs/kmem.h > > @@ -6,6 +6,7 @@ > > #ifndef __XFS_SUPPORT_KMEM_H__ > > #define __XFS_SUPPORT_KMEM_H__ > > > > +#include > > #include > > #include > > #include > > @@ -56,18 +57,15 @@ kmem_flags_convert(xfs_km_flags_t flags) > > return lflags; > > } > > > > -extern void *kmem_alloc(size_t, xfs_km_flags_t); > > static inline void kmem_free(const void *ptr) > > { > > kvfree(ptr); > > } > > > > +extern void *kmem_alloc_noprof(size_t, xfs_km_flags_t); > > +#define kmem_alloc(...) alloc_hooks(kmem_alloc_no= prof(__VA_ARGS__)) > > > > -static inline void * > > -kmem_zalloc(size_t size, xfs_km_flags_t flags) > > -{ > > - return kmem_alloc(size, flags | KM_ZERO); > > -} > > +#define kmem_zalloc(_size, _flags) kmem_alloc((_size), (_flags) | KM= _ZERO) > > > > /* > > * Zone interfaces > > -- > > 2.43.0.687.g38aa6559b0-goog > > These changes can be dropped - the fs/xfs/kmem.[ch] stuff is now > gone in linux-xfs/for-next. Thanks for the note. Will drop in the next submission. > > -Dave. > -- > Dave Chinner > david@fromorbit.com