From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9FDC54E58 for ; Mon, 25 Mar 2024 17:59:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A36936B007B; Mon, 25 Mar 2024 13:59:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E6626B0082; Mon, 25 Mar 2024 13:59:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ADFB6B0092; Mon, 25 Mar 2024 13:59:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 76B436B007B for ; Mon, 25 Mar 2024 13:59:16 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3E60980944 for ; Mon, 25 Mar 2024 17:59:16 +0000 (UTC) X-FDA: 81936323112.21.D67412A Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf26.hostedemail.com (Postfix) with ESMTP id 6A93514000A for ; Mon, 25 Mar 2024 17:59:14 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fhkgxsZ7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711389554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g1H2/sqpi/sh2ma0fgAVRjfY65QgsbrlBKsllNKG2ck=; b=z9tslP1qsPpNWsPEXYpPN8lrzasUHB+eKT1/jiqwzAVbIa/cPrpLwNo7p45m+EGPyx2Ne/ p8u5/qWB7kdtsg7vFzoGqicrJjWCAUWNva/FlOmMst2yqCxdUE1EBufTq2nuIufGobktbH aRp1LoryaMz1vMvhg1t+E2Y88VTyZiw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fhkgxsZ7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711389554; a=rsa-sha256; cv=none; b=fO/Mei6aneHlIqDrb80iKRvPcL4SHJN9JbqpIHH/Sm3h+0W6TVc9B89MSvkmrNIGFreNWR rTAWcQnVBQumrrJaKL64lZZB3vZeMSoBsDEDQyf5pyPunAlaUPvyGazte23ay1A11IuFVX b7aPkj0AwYZun0sNys7UPUeR/wSGG6E= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-dcc80d6004bso4584545276.0 for ; Mon, 25 Mar 2024 10:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711389553; x=1711994353; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g1H2/sqpi/sh2ma0fgAVRjfY65QgsbrlBKsllNKG2ck=; b=fhkgxsZ7y+hJuA47qeA0b2ffkuEYdTrMx1rawP1934rXlAzMuE/fAj78cPcxDwpWjf jikXYd5JKS2XoFJmcXs18xHGRxG25cJ9WVrynaD/gqha5Q/M3sAQe+kDvxGBywoE7+Bw K9cLtjBX6z+vJX5pBGSuWz+iLE9b739h1uPBiHZ7eIdo622hCihMVfonFA6NEDw1VewY 3hbsNmD7uv1WpVEG8vQKNU2YXY3xmZnLPv5uQt0E2VUEedz1F5Z2m0m0O/OUk25X657U kwi3SyAMYl+LgGNYtUEUQNfhb0wqbc19uIc5neR6K1WtIQEpebotpMNiuVB2Hm8LHCT7 KCDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711389553; x=1711994353; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1H2/sqpi/sh2ma0fgAVRjfY65QgsbrlBKsllNKG2ck=; b=EM9FNkkSLIZsPBprkNfsHN2SC0ckELUs8/MTk/OGufnt9AhZDaUHkF1SSFhdsORcfV zjERlnUK6gHTweBnlrKbPNMjvtqQCqi5eyfV+BG2BJ71I0MeYhwh2DB68qZny+ldzPj3 V98ugCcGJAs2vZAA3xeYaFmbLSwsU3PupZO0dTwHX6fvoFwCCld8yIRfbkTRnpKFVKXZ +3hEmJPLiHasVKJgzH3D+z/2c9c8ENrG+c9t5SMdKcG4e5p4tEX8gamBwCzpmtj5joBj x+z0iU4Cfc3KAfq/BIFkx1YSc9urDZpMxsGjkae+x/gxXu4fZb9MD8S8wNatNvVA9MBz oAjA== X-Forwarded-Encrypted: i=1; AJvYcCWNLUmzgtjeSqNBeVWgyU2ca105CHp72b+USMwxzZuKVNSpCOTyPha/ZjZzTzw24MqcPtt8nTzuZNatA/3r6EADyBw= X-Gm-Message-State: AOJu0YxagxzsJrViaULvfuna8PEMhE/hnKlEmYCaDO6H7i0HrhF31DNr 5TlCIQhPRAL0++DxXlo8s80eTWN73gzQZiC8R/ztfqir52oVfxa4JFcRul6T6RTNYa6vWo0g4PS 1cP6Aqr/Sn996bkSAZuD/KdLG7ym8LPT0s66z X-Google-Smtp-Source: AGHT+IEgRKkwT38dzLm3NHYgLzcPYKNKFESgwIB1AubKuEz+z0q+SxXd0EUwkL4MQOex5Dj9zrOPFPjYxYadJTqh2sQ= X-Received: by 2002:a25:acd6:0:b0:dc7:4067:9f85 with SMTP id x22-20020a25acd6000000b00dc740679f85mr6265207ybd.58.1711389552854; Mon, 25 Mar 2024 10:59:12 -0700 (PDT) MIME-Version: 1.0 References: <20240325174934.229745-1-sj@kernel.org> In-Reply-To: <20240325174934.229745-1-sj@kernel.org> From: Suren Baghdasaryan Date: Mon, 25 Mar 2024 10:59:01 -0700 Message-ID: Subject: Re: [PATCH v6 30/37] mm: vmalloc: Enable memory allocation profiling To: SeongJae Park Cc: mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6A93514000A X-Stat-Signature: tkd9ar8pbg6j65xasowxi5331418q7is X-HE-Tag: 1711389554-73606 X-HE-Meta: U2FsdGVkX1+160zFR+mX8mIt8N+b5bMGou28u0QhegorQRHojpemsJJYYUh+0SIJrgGYiTlYTo2jEmoUbxeoXnfcvDxeNv1AwUvHbj7lvgNWuHOAcimvbcO53hfih/H5G+gyDW5iX4AkKKAyMvB/wBjKaeYVmlt8XaupNjZ9kwoQIA6GAO5uyW5kg1R2k96RlVKPEC058MXAYTSYdpEWyUw5ju6x3uCA7v6LkW5M2nNn4iQn2uTyeQ0OIS4z2ZjcQYnS+QTsjtbadjStEOSytr5VKM8Z4+W+jHdeWiVWzsQThoKaWLbIwDI2fEqhse6Um1ccJS9BRbt7aUAmeq4rI3vXy4qppKzAkVu4r/+ShAJRKCXT1YtXw1SXBs/2+MIm8LawURhlNp48+1PbFsKozdhkvba26qyLOtBnCbbQYtwpxp6HUmf3g6Hkmm0Ipmlohw6yEv+9u0mbXbtDpccWXaMeu5Jr6x2LkcEdNj5KviFr8YqxYVSKP7jAcdUCGejiTdmB52Pbh7uE3PN5d13zpnWjlP9GcOsQFPf3sgAPDjqaJD4PApLIC0I4kuICLvcoPlRuxpnu0gX+F48Py0dMvVMX2Q+FQoOi8SQhXPtDxzBcImTgwwkPIbIJ8hP7XYAFACKxlzOZ8HBVUM32mfBrpyAJ2C4gmFNxe4lS9YYHUcCz96p8N6quaTF8i9IGMsiYKJCUft9bUIc+fMaepxkFUTtXdKyRifEcBXwWFK0fda/f1cVEqUkrgX9pBXZcH2VJ+jQIGnqqtRW12kZtNzGntx2UczSTxfzWSr1NLGCvPkeqvID4VD+4UD50a4qqLXSo/7Wp/CTWkPaDQyudIeO8DkAykTG8u5eQz/NnTGjcvQxEOcwEgqpOeWnRuYyyPs0BXOHylCUGLthP3YUVZyIwNcfE9h6XWY0BE9gPnyjvMhgtlIJezp320RYCAHLxmLfZ3v82PrzbeoXhN0vVKtA dGrifJO0 ZNWqUgtoMqf0Jh9wgsUhNgKVe0110jjvVHbLGbLSkGjae8i6wwSPbvvU93y4OJyF5JBoG4Ie9QCJt4ftlz/5oimJMzADO94t8u4JwvP24B5w+HOn63Dc47jncVEjPiXk145IYy/xd2ozwYpILOOIQpDl39avXYMKx2ErB5I8nEtTPeG53DluvshBQHIquNp4zzIYXO0vNZ3KSdH6FhDSu5PrnCAAY+KUhPr4FygO4jny1brHW7aqqL9j5HXVBC/BU0dD25EgYsnmLpENvhoT69fLyvuZe9hwqZ+aldJqDZuT+KLUAqJfOC5CZUXrrCsKkiWqZAabD4CYusWYwa5OvESCa9nHUX83O61Wnrks9gnVNkAmqz4SkFZMuCpCfFMkGf/+G X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 10:49=E2=80=AFAM SeongJae Park wrot= e: > > On Mon, 25 Mar 2024 14:56:01 +0000 Suren Baghdasaryan = wrote: > > > On Sat, Mar 23, 2024 at 6:05=E2=80=AFPM SeongJae Park w= rote: > > > > > > Hi Suren and Kent, > > > > > > On Thu, 21 Mar 2024 09:36:52 -0700 Suren Baghdasaryan wrote: > > > > > > > From: Kent Overstreet > > > > > > > > This wrapps all external vmalloc allocation functions with the > > > > alloc_hooks() wrapper, and switches internal allocations to _noprof > > > > variants where appropriate, for the new memory allocation profiling > > > > feature. > > > > > > I just noticed latest mm-unstable fails running kunit on my machine a= s below. > > > 'git-bisect' says this is the first commit of the failure. > > > > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > > > [10:59:53] Configuring KUnit Kernel ... > > > [10:59:53] Building KUnit Kernel ... > > > Populating config with: > > > $ make ARCH=3Dum O=3D../kunit.out/ olddefconfig > > > Building with: > > > $ make ARCH=3Dum O=3D../kunit.out/ --jobs=3D36 > > > ERROR:root:/usr/bin/ld: arch/um/os-Linux/main.o: in function `__w= rap_malloc': > > > main.c:(.text+0x10b): undefined reference to `vmalloc' > > > collect2: error: ld returned 1 exit status > > > > > > Haven't looked into the code yet, but reporting first. May I ask you= r idea? > > > > Hi SeongJae, > > Looks like we missed adding "#include " inside > > arch/um/os-Linux/main.c in this patch: > > https://lore.kernel.org/all/20240321163705.3067592-2-surenb@google.com/= . > > I'll be posing fixes for all 0-day issues found over the weekend and > > will include a fix for this. In the meantime, to work around it you > > can add that include yourself. Please let me know if the issue still > > persists after doing that. > > Thank you, Suren. The change made the error message disappears. However= , it > introduced another one. Ok, let me investigate and I'll try to get a fix for it today evening. Thanks, Suren. > > $ git diff > diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c > index c8a42ecbd7a2..8fe274e9f3a4 100644 > --- a/arch/um/os-Linux/main.c > +++ b/arch/um/os-Linux/main.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #define PGD_BOUND (4 * 1024 * 1024) > #define STACKSIZE (8 * 1024 * 1024) > $ > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > [10:43:13] Configuring KUnit Kernel ... > [10:43:13] Building KUnit Kernel ... > Populating config with: > $ make ARCH=3Dum O=3D../kunit.out/ olddefconfig > Building with: > $ make ARCH=3Dum O=3D../kunit.out/ --jobs=3D36 > ERROR:root:In file included from .../arch/um/kernel/asm-offsets.c:1: > .../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previ= ous prototype for =E2=80=98foo=E2=80=99 [-Wmissing-prototypes] > 9 | void foo(void) > | ^~~ > In file included from .../include/linux/alloc_tag.h:8, > from .../include/linux/vmalloc.h:5, > from .../arch/um/os-Linux/main.c:19: > .../include/linux/bug.h:5:10: fatal error: asm/bug.h: No such file or= directory > 5 | #include > | ^~~~~~~~~~~ > compilation terminated. > > > Thanks, > SJ > > [...]