From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F02C04FFE for ; Tue, 14 May 2024 20:19:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A87F66B00CB; Tue, 14 May 2024 16:19:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A37EB6B00CF; Tue, 14 May 2024 16:19:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FF556B00D3; Tue, 14 May 2024 16:19:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6EDDA6B00CB for ; Tue, 14 May 2024 16:19:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EB682160FD9 for ; Tue, 14 May 2024 20:19:35 +0000 (UTC) X-FDA: 82118116710.09.98F61E2 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf17.hostedemail.com (Postfix) with ESMTP id 32FFE40023 for ; Tue, 14 May 2024 20:19:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IFdWCnEJ; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715717974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8hb7xfSX/VQFjXuNhYy1AT8FiF40Meq6UrJ0Q9OaWSI=; b=jCH5a8LS7X+unS67wKdX1sbJK46hIv67LbpB6HQiMm7Ae8Xzc+DnSJrpd/B4/zoctMwRDg cStwg+gux4y1fJCs46at8MdllEfpMbJlc50mdm0wEjRdyrOKwBbNA4VAJjolfOvYzJNNzK DrQsaTM7Np3or4FOVMg76PWBTSeK9/s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715717974; a=rsa-sha256; cv=none; b=JDknVDEJJEkL02QXbt2KCL5NSls8nQ0p+VCqNU2jGc78IgFYCEXLMYgxx7GGbbl5Zfgkbh jubtU5i9R2LqDLqeDvcDSosQUzUVrTSaWOf4/Q00HNc5e/+M5nDfi5Q4khlqhRuGnVVtm2 e9ApXlqeOQ97aE1CygSkyV+Otiy93vY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IFdWCnEJ; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-622e32414ffso30440297b3.1 for ; Tue, 14 May 2024 13:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715717973; x=1716322773; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8hb7xfSX/VQFjXuNhYy1AT8FiF40Meq6UrJ0Q9OaWSI=; b=IFdWCnEJrQI3eyj4EBFdKj/29Q8LJv/miOVlceuzfE4wPcIzjG/GuXH8x7Wl2UWaGM FVWiY5FvYO8wztgJLzxIJW1NV3DfzMqs3/U63kOs4qSAvArYn8GNRMPYh7zhTKQ4TgHH 6lnwJp8vnREdxSMetq+y2yzERo9y2JYiYIoleW575Ct9nPLQEL+gfrZO9KMwI3EJH/sW Fy+KVXVDzaUn0HVNpBT0v8zh0KZPPInBnkIo3NZ0+SE+QZj6zwhm+9+orJTyShOzNc5P bN7Rk2TIlN+8VnbcbPHVv0eJAlY9dUthT/zGFPjvjf+G6McPP3iL/BKZFiQhbqq5TQXj +tXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715717973; x=1716322773; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8hb7xfSX/VQFjXuNhYy1AT8FiF40Meq6UrJ0Q9OaWSI=; b=kW55LVQfWXI1pJZdlOKxLLkSB0geulNvhGz8sPDWZo+f8UIN12G4PwmR5cREWC76Wg 4isDIy5VWCf+TKI9KvGU9ZizJu2w9593vvOh2ao+AO/H+tQz9I9qgMX60Fj3JMC7rA4n pYjnmRShVtinwN2MYhHtWubKUXTs0DBOCnBR4Equ6Srnqh8zSQJzdgOas0QLmUcdJm0n llNJty2FwXE7eHrFv8WQ9sI8cem6sXJFO/8sdJn6HJlJ/Zp4naJzxchNF2qKHSXz68EP HSA/WY8FJ3FAGVdjwjTaoIO5kW5+rjLT1yED6tXlZSA9BRfIdYfOJTLtKujxtP4lVTn+ gdLg== X-Forwarded-Encrypted: i=1; AJvYcCVnoHfMq32u1PoGGEuUQ+mo/X0opKjWhe/xMzXpljKd+WSmCew4CZOlP0QRa4UJP+/I41GskNuIDOP898fXu7ppSEw= X-Gm-Message-State: AOJu0YwBkXBUEkjlM37FTz0F9tG8y1mPFyELWEzY3FZ731IP1tuECOCz mJ6XT2xtNRF218y7Fz8xYRT5S1bCZH0mttIfgonduIW7lLFvkC5Q7CuncG3ss/Qe0at6ctfbZO5 A5/CkjdA65rIRY2eRdBAPlTy/G/22lJ7Gjyz+ X-Google-Smtp-Source: AGHT+IF0OFILt+I7s+gtnueoup30JC7tJkxqSmt1mTfiiTyFdrB2xvE1WcfGDmSBB02xHb0OOmS8gf0eZcoIH22ncJ8= X-Received: by 2002:a05:690c:386:b0:614:74ba:f91c with SMTP id 00721157ae682-622aff93dfamr216111377b3.19.1715717972903; Tue, 14 May 2024 13:19:32 -0700 (PDT) MIME-Version: 1.0 References: <20240514163128.3662251-1-surenb@google.com> <202405140957.92089A615@keescook> In-Reply-To: <202405140957.92089A615@keescook> From: Suren Baghdasaryan Date: Tue, 14 May 2024 13:19:19 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] lib: add version into /proc/allocinfo output To: Kees Cook Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, vbabka@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: hu4s16caxsqp158is1gnes7mkrknay9b X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 32FFE40023 X-HE-Tag: 1715717973-914535 X-HE-Meta: U2FsdGVkX18tylv/tIrDAbxh2TwYpRfVGPn2B98UiINHsg86GbF7buAyLKdZMge0Zmj+mx59uRtsPfOCTNPcnFKUxZgYo7E4ZweEnB9O3DlYtMQjCNLsJP2fVFGoSp2uFfzheY+LfDObL1sbwAyb3KA44fgCEZ7vAhyKUCoM7xU/HenVdOa2e0dQJ1wjiG1tg2hp36kgDud2Xh9GwwNBuHmYkQjqyQR3GdB414jF546ldckqK5mb+GZbmn6hHKoRQQ/gYO4n39elvAiPtuRYqlTOLD+mBqO7Y3yeTIHBLHb9Xt++jd24q/80DuQYaZ17USBhS0wYlMQHsdpUodtv/unLcPLFa0P4QwhwKSCFCedb1t5/E3RLtC4AoX2fGFQqdTqtrN8gdQMBraS0t0tVH1/XrbkBeH7UHLKrS63AeSnCjtXMZ43QPadrPui1JVVRw+ct2iw8DcHUE5ZS5JmVRjwrPEAOjVaccGjQW4PkkFu115mC7E97v2YragvBgIr68XSIYspQzIzQNOTyq45sY+jerlcCkJ+Bkc4xtkcgT6SGq8A4O1CwMYnyfnjkopXeZB5BawuhO8oZQ6EkwMvDtdxJ5tMEYO4b9vQre3Uf5LlEbtZ/CSgWzUVOfDncOrEQqvgWtR7JaETFwVnl0yZ9TtuvtfSGmRtC6TqYJHlqXarJPG6K3rCrGxGuK2o5lBW/l1NccFXpyXtKzfN4Bsj0KuBul5HMU1Cs0Q3OVavo+QCUhveb0UNpkiz6KBnsw465g6t0en/DQkiZP4dWvmNDU0Fjklnp1K84uOWvQ5cXP+LfxWbQmRnduZZP1srodDoYVTX7+56opq4fnSH7qnisIOTm+jhbBMXscHhUi6k3MEARHOb184jBsQLtIeP7tSNPfWuctEfiMmrB0Y+qILmnoC2Oj4Q5s1fX+qSrtiCF903CSBIEtzu3nFvITbU/LlQ+zTAqhG+l9aiye56ze+V 81XQ+i3V B0cJOszGjw9ukK8nLTJGo//J6r4kjb5OiY8C/Zf4vAhpfjW33L4uAbGM8kOMkVs6/4F1Zw3wt6AMycUO7H8NIbG7C8QILNEj/V6UduXYRoC1Ezmto7QNEky5sQg349BlkHYxshNXXRtsoOuOBk55A6K+r5WhN10xvEXIQMbC2hzVHR/0TkYDMfxOD+DBtwWOnAgxbF2TwnCyI84VsAQrYe4TcavntjSPfR5NohGgzxgQeHCVU5xmiy21L/iyYvTC7AZfC0Jf36Hvs552XnyiTsYPfYVVWu4QwQo5+qQ8rKR51yfmdd22xd1+H6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.005595, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 9:58=E2=80=AFAM Kees Cook w= rote: > > On Tue, May 14, 2024 at 09:31:28AM -0700, Suren Baghdasaryan wrote: > > Add version string and a header at the beginning of /proc/allocinfo to > > allow later format changes. Example output: > > > > > head /proc/allocinfo > > allocinfo - version: 1.0 > > # > > 0 0 init/main.c:1314 func:do_initcalls > > 0 0 init/do_mounts.c:353 func:mount_nodev_root > > 0 0 init/do_mounts.c:187 func:mount_root_generic > > 0 0 init/do_mounts.c:158 func:do_mount_root > > 0 0 init/initramfs.c:493 func:unpack_to_rootfs > > 0 0 init/initramfs.c:492 func:unpack_to_rootfs > > 0 0 init/initramfs.c:491 func:unpack_to_rootfs > > 512 1 arch/x86/events/rapl.c:681 func:init_rapl_pmus > > 128 1 arch/x86/events/rapl.c:571 func:rapl_cpu_online > > > > Signed-off-by: Suren Baghdasaryan > > Ah yeah, good idea. (Do we have versioning like this anywhere else in > our /proc files? It seems a nice thing to add...) Yes, /proc/slabinfo has a similar header that includes a version number. > > Reviewed-by: Kees Cook Thanks! > > -- > Kees Cook