From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B024CC54E58 for ; Tue, 26 Mar 2024 07:51:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DE876B009A; Tue, 26 Mar 2024 03:51:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28EF26B009B; Tue, 26 Mar 2024 03:51:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 156C36B009C; Tue, 26 Mar 2024 03:51:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0758F6B009A for ; Tue, 26 Mar 2024 03:51:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BA5C2C09B7 for ; Tue, 26 Mar 2024 07:51:37 +0000 (UTC) X-FDA: 81938420634.29.8D227B2 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf22.hostedemail.com (Postfix) with ESMTP id EA38EC0009 for ; Tue, 26 Mar 2024 07:51:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yMacr2v4; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711439496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=shklYWkLA2oyBqnlJsmv6lUxL/P85ZOYE2ckd/gba5w=; b=vHdsg4JqCPQ+XPl4/rRzSUHO11Ogxm4ybkzbCj7tXeyKUVNwnmsieLRM/1BBFgC1hU7wYc ZJEwkDfoC7WTcbQ0vYy3BhvjT1jxOI1D5r89UUudtU2HL6KX5JgKQXte+FoINhY+qvNy4M ZpAZYevhuUIDPAmG0SowcCh3jKRpwic= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711439496; a=rsa-sha256; cv=none; b=oI0MtaprIgIf0Yy0hD0s61h1jOzyBw7mBsmJao/9Mgy4X8Yc4R5jpIK/JNex33KynSO7xr i5zlSGQ2FRGzuaFooWVV6gl7G2j5QzretaRpQ1M1/t4teSD58B+IYh+ewRpcUlE/SGltQU sqQF30md/4VDp9/FTAPeXtzoFcyiWwA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yMacr2v4; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-dd10ebcd702so5305996276.2 for ; Tue, 26 Mar 2024 00:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711439495; x=1712044295; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=shklYWkLA2oyBqnlJsmv6lUxL/P85ZOYE2ckd/gba5w=; b=yMacr2v4aCkPBkD90a2G3b7VsQjxEoPXb/pQNbFKwFO9ObVfp/MtvRhGqCwxxZE8vi /ytqjReF5VB+eP3Fr9WV8Lz9g/ICmk+yIfisN+5JRC11QLLHX3vNuviavIs8jjj2a+bv ffAlVqRrix8AxxiXiOga799RpZmcxipBw8sQJeVXVM1Ndr9ivvW320PKKhYJ8nMOmbUL iCUo2VAixxHhpimUWpG3/I8GGExVfJBg6rksCa2LO399k1N/oPN/w2/9Z5lZCXUBofRf jSy3AwQaeJ0jBwa2fNlkDig8IZxIyrAo9zdkQpueQBbST0i7cMKXzQSVzm7uEjS3q4WO XlPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711439495; x=1712044295; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=shklYWkLA2oyBqnlJsmv6lUxL/P85ZOYE2ckd/gba5w=; b=Q46ekaDoaLka5bvZebUDE6HQbLBoRawLLFt/Pxv33Or6J5nG+Z3cPJCwWwC8qSn2Pr nnIVIohj79gsoAfKE8dKz1/Urxgu1AzfVbSjYOjzvF58DhrtdtPkBmRDka2p/jmoczcC I4JDl9XqamJi4w7L48rlCSiBQu3PpFZb9vzBEz6nhda0EGuioj/ZUn+vPuzm7huW3Le9 uv3WqMDW+nwkMTwpZ2pC5Dc3438LIXHdc3PwHpGHZ19GYBgBCL7BBA/pOtaMmNlxTn2a aDuI/FWdno/7kgvota3kVEVnB8ElmAIzDNMR2BuheXD6oInET4IaMVWafA6QqvRAQfxX MSww== X-Forwarded-Encrypted: i=1; AJvYcCUSbRF0ofLSPsQM4QVupm7Czk5J+l3ky3+EYv1fMBmZckL3ioN2Z/yTQ4/CHMjHVwcPNON6wtYnD/iu40FGOJ1P8X8= X-Gm-Message-State: AOJu0Yx9jrB/7UMNHkVfbXPgFM34RR8HL0eZDZ8I+XCqKePWhVuEzDlk mS2JWYs8Y0SygkKvQ3CCk1KtXZJr9Y4mmKLirZZzd0fzzw64zswANJ8pcUjcwc8aYQIDFlRBXXP hEEFt60HBBpiDjCH4AxFxwZCoXBcYknU2Rvlo X-Google-Smtp-Source: AGHT+IEnVh4+gbIjqfTqnNSb1ESniynB5/g+eF5Tlrl382kaRHENtFyyuE83hIP6W791lwHTf2P908O7iGBHbxnvUiU= X-Received: by 2002:a5b:181:0:b0:dce:2e9:a637 with SMTP id r1-20020a5b0181000000b00dce02e9a637mr7603025ybl.20.1711439494844; Tue, 26 Mar 2024 00:51:34 -0700 (PDT) MIME-Version: 1.0 References: <20240325182007.233780-1-sj@kernel.org> In-Reply-To: <20240325182007.233780-1-sj@kernel.org> From: Suren Baghdasaryan Date: Tue, 26 Mar 2024 00:51:21 -0700 Message-ID: Subject: Re: [PATCH v6 30/37] mm: vmalloc: Enable memory allocation profiling To: SeongJae Park Cc: vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EA38EC0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: u4fb96i6tjpoo6jm56pnf18ijm3cdw6m X-HE-Tag: 1711439495-51127 X-HE-Meta: U2FsdGVkX19YJ2QBQmV3ybUiBYPLSn+bbD7/8GpSuTfNwLYPJAKK8Doum8BpRRVk9zWFctfB94xJlwlsNCypPjkzSvxmwAeFOMSjUILZjYsMCO2fuHH/3DCyULV19sLuWxIZuXlR8NBxy9CcnV1KusRTz/hBWTffLUWXfhdjTtkJXFzWehyA2foEUFrFdbrtqvbeB61z9fkgVjnNzrv6HHEcMdZx927xB1N2pBzcjz1y5x4TTd2f0cly5ewFt6Av95BViooJ60xQUop9xAJNPR1Xv+3ZkCQIvjR18beSb4eBmcqVDiDk9w3+STpdB4QNAWA85FrM5Ydbq7zfUjujEt0pVxB2mJKl9a/VQEUmLHKG+qTK55AZqLRlBVHGz2WWMCMQfpq00UYS66vrr8aHgx1OoPE3IZL6iBtojIjTRmZ3Chlx/kTMIlUTWKtoqN8GcqaSiO+E80/Totcpn50qg0ebP5+VTSb36QhSZSNms+1To5rPksyb5/o5jxDxpZF2kTrXLVoLCIDAMPJJ8mFWTGsSrEBFm9BidO7ffwZV/y45/YiYPD1koU8wkqniIdeX1Yj2tBBhTwjp8k8ziw8bKoK8t+Fnk4c1L8odOxIcZ7lKODDLPKMadbLdrw/p+gU3ey6y5ZmlUOHbwt+NaxE8X/zeJMB4bM0Iw49fq5hzVI4IQ/MO7AftYLMwC8bSpX4cRpRRDtIoVKvpBap8ol1NkOOwVPFc6kLxk45TykwzeVGGdmOYWUKOv9p98n3lQmCOnOPk2w22ftsdzvTe42M+ThGvI3cFxz3Rsaik2INcns9pQCZ+oeIWegTOUgFObiacFP+GyL3JCdmgXfh9fYFZ3edfH95e9Bxu7204nwv/s4Hho8cBPNKhHCveKjVqAqS3ax1t01IZstl/8OzWvQVwdxOqi5DsJfVX5uus6ijzx5dm03pkgK3fkwuyrmdNTz/4Ux9XMT8LDTD4TQwejgP DqmFXS0U /nO7aIpKisqNUvPFV/2XaQtqSwWe5BHTZcEgI064wUYm9uxXndpg9C3bqdMzOsH30WfR8+bNyUX8/+iUEaIHeyKQGP3j8TWyDKZhtdiWaxuUK7ieO5TMHut2cE+McgpHHNqcwO7kxSvRS2jFcCmhNVuIIFn7Y0tTa/9MFCn1L27p2PGXqviuDzeILG/y8D1xScMi+BWzgqIqPt9cq4zsn0dcweKDKxj0rFW2WTw0YgmLMWkEI0979xc4TqWP1eRLIs8ir2uVsL0YD8O+jkuPt4C5cwcFxUdYElPbqMzhK48SC52zf+jOYW8rNhP3b+B3apC1czLAv12PmYYXiK9gYCZpqZRK/gbj2cXpRwW+CwMGoUki5R0TmsV3BgrRP1kXW7RaaSu+s25P066NMnvMGYJD0A7AYLTTRZYCjdNbtMNth/lM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 11:20=E2=80=AFAM SeongJae Park wrot= e: > > On Mon, 25 Mar 2024 10:59:01 -0700 Suren Baghdasaryan = wrote: > > > On Mon, Mar 25, 2024 at 10:49=E2=80=AFAM SeongJae Park = wrote: > > > > > > On Mon, 25 Mar 2024 14:56:01 +0000 Suren Baghdasaryan wrote: > > > > > > > On Sat, Mar 23, 2024 at 6:05=E2=80=AFPM SeongJae Park wrote: > > > > > > > > > > Hi Suren and Kent, > > > > > > > > > > On Thu, 21 Mar 2024 09:36:52 -0700 Suren Baghdasaryan wrote: > > > > > > > > > > > From: Kent Overstreet > > > > > > > > > > > > This wrapps all external vmalloc allocation functions with the > > > > > > alloc_hooks() wrapper, and switches internal allocations to _no= prof > > > > > > variants where appropriate, for the new memory allocation profi= ling > > > > > > feature. > > > > > > > > > > I just noticed latest mm-unstable fails running kunit on my machi= ne as below. > > > > > 'git-bisect' says this is the first commit of the failure. > > > > > > > > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out= / > > > > > [10:59:53] Configuring KUnit Kernel ... > > > > > [10:59:53] Building KUnit Kernel ... > > > > > Populating config with: > > > > > $ make ARCH=3Dum O=3D../kunit.out/ olddefconfig > > > > > Building with: > > > > > $ make ARCH=3Dum O=3D../kunit.out/ --jobs=3D36 > > > > > ERROR:root:/usr/bin/ld: arch/um/os-Linux/main.o: in function = `__wrap_malloc': > > > > > main.c:(.text+0x10b): undefined reference to `vmalloc' > > > > > collect2: error: ld returned 1 exit status > > > > > > > > > > Haven't looked into the code yet, but reporting first. May I ask= your idea? > > > > > > > > Hi SeongJae, > > > > Looks like we missed adding "#include " inside > > > > arch/um/os-Linux/main.c in this patch: > > > > https://lore.kernel.org/all/20240321163705.3067592-2-surenb@google.= com/. > > > > I'll be posing fixes for all 0-day issues found over the weekend an= d > > > > will include a fix for this. In the meantime, to work around it you > > > > can add that include yourself. Please let me know if the issue stil= l > > > > persists after doing that. > > > > > > Thank you, Suren. The change made the error message disappears. How= ever, it > > > introduced another one. > > > > Ok, let me investigate and I'll try to get a fix for it today evening. > > Thank you for this kind reply. Nonetheless, this is not blocking some re= al > thing from me. So, no rush. Plese take your time :) I posted a fix here: https://lore.kernel.org/all/20240326073750.726636-1-surenb@google.com/ Please let me know if this resolves the issue. Thanks, Suren. > > > Thanks, > SJ > > > Thanks, > > Suren. > > > > > > > > $ git diff > > > diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c > > > index c8a42ecbd7a2..8fe274e9f3a4 100644 > > > --- a/arch/um/os-Linux/main.c > > > +++ b/arch/um/os-Linux/main.c > > > @@ -16,6 +16,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #define PGD_BOUND (4 * 1024 * 1024) > > > #define STACKSIZE (8 * 1024 * 1024) > > > $ > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > > > [10:43:13] Configuring KUnit Kernel ... > > > [10:43:13] Building KUnit Kernel ... > > > Populating config with: > > > $ make ARCH=3Dum O=3D../kunit.out/ olddefconfig > > > Building with: > > > $ make ARCH=3Dum O=3D../kunit.out/ --jobs=3D36 > > > ERROR:root:In file included from .../arch/um/kernel/asm-offsets.c= :1: > > > .../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no p= revious prototype for =E2=80=98foo=E2=80=99 [-Wmissing-prototypes] > > > 9 | void foo(void) > > > | ^~~ > > > In file included from .../include/linux/alloc_tag.h:8, > > > from .../include/linux/vmalloc.h:5, > > > from .../arch/um/os-Linux/main.c:19: > > > .../include/linux/bug.h:5:10: fatal error: asm/bug.h: No such fil= e or directory > > > 5 | #include > > > | ^~~~~~~~~~~ > > > compilation terminated. > > > > > > > > > Thanks, > > > SJ > > > > > > [...] > > > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >