From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDDFC46467 for ; Thu, 19 Jan 2023 18:54:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC8176B0081; Thu, 19 Jan 2023 13:54:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C77EE6B0082; Thu, 19 Jan 2023 13:54:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3FD86B0083; Thu, 19 Jan 2023 13:54:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A56786B0081 for ; Thu, 19 Jan 2023 13:54:02 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 80FEF1A0A40 for ; Thu, 19 Jan 2023 18:54:02 +0000 (UTC) X-FDA: 80372448324.22.C3A3F61 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf29.hostedemail.com (Postfix) with ESMTP id ED72912000C for ; Thu, 19 Jan 2023 18:54:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=S6oQkRuW; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674154441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Hbmn5N3c+7Gw/65T8JMoIPDAauVRxveWrxDyVKiAmA=; b=76t42vK25o21Zm3/yLV4FjiUQ/6IpMF0733JfxjN1Mognpvd/CbVcvfDdMUtomXfia1NDF B3x7rp/L7MryQLkqmRzza+hi0mYl2qfTQTzUyNbxIxfpFoV093vC/8Nk7km7b1abkNd4nO S7K1+DzoPeLG5rkcEDWLvN0dP9BpxEs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=S6oQkRuW; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674154441; a=rsa-sha256; cv=none; b=38ySceIF6Vt4+DdKo1sjYHlE18jnbA1bYRAGrys0574/pO2eBaF3C2QGin6N+wNKcYETKN RZpRCdTU31l91GFBuG6rJmG+ksr9TEKdND2Vv91Dn9ahDicgfM/bGRSQGqlnFHG2QXarki ML2yQD7ezN/FUJcdTfoNY5iuFBULzKE= Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-4d59d518505so40932527b3.1 for ; Thu, 19 Jan 2023 10:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8Hbmn5N3c+7Gw/65T8JMoIPDAauVRxveWrxDyVKiAmA=; b=S6oQkRuWnpsm0oT4EY6oDOfbr3SfXlxJH7te7SWEg4g+g+QkCCIHJyVvM61rjUg1bK HkfEMCh9wK5lUJodmfbK7ainv+lY3roQVUMfL/HPP08y9A44w50DedT2R8+d8v6OsM78 F1TH/xLu7+OsivESTUy5pd8reCLyw5qIvwYjlAer3MZE9HacN6KiXvaYX56dy/vQTL6m sMkWfVw4nCd+YFJpTFuBVoDSt0VVx0yiFR6Ta24SRikrOGCNJ6oWFq04ugwVJaexrHis KMRX04ZxKbH2WCPyNDn4xag8MnSxGtMyIm49/3pOUlsPxEuRxCjxT98j/0u+1IwkNR3v eyrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Hbmn5N3c+7Gw/65T8JMoIPDAauVRxveWrxDyVKiAmA=; b=lgJLvacyGKdDa2j/FMnqmZRtW0DrntaiSqUe/zaGOtso1ivjzkUtkpeOfTmMVBjELb E55xdnjBhDcMJLL0CXrxiE052cWC/MTcyeq84p7U78kl4Zt0Z5J6Nz381ccJh/+UI6C3 XEa5y0s7BnyHZdJ381qlC8rF0tVIerB98KmjJQdCZlOZvzd04fB6yQBYng7UTHz8z66a T5wBkxaVzy2VmI8xGs2voF3BCmp/C4M8rI2mO1RKkdbK3kKfb5QJhHtWVISBIdLIMF/Q WwLyc5CMQmD2mFFq3SqO/gnPmEDTYkCUwayBg2eXKe+2d9w3NDha9QNdJIH5Ul5Ewvxg gydg== X-Gm-Message-State: AFqh2koPUkWIXf4P65hZ+2EEFvKjSzTqxiInwVujrHg8UDBTBxhO35hh VrqRDqm6krJ4tUTGMIe57e0x26IvAT24Myv8znwcpg== X-Google-Smtp-Source: AMrXdXvv2B+4vOLYHk76C7CB+4Wx7e94nPDtbp7xYrGWt3A23raxsvG0sNfvN79p2SmRHXJoa8xn07dPoTTQDNsV7Bk= X-Received: by 2002:a81:1d2:0:b0:433:f1c0:3f1c with SMTP id 201-20020a8101d2000000b00433f1c03f1cmr1593029ywb.438.1674154439858; Thu, 19 Jan 2023 10:53:59 -0800 (PST) MIME-Version: 1.0 References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-18-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 19 Jan 2023 10:53:48 -0800 Message-ID: Subject: Re: [PATCH 17/41] mm/mmap: move VMA locking before anon_vma_lock_write call To: Michal Hocko Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 5eso5gwdp6ha3dh8mxtio1hqnoar19zt X-Rspam-User: X-Rspamd-Queue-Id: ED72912000C X-Rspamd-Server: rspam06 X-HE-Tag: 1674154440-851416 X-HE-Meta: U2FsdGVkX1/BkSw1K75cyGeuwW6n+7SyITuUdGJYhXHABi+rJtyJyT52Was8xXQ8QeYKSY5cLnUj3KZBcCKARGVYDueORSngQ3ENalVbOR57ENpY4KjmVGPnyUGrw6efmV42JpAKWY/h+pWjgI3odCk5AUBEvCcS/7+9vL/4rEdi5gDVCF4dQuM/OEIVpao7Q2bd7wrP9z/K6odqGO1fSV8PmqRzQKHkYN6Dt58PFqKbSedvDsAxpE3/vDlQiFiGVYIFCntY9BXJVjl8CIjG9+wUIFA4xi2aH7nT0sTR3iTRH+e36+dTbl49jkF+dNmvGIK1UvS0UE9cBNjnYM/KegJHhzsKU/zbhfWdSNZmdOeil6XfrRCLlEA5QWItxLUqUc0q+ImlwH1QL/sJfURx9lk/kP2x3aaktoo+OdsmtkNp9VbSo2K6Frd5dNyG3UkosfAGH+I2O2KHetSzPllmraaaNdjxaramFQYyk5O6C+i8xAKakma/gEvk6MFocoIr/4OURJkPRbQlsYfOBHmFO17SXW1WkvhMy/Dig3M5MGEMfnCnG1g11RnkelECFjtlXg+n8JommEvZXUtqwBypmxgadcoCfSpHC6Q5JsdIM1mxAORnd4DugaaqrmEYpZDCoFofM0ddoL5nuIHp4n69J0+jgdWv24c4IN4SQDSULJqEYKWWfCERYgwV8h6sQnD/Q70BuW7kZnUtZU+yWMRIw+NhTUbOfdrvFaoygdRZRl7iNga7XrcCB2kAx9ZsgvrsN4LBFIwA8GP6B6aS3S0W9ItDoBVBNBGEN40NIodTVWUbS2DTvHgC1zoT+bPCPznysdVjaRMC3pO/2MsOWjbRgZJrEFf1iN/p0T3P3M0TxtVKMJrCcn5uT8njUPFLz0aQlleQT1LzdN/kFd7/Y1ySVZmdBVzPXu7YMfrxDdlzR52pd9BvOBZUNRWJkoHjV9XMBaR3lPwNug5GysF8fcR T4KB1WN0 2fjwRAxlqNjS/sQnRrwJW4D3WFlqdsyDwFoFfEdPJ/gCaSL6IyZUkvQDufg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 1:31 AM Michal Hocko wrote: > > On Wed 18-01-23 13:48:13, Suren Baghdasaryan wrote: > > On Wed, Jan 18, 2023 at 1:33 PM Michal Hocko wrote: > [...] > > > So it will become: > > > Move VMA flag modification (which now implies VMA locking) before > > > vma_adjust_trans_huge() to ensure the modifications are done after VMA > > > has been locked. Because vma_adjust_trans_huge() modifies the VMA and such > > > modifications should be done under VMA write-lock protection. > > > > > > which is effectivelly saying > > > vma_adjust_trans_huge() modifies the VMA and such modifications should > > > be done under VMA write-lock protection so move VMA flag modifications > > > before so all of them are covered by the same write protection. > > > > > > right? > > > > Yes, and the wording in the latter version is simpler to understand > > IMO, so I would like to adopt it. Do you agree? > > of course. Will update in the next respin. Thanks! > -- > Michal Hocko > SUSE Labs