From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24ED0C64ED8 for ; Mon, 27 Feb 2023 19:51:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A12F06B0071; Mon, 27 Feb 2023 14:51:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C2886B0072; Mon, 27 Feb 2023 14:51:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8639D6B0073; Mon, 27 Feb 2023 14:51:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 735C46B0071 for ; Mon, 27 Feb 2023 14:51:02 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 43F41C060D for ; Mon, 27 Feb 2023 19:51:02 +0000 (UTC) X-FDA: 80514115164.03.57DB699 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 7DEAD20004 for ; Mon, 27 Feb 2023 19:51:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=lg7t5OPU; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677527460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O4AQL8i6WYgk4Tqy8aH2abmGlvkaKXw9l82KiDgJYLU=; b=G2eeA3LWWJ8ivhRFsSbMz/yzluC1uNe6EkepOPrRZfW8NSh+GXGNKOqdsbs0VdBFnEcC8j oPAcKZ7ALWlIN4pZ3jOlrjhPS2532r7OOxZFVgK4LgA4B1ta5Y3o+Y6S4/nc/1CvOKVZiD 9VJdmR6rm3Kv5QRvhB5VCo4lZesWpPE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=lg7t5OPU; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677527460; a=rsa-sha256; cv=none; b=kSDt+Bplj3H2VuirFP4ypbuvNX8JMFDgSXYF1EFQiM8t5bJ1H6/kAShqDT3Iv7APwQ71NX I26iEdyrmrXSr8+AyhMQ7t9v05hOQYENFvMB1OiCVloyfLlbbFB83PUSsoONsiGFCX9fy1 WFmiWbxRF+i3RWW3skQVY4AtiLdPBnA= Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-536bf92b55cso206646217b3.12 for ; Mon, 27 Feb 2023 11:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=O4AQL8i6WYgk4Tqy8aH2abmGlvkaKXw9l82KiDgJYLU=; b=lg7t5OPUZDTBohQJEfbPvGoFG001ogATUdvB53bk5UiQW5WldEO+PEfhF+/xN/fNcM nsszBA9qC1GRh3MwWD9mu8DfDE5fppR308TULY8dMifynxJIjZjTxhxwddyUwvu3Cg1I Yqj7rT2Bsp1mBkrPh4iRpgtFj0RpLXhJh6Wv6MekpZbu9rg6Rt3CqKmvqIhNElD3BNtr bTtBxhnia1OtvgsDNTK388pd03hpCTpabafKEesGduip0rWlVoYR7twwJhExF7lmxwBg EJqWsbar50UJyoH8zUyhu1rb+tFr0gLAT/fIoYsgXw00B6+cVQODi+SZmUgcURM9MKkp Nt4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O4AQL8i6WYgk4Tqy8aH2abmGlvkaKXw9l82KiDgJYLU=; b=By0fCMPkswcwOGUYq+cj4YU1zD7WrCMlTROlXDMN34RVZNL5JyKyxCw5dXfmli5sVp i7nFveo7bQCh0GtDpHYmHqLnPXtVW/JwCb7mBruuMGtjvJqg/Z8CIcHu2t2C3SAxBKvo dVzl8VSYGDsC+syzsWcasL5ovg8CjHGKi/rG5snfigGr9Np+XqFMGnQ77UUwQi21H7Ex EFFKD4/pWfsLKWpWqhY1YETns22werJyk28oBy5le1foBheXBHaodP3UFvSCtDheZvZe IpFEdLi8XEbZDZS8MLzZYynrmIUzUYu/0y309hPCaBRPBQqlVl0OW9Bjy1xwMlbgsOSs dTWA== X-Gm-Message-State: AO0yUKUx7e/hlPbB98ULLFYHYq8gFjgxpAJo//nyUZeuRgmJ3fCVIueZ /fAPel9+OGRBjU9A9XsAzb1aOFlcfOF5PZl+I8ptJQ== X-Google-Smtp-Source: AK7set86i0/5lPLZ/2QOBjjHU2zsxBCTss6LStl3XbSWduyOuC2/0fFBkksQVxbDcf1toTUT5YGwc8/o+Vl+fLjejaU= X-Received: by 2002:a81:b621:0:b0:52e:b7cf:4cd1 with SMTP id u33-20020a81b621000000b0052eb7cf4cd1mr11013161ywh.5.1677527459329; Mon, 27 Feb 2023 11:50:59 -0800 (PST) MIME-Version: 1.0 References: <15cd8816-b474-0535-d854-41982d3bbe5c@quicinc.com> <82406da2-799e-f0b4-bce0-7d47486030d4@quicinc.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 27 Feb 2023 11:50:48 -0800 Message-ID: Subject: Re: [PATCH] psi: reduce min window size to 50ms To: Michal Hocko Cc: Sudarshan Rajagopalan , David Hildenbrand , Johannes Weiner , Mike Rapoport , Oscar Salvador , Anshuman Khandual , mark.rutland@arm.com, will@kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Trilok Soni , Sukadev Bhattiprolu , Srivatsa Vaddagiri , Patrick Daly , johunt@akamai.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7DEAD20004 X-Rspam-User: X-Stat-Signature: jciqhcro8ww9i4y6of71a51t41k8yuae X-HE-Tag: 1677527460-756485 X-HE-Meta: U2FsdGVkX19la04aN39GL7+G2hoGOQyi9LCTwUhvwP/ZdQO02NHR+V04Qz7B2MDB0aM6y8Wf+VFDNPKVped55ijEsPfKdZ0YHBS8DIJhJt85x6q9C1nsPWXNHK8ddSXRybO33BZGxv0C7yyR6QZjLWrf89Tnp0/W6ogVatOhOAO0saLXvEfwLlJyoYjucRvkoG6qbhEPjN7HqXFBLj8dwggFHa61/68nEiwTA5XtonIq924IYHCEkCwUUpL9vTexSVr1PjENQrnoJOHWZVeUfiD4MwmLC59+a/KxMj6TuKDcmK67/V8cObNjyzbGyVRWXQGRSKNE7L/D+McZhHQolYRaoBrznHIq0TX4jk6m9ZMxtcutuMURwdfjGvN4rhhAKDm5iNhamwP0CH/cwU0Z8RKQUrV2eG8NPkh5aPrtrf4PRYSYbVB1E7hzYsUaVskuV5Fo513uvbR/29YN0NapxElm01XH1gO4sBVi6hRneiB66LRF84H36aG1vCoDRk54/gKuwHDU5LXDHTrzz4vwWwvUPR7bX1GGvSj8moElzW/wRfw8B/bw1p5ETiWkQI3fy/L/NNTfpgIvwOAZOO0iaRy+R3m+HNsjCI/4y2qea4GtYq7XC5eeckWzsjDS8/g/3X78NYtnblw9ZGuvJfsKaiZ63gFyhvLoRTU0bu3T9latE3YMztG1uvWIg354tpd+K/jrLXVhSEyEGa2QVaEl8WKU6Zzxg6m1QCwrPIZxVbwSSG8OO1NhP/BwZzBhO0rnc//2UVWaL7dmLkIPhZAjBqZB/GvDDu9lA/i+358GpS0lsygnvRVNk2Y+CnMvobeN1jD3BcPCMQnILoGPkkwNm7S+4DEj8gUwntpajKKeSU7FlmzErbcLg0je9P5wF3nzmqpp7/nv1BdGHYPm+ZENsTE8qSoZMwRn7ziW8/lZ/0yDq30f20VyazocIQjD+zgFfDFXZ/yYJN6vtWIDHq0 N+q+FysK d3iY4vMGcj3kqXSZA38lLqKKsztAZTTL1VT7J+B1Ju1w4TwVLd7C0WUhhpw3zr3E3KAy7QedCKHp72DSHjIWtCr2B7/HfLhWpIwsrrE9Rpq2R1ae05U0w4ukk6/8VwI3SFcw3/S5vdzmaZRXVvP/vgIxQT5o3QywGDX2iBtb9+JVg8Ub8PsuqwjK/uczEfThxVtFJDtSuq1YxCZuYynMYqhp7BhiwULSH/04A4fRXKMeQyikpWbCYbF7RjF0xLouyJ+Jrt+pfdTEUNW7leL2mV78+nipHBR/xusfxBSK88Tnbrc8MpOozoyeiAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 27, 2023 at 11:11 AM Michal Hocko wrote: > > On Mon 27-02-23 09:49:59, Suren Baghdasaryan wrote: > > On Mon, Feb 27, 2023 at 5:34 AM Michal Hocko wrote: > > > > > > On Fri 24-02-23 13:07:57, Suren Baghdasaryan wrote: > > > > On Fri, Feb 24, 2023 at 4:47 AM Michal Hocko wrote: > [...] > > > > > Btw. it seems that there is is only a limit on a single trigger per fd > > > > > but no limits per user so it doesn't sound too hard to end up with too > > > > > much polling even with a larger timeouts. To me it seems like we need to > > > > > contain the polling thread to be bound by the cpu controller. > > > > > > > > Hmm. We have one "psimon" thread per cgroup (+1 system-level one) and > > > > poll_min_period for each thread is chosen as the min() of polling > > > > periods between triggers created in that group. So, a bad trigger that > > > > causes overly aggressive polling and polling thread being throttled, > > > > might affect other triggers in that cgroup. > > > > > > Yes, and why that would be a problem? > > > > If unprivileged processes are allowed to add new triggers then a > > malicious process can add a bad trigger and affect other legit > > processes. That sounds like a problem to me. > > Hmm, I am not sure we are on the same page. My argument was that the > monitoring kernel thread should be bound by the same cpu controller so > even if it was excessive it would be bound to the cgroup constrains. Right. But if cgroup constraints are violated then the psimon thread's activity will be impacted by throttling. In such cases won't that affect other "good" triggers served by that thread even if they are using higher polling periods? > > -- > Michal Hocko > SUSE Labs