From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBCFEB64D9 for ; Fri, 7 Jul 2023 02:23:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A89DF8D0002; Thu, 6 Jul 2023 22:23:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6AFD8D0001; Thu, 6 Jul 2023 22:23:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 901E08D0002; Thu, 6 Jul 2023 22:23:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8154A8D0001 for ; Thu, 6 Jul 2023 22:23:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4AAB5806C3 for ; Fri, 7 Jul 2023 02:23:44 +0000 (UTC) X-FDA: 80983219968.05.F6F9F6E Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 871B840004 for ; Fri, 7 Jul 2023 02:23:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=hnFOqdek; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688696622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e3jZGHpcePaJ2Z2WYRjOa6I7EC9MpiFV+a+zLSzW4Do=; b=UqqB/MCZDJ1nOdKfEDBP2k3rNLcRgfxG+/MDmPqwSb8qw9vbjtQHlzjUiamPXdHYi6qwMf k8Sg+42m0rl7RCTLPaEvNykhIKEe3BqwaU2CFGDmTrr0cq+Bf0RR/r7OxaL7rcCxfNKNrD LZ6kqTa/PxLQFu0BXYBcAxIqCkHYxD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688696622; a=rsa-sha256; cv=none; b=pnW7hlFXBjxSuQgBlA3hOsziQdO3w8WLpKUyE8Kopeq9+fugJvRWOtxk/y+8vxUeuiyvK6 wLjx4TqwDrUWmm6blcLUuSDsuv/wuXlNx7Ev6mGNkqwb4HSDohERiZALmT4i0YtRLnEQN5 mZkmPTccYOfLsnbhZXK9ZctIgf9HLpg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=hnFOqdek; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-c5079a9f1c8so1504263276.0 for ; Thu, 06 Jul 2023 19:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688696621; x=1691288621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e3jZGHpcePaJ2Z2WYRjOa6I7EC9MpiFV+a+zLSzW4Do=; b=hnFOqdekyUx3sdGAJGRdVYgrAQMHDiCQ8szOAmPxK+9tdCPDrvGVCdwR3kvHU+torE jhGq67JhurLRvRSVJOa1TU4p5qCgYKhCSwO58om9y6NDFzCXTTQn0tCS3imwBbST/lzt RdsonalRjM27UXu8Reke1cI3HJthfvHF2Afu11jLIwkIcTo9kN05IM4bMRAIj39QHCaK kV7Ih5vmEHvuLrAA5eRP8WvvTMuQLZTlKPWcclnJBjcd86pLyh2hwgaBgSsFJ+Y9fOVp hHh5zZ9979fqiw/0Q2QLJyKanfc/Fe3WC6hFRAHhErafQb5f3xhW66xrg/VVqyWmKVp6 6+kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688696621; x=1691288621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e3jZGHpcePaJ2Z2WYRjOa6I7EC9MpiFV+a+zLSzW4Do=; b=fV4+EbGwIxqtjGdy7UfqZtyM4I2GvmuuGWnRuSwnEkgEd4a23vSE7QZouMkFkS4RcE rqgp1VVWm2k3WNJ0gpxgrk1G7vfB79iI+eJBnzrT4xtfimN+0UD1qCb1w4Ky4im/givq L6CKm4GqkO64aurNygPMq0gm50yDkE7u4sFAt+a/iqHjkJEHkJ4LPgrJwyGBPR4tCUcG kosaHkJUhz6G+KWZYTt7VSQNXujd01cCQq+pABmz159oeXTomejpVQoh/bqWySGlVv1m L+gUuVBZ4L9zfLwnTRk4/LDrXgFfC+FV0lIxLcXGWfwxPx3idE9HmVfs/sYwmmltd8hn KnHQ== X-Gm-Message-State: ABy/qLblUBQh2v4fNhfE1mg870uT4Qx5XfAi2jDJJqvter6e44h1v181 i5KVJCbD7oC2fm0SWGabOpG8tjue9ITpB5T8WD43jw== X-Google-Smtp-Source: APBJJlG7fyYTzazQGmkxbA3JKrAtX2uHRm6Es/SVtj0m0F+UqGq/IxydEdGWL2iBvlPuXIJprcmJCXdht2Bo6PoS7rk= X-Received: by 2002:a5b:f4f:0:b0:c5f:b74b:e1e7 with SMTP id y15-20020a5b0f4f000000b00c5fb74be1e7mr2597797ybr.27.1688696621413; Thu, 06 Jul 2023 19:23:41 -0700 (PDT) MIME-Version: 1.0 References: <20230227173632.3292573-1-surenb@google.com> <20230227173632.3292573-30-surenb@google.com> <9a8d788c-b8ba-1b8a-fd79-0e25b1b60bed@kernel.org> <2f150512-e460-a9ae-65db-39dc54fe99d6@kernel.org> <04e701fc-2fd8-c4db-73d9-c86d4103641b@applied-asynchrony.com> <63dfddae-732c-5efe-648b-6ea622f2e64d@applied-asynchrony.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 6 Jul 2023 19:23:29 -0700 Message-ID: Subject: Re: [PATCH v4 29/33] x86/mm: try VMA lock-based page fault handling first To: =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= Cc: Jiri Slaby , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 871B840004 X-Rspam-User: X-Stat-Signature: gh9rwstq7yoi4w5bkxg57ay1u95wiwej X-Rspamd-Server: rspam03 X-HE-Tag: 1688696622-4732 X-HE-Meta: U2FsdGVkX18uoHGN3kb3VLysCwUEbAQWdxmOowjFUWd894RPVMnYxreCzR0KfvaqXrXAtMtKNIPlxfJNq19lY829gMFtxqdFzgWBzax6XKvXxfIl5836ByMG4pzFD8dmAZrF0qRDg5zNiGZ1xmSRFAqT+2Z6rUVvzhKtx7ctXcV/yqj7nb4SItNsnpq1cv2k2ynSGxms2AwFJvjuDp31+ZJwYGfLsQ+YazH67X1fqVBGRkNb9yQzQ4ulU+4Nut7qRrFAY8g93WfnojIVuBokCvulavkfj0mCJA8XWah3i7TBwtdW3uZDOi/HG7GtlOMMFlH7+A7xjPnxR58X7DwJpGlOgvzSkTrbQf0hJuA2H3iSSILbXiwhB7Mw8AEXmfVpQjrvfxscnWIRj8Wu5wsE2o2AwB0gzWyfoQmg0X6gGuFpS+qMvX/WWl7Zi4L9g4o3ePntq9Uxm/0HxV/Y3RNXAgNoTGq/iFbMq8nWYUwVMkAYYDSFNcmfBKBUGO/+gN5Cnjb6VG9h305CuY8drbsRukgOJAPfwYq6DgQAKq6l8OezDAjad/JTh+nO2H+d6gridMFZgPuEZXTTRyvQGQ8zTFDlrbO6KEAuBJ4ZYcJUaOOo2jVYsMyyEDPzzVdHNZ/Yhz18WTU7f1ICo5u9ThAS8Wamc5qUAhdLGidAjy1SJ+y7diTRndou7zwH6l6j7lGqIgfMeSh9KVfWG+s0DfYX55U/8TZzeeJSvMg6JLCl4tG7wQ8gs9d9EW+m3HsnkRjY0R5zasPnEdqIU6tskmx3a/u5vnOyeBaMYsAEfaulAr+R/lnqcelO+cuHwF5Id/pi77zN5eOLH/CGfN3Lzr5dCZL4GLIvayGKNVT2Lgs16+YF163F6Oe47W+LXlzMmtG4rhxwYMfJLI3ecXJmnnKGxC/PqCnkid7QwIZb0E2qEIf/VNTCrr4mFTky5Bd/frIlZWRsxg10XBzSji3chif YHYlOvyZ O6yeUSJuN23jCTAttMxl8Q+6Se3t4ed5x6l/VGih2fQCPsgLqvlKx3dg2cFllBgGRkNcVHNKXDOL/zQn5ixa6212et7DC78RI2D/BIv0ek0aR4fq2eYQwDv8oJ8imucKC5smXd4VaZglyAFqkxZbfB4Xu3IaDnuLT/NZaZOGIyDUqCZpD9iAMgSN/UB13szXz28NSkwYZELGt9dAqRsW2Y82v9lKwKw9KK7DbPFae673EBoGNYulOHMF2L8JDxhl88gqYmR73Zjh3oNl3YU/gYt1E/dIPlCQcBddUdIuauhz7LVaHmJzriTSp/6VPWnM1GhtEZ6G1tk5o6WQGlVZ5KagAJfh+h4/PWtk3uoAMzYZjKa93BrdGuZ5a2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 6, 2023 at 9:11=E2=80=AFAM Suren Baghdasaryan wrote: > > On Thu, Jul 6, 2023 at 7:27=E2=80=AFAM Holger Hoffst=C3=A4tte > wrote: > > > > On 2023-07-06 00:55, Suren Baghdasaryan wrote: > > > On Wed, Jul 5, 2023 at 3:37=E2=80=AFPM Holger Hoffst=C3=A4tte > > > wrote: > > >>> Jiri, Holger, would you be able to try > > >>> https://lore.kernel.org/all/20230705171213.2843068-2-surenb@google.= com/ > > >>> and see if your issues still exist? > > >> > > >> Just in time! Not 2 minutes ago I finished rebuilding 6.4.2 + the la= st version of > > >> your patches on a second machine (old Intel Sandy Bridge workstation= ) to be my > > >> crash test dummy. I removed the BROKEN dependency in mm/Kconfig, man= ually set > > >> PER_VMA_LOCK=3Dy and ... it seems to work?! Boots fine, Firefox seem= s to work > > >> (but no exhaustive tests yet). I will also rerun a few reboot laps, = just to > > >> exercise this a bit harder and see if something comes up. > > >> > > >> Tomorrow I'll also try again on my Zen2 Thinkpad and will report bac= k. > > >> > > >> Fingers crossed! > > > > > > Thanks! This is promising. > > > > Indeed it was, and still is. :) > > > > This morning I wrangled 6.4.2 + v4 of the patches into all my machines, > > enabled PER_VMA_LOCK=3Dy, removed BROKEN and so far everything has been= humming > > along just fine. One machine has been compiling for several hours witho= ut issue. > > My Zen2 thinkpad - which was previously really unhappy with enabled PER= _VMA_LOCK - > > has booted a few times without hiccup, and Firefox has been happily roa= ming the > > interwebs for several hours as well. \o/ > > This is great! Thanks so much for verifying! > Andrew, if it's not too late, maybe we can drop the BROKEN dependency > now that we have this confirmation? Liam pointed me to another possible issue with per-VMA locks due to the recent changes in stack expansion locking rules. So, it's probably safer to keep it marked BROKEN. I'll post a simple fix for that shortly. > > > > > cheers > > Holger