From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20425C4829E for ; Tue, 13 Feb 2024 00:34:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADEE76B0089; Mon, 12 Feb 2024 19:34:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8EE66B0092; Mon, 12 Feb 2024 19:34:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97DBB6B0093; Mon, 12 Feb 2024 19:34:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8B2E76B0089 for ; Mon, 12 Feb 2024 19:34:58 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 55910140638 for ; Tue, 13 Feb 2024 00:34:58 +0000 (UTC) X-FDA: 81784910676.14.B469BA3 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf11.hostedemail.com (Postfix) with ESMTP id 9950C4000F for ; Tue, 13 Feb 2024 00:34:56 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xtF9LZgr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707784496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UHD/3jMRU1ccG3YkQIqWf6JR5thVdXFBz5XlT+Q0DtQ=; b=YdmEpDWDbvp9ICOn0dVtj5OqKEwaqQ1D/eYuVfd17obGC8PcRZH4WzS+ZKSQM7hVFu6dMa b2DkZmOvcyiUDMjTFSUOSTvUmDB3efjuDjLGuOrnZ9Liwb6DN7X4BIo1ypZvqPwoLzM4rY U4kBfWZF4NfRYAXQuw+kh9H9OD2gA6Y= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xtF9LZgr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707784496; a=rsa-sha256; cv=none; b=G0p0iadzpk3lks7Ko/O9WA9jDnspGN06ynBymT7I4DQaaTee8KJVVP7YSs2Rg8hq4VwnF1 LxWI97FgKuqGAVKlPcnZ9oxzRwedS/qv+I0y8jrO4+xnUB/6MCg/wrXQyjyil77z9k9FE9 qJWFZN50oJnO9/k4JKGHGsF7viB4tCs= Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-dcc80d6004bso116890276.0 for ; Mon, 12 Feb 2024 16:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707784496; x=1708389296; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UHD/3jMRU1ccG3YkQIqWf6JR5thVdXFBz5XlT+Q0DtQ=; b=xtF9LZgrb0wWRI6D5+gXjMzrzgwHqEqJGFj6/3Xv6FhiUXzpoWcrmaVTTwvRoM9fjC VkIAJ8guqb+vDGniz5H8GHiRb6+7PC/808jVepVRp2uShTnMwHAaX9dB8sxaceU0y+UN lI5DFnYFg1aJg+at6ABMwLkpw4zbuwJTjqa08mzz/rAZYC3IsmEKVhzc8UDysQ3xq0SC wBRfgtHa3ldti50TnXeDbzclWiU0tAAiqlRMpFZigFOtEmaEyaSe0IW/L/AEB0C5SmBi ZFPmA6DjyN7JJFGQyyJuUPnJ5VP7D3jj/IDei0c+zO304qFtwESebmKRysvOLwLOWB+m xIrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707784496; x=1708389296; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UHD/3jMRU1ccG3YkQIqWf6JR5thVdXFBz5XlT+Q0DtQ=; b=bNxsf+/C2BsyfVT03CVcohYFDXfmlxxgCBHTa6s/oU/sJPCicq5BQ1vy2JpglRxS5O fzxMffUAl/kb0GbeWmxtnH0rpsMDVC7OUMgkLR+fpSzabXwoFYcAcV5638VfD8MZzv8n 5b8UV2S2d4psOPUbCYbGURgEKSgohjrPY1b/wUOzFsKLThes3kfb/Pzp86Ua3JD2vkSa 6RCHyP+ilY8VPxafCiEecnJTYNEgudaXh8ImMSSqO47/dwioVZ+lN+T9kvVI3eicZfCe /9kqJ/A/zWdBRrS52aVghu/vl06d7jffwlHbEiEGvb87cxtaCQcmWeNMyqiWpMiw8X/l KfOw== X-Forwarded-Encrypted: i=1; AJvYcCW7TIkiLE8k+QgmKcXL5lThEclAYzdMyjREKCvICYf1isSFVVCBlZV36nFNWaW7xF9+Gtqy/NKg1Wt9uN2be/I/PP4= X-Gm-Message-State: AOJu0YyY2ZKvzBfHC3UfYwwnwU1GZFdhUrCVdSPrWCiMaq2p9M/rqqKa MDWm/9vh+kaC+4qpTwjmhspX93ELg1ooYLPetGtJkKdKS0sW8q1iTSyOeiml+6vobLv1ikbXjYd TaArE6X+5uJTpjTnORTEfu2C6wlTq/xjEMfWb X-Google-Smtp-Source: AGHT+IFjB55gPzAJ3uayg/3DbZropi86YtyNQzi/ARRSHghfRy48VLa7tw6T2sjep0csYIBMYiEo+U9Z3yu21UMYcUw= X-Received: by 2002:a25:b389:0:b0:dcb:ca7e:7e6f with SMTP id m9-20020a25b389000000b00dcbca7e7e6fmr1832315ybj.55.1707784495521; Mon, 12 Feb 2024 16:34:55 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> <202402121631.5954CFB@keescook> In-Reply-To: <202402121631.5954CFB@keescook> From: Suren Baghdasaryan Date: Mon, 12 Feb 2024 16:34:44 -0800 Message-ID: Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Kees Cook Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9950C4000F X-Stat-Signature: mrdkj3mzx6k46dtgf7rb5kaxczr6p6u7 X-HE-Tag: 1707784496-660710 X-HE-Meta: U2FsdGVkX19HS2LJXDpyqxTjthFj2cT+/B3N3yn4HhssY7uqvQOIU0U/yaRj26QJTNNNvIWrkLn8KDQd1QKgmKEqMEGlTXLIW3I9I64dwK9XWCQNzJByhO7Cqhg0wwG7KMu53E7p1zMPoJUMU+Okm2jkFSiOU61y4fDMearu7A6GeFF6dEhJ02Y2MXLf0l3MZZNrSFN5R1KKspjYeAtSzPyxB5G/L0kmMoVZzC7d0gcMtnEjCabSdwypfDqIpOR8e1IlC/rYzRGRQq1vLL7rSXiFHaw8kvASA6WOX7lg8SXbDzS4bJoYWnuxC9KhlS5TAF+SUJ4Fkm+sc1Re5Skz785AHPv2U5qJ3C8e2Z1pv9Gsmc07Hp5xWkyNhKy3IR1VshQmBlYTghUuFjhZECg8DSb8CXhnSspuZcx6jS63lWKxSSs6UwYk5eEH01NBfk0FLUPRePO2w7o1YLZYL3kBSlP7pZ1haK84RwIfYmn7WTNvlz8nv/ofdIuNhYvsyhBz6JJQsp56IGnjPrqCQKt33AfdS5+3PCXaO3LKRHx6Nqws+pI0odS1Xks4/nhUxoALyySrc0nKAKy8WZt+49DMbBSD8Gu0dWMG1TR5vjTFwrg8mazf8Ks/DmQ7IA6q5iKxUaa7wXoVokUHinrC8BfRS2Y2JpMK3zuvgT/X55AJOhNOfY/TfrCv0PQPyP78o2gj5h3kOsN0Uecbj4DCHobpVnQ3+55VQi9yWcXnbE7GXzPkGUt+gameV9+60iTl0ZZTxUhgEqJfIGKIkD4++GcYv1oJg5K94sw2lpPMz8zJUp03c3QSI1UZLuNekv9Iq8drml0kcNAP5kjY39UNHBIamAxQSv6M4Y7OQRaxe+pzu39TAZI4ze1jqcwcup1UEHQk749WQlB1XnZ6xXAMWigw73GZnrPorKXJrVZ/qIcgFt+ZvtKz07rAc9yge9xV8cF8tG1tLsmt9Ew23yDhv2L 96rK3Ff9 4E4U+CPytf7eTQR5Fiwt9VGqR7xz7GS978wb+SPWEn6HBSvFbVa8ua2CPLLoxgw8SyLB4wu17PO6zOgP4IIW6a8gaks0Ii7IwNRnj1gt87Cdi2YA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 4:31=E2=80=AFPM Kees Cook w= rote: > > On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > It seems we need to be more forceful with the compiler on this one. > > Sure, but why? IIRC Kent saw a case when it was not inlined for some reason... Kent, do you recall this? > > > > > Signed-off-by: Kent Overstreet > > Reviewed-by: Kees Cook > > -- > Kees Cook