From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A168C433F5 for ; Tue, 26 Apr 2022 17:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B0EB6B0073; Tue, 26 Apr 2022 13:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75F906B0074; Tue, 26 Apr 2022 13:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FF856B0075; Tue, 26 Apr 2022 13:14:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 4CFB36B0073 for ; Tue, 26 Apr 2022 13:14:07 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 2405080568 for ; Tue, 26 Apr 2022 17:14:07 +0000 (UTC) X-FDA: 79399678134.16.59ED1B0 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by imf26.hostedemail.com (Postfix) with ESMTP id AF5E8140039 for ; Tue, 26 Apr 2022 17:14:04 +0000 (UTC) Received: from mail-yb1-f176.google.com ([209.85.219.176]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MjxW4-1o7gxw2D28-00kRSZ for ; Tue, 26 Apr 2022 19:14:04 +0200 Received: by mail-yb1-f176.google.com with SMTP id j2so34232946ybu.0 for ; Tue, 26 Apr 2022 10:14:04 -0700 (PDT) X-Gm-Message-State: AOAM5315zqbV+eMbrLbReZsTVO5LhkR7W76LAoKITQH5A2GDoUYV8eRH eDg0NgI5uXcYgg9ZXIv+6/BLio2/IKs+9NCrw1o= X-Google-Smtp-Source: ABdhPJy4qrzId24VdonwrFL8xdmT+OefZW9RIA7s/JBFmqDtK6o+FbcHdop/B8RF2jVsl9Z7YvDRgbjOS6bpOD7eSC0= X-Received: by 2002:a25:d3c2:0:b0:645:74df:f43d with SMTP id e185-20020a25d3c2000000b0064574dff43dmr21550935ybf.394.1650993243035; Tue, 26 Apr 2022 10:14:03 -0700 (PDT) MIME-Version: 1.0 References: <20220422212945.2227722-1-axelrasmussen@google.com> <20220422212945.2227722-3-axelrasmussen@google.com> <20220425203249.GA5814@altlinux.org> In-Reply-To: From: Arnd Bergmann Date: Tue, 26 Apr 2022 19:13:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/6] userfaultfd: add /dev/userfaultfd for fine grained access control To: Axel Rasmussen Cc: "Dmitry V. Levin" , Alexander Viro , Andrew Morton , Charan Teja Reddy , Dave Hansen , Gleb Fotengauer-Malinovskiy , Hugh Dickins , Jan Kara , Jonathan Corbet , Mel Gorman , Mike Kravetz , Mike Rapoport , Nadav Amit , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , zhangyi , Linux API , "open list:DOCUMENTATION" , Linux FS-devel Mailing List , LKML , Linux MM , Linuxkselftest Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:jh3hs0GE+G9Wk7sjb/URAbpbSfwDnPe53ec77LjMmdFXOva0NZ4 sKi/pqmSJ+wB37ttRb5SfIL/7wGKXvgCrXy+G2oBzpjwoC0xREPtfDMEBuYkIiDT2AXSRzO M1jQoK5Zm6GD/nFH0xpOJK48dY4fHeHMCxVsN2ttJuDopKEQ+fEj4Ms7DePhNTr1R/FI2Ip gWW4sUn64+QVSz4ei+Gpw== X-UI-Out-Filterresults: notjunk:1;V03:K0:LYCjrpE5V4g=:bneRNLs7oWghR2K4+H6gIa Exuq6fJjCjhXa1cGRw+BocOXT/Zv3UGnyKIndwRFYyZylV1e888EKqyyu65sVo9kEhXTa8dvN gDpj6NH5cXyVK32QyJWN2W1pL4lUwxIamoaVRlzeQG7d20lLBfNYnUubvPOth2QDhCyubgqrR Fk7IJrj5MW5iDywO5wuhebA7xTlLILZ9Sa3dQVMgb40Pao0Y4uWRsKCX8FCtnll5DpHYJ0fx7 w1pcnWFBwnl1+USy2UzT1ehuhdcBdxFlvg57b8k8WByNrbzWRXF2+eSq0eETSU2OZuCWzDORF 6DFkgjDnujIVGzDCXffFtFnnLGnfEAEPKnudk+1Vw1H7IOWaNoeM/Nec6TamBm3u6DyRtcVn7 b0PiOHuqM36dIh4QwnNSp96Z7XI4mbtIYKXMdGEXWhkYm58Zl9v+FDy8Kual84zYyf+eiVOZv 9rCuvLisxNm3iUeZ0m9nU/uFuMsJyaXjM5jKxitJJn7atkNdtWJNH9TdSbULUnWDITlw8TM3T d8na/3sqitEyduab5U8o77oT/L2zHuOTOz6j5VOHEPzHrfVtXqkuKUDpv3hJSKDphhgx3q70q k0S1ReI2H6pXYxwc+Vi3CZfLoYOPg4kzmNOTSFQy9nU9+a51Qm+dYYbIEEm7lS29PQe3Qv7uC pWZaOS6SUpUE5wnU6tXXsVNKABDkSp60pXE/Ndg9cQnIOXkS8gqoJSkvaQXm991rbpVnrBZDs YW+vCYwRklDIkyk0KNnuSu1LIBvC7Hw9lj+lQ2evJjqODY8MhMd/3RSLgOBSGTXN3JFZ6HyGy WtokiXgeXRu0jiYT/9lT+VN/KtYtdr/cbHZ9RVGpXVbY5VVxsw= X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AF5E8140039 X-Stat-Signature: yox5cj7d33tiq7obbfcbe4q6zpdxzxum Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=none (imf26.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.134) smtp.mailfrom=arnd@arndb.de X-HE-Tag: 1650993244-163480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 6:00 PM Axel Rasmussen wrote: > > You're right, [1] says _IO is appropriate for ioctls which only take > an integer argument. I'll send a v3 with this fix, although I might > wait a bit for any other review comments before doing so. Thanks for > taking a look! If there are no other command codes, you could also set .compat_ioctl to the same function pointer as .unlocked_ioctl, the compat_ptr_ioctl conversion is only needed when there are commands that take a pointer. Armd