From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D42C433F5 for ; Tue, 3 May 2022 07:22:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 784656B0071; Tue, 3 May 2022 03:22:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7318C6B0073; Tue, 3 May 2022 03:22:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 603176B0074; Tue, 3 May 2022 03:22:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 503186B0071 for ; Tue, 3 May 2022 03:22:09 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2DF4B2B949 for ; Tue, 3 May 2022 07:22:09 +0000 (UTC) X-FDA: 79423587978.21.1AF3F58 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by imf27.hostedemail.com (Postfix) with ESMTP id B37BE4006D for ; Tue, 3 May 2022 07:22:06 +0000 (UTC) Received: from mail-yw1-f174.google.com ([209.85.128.174]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MqK2d-1o8UhB3PQR-00nUgR for ; Tue, 03 May 2022 09:22:07 +0200 Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-2ef5380669cso170818747b3.9 for ; Tue, 03 May 2022 00:22:06 -0700 (PDT) X-Gm-Message-State: AOAM531Zm/zfbdPqnvLuMOtv5547ABVdd2OqOgRVBs99NXuLbuRYayj1 VrvbLgmydBYG9Noy9vZCgnyB2hlXrsTUyVhUaV8= X-Google-Smtp-Source: ABdhPJwPr9q0sZe+e8UxYUbigcUnaa5Xa3a0oSwktBFYt4HYrPBnPD483wlKn2ZH53xnNpxMcJ15XBtdVqESN+RJUXQ= X-Received: by 2002:a81:9213:0:b0:2f6:eaae:d22f with SMTP id j19-20020a819213000000b002f6eaaed22fmr14551172ywg.249.1651562525321; Tue, 03 May 2022 00:22:05 -0700 (PDT) MIME-Version: 1.0 References: <202205031017.4TwMan3l-lkp@intel.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 3 May 2022 09:21:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings To: kernel test robot Cc: Arnd Bergmann , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Q5gZeqRk3BhgKWF3Vw8D8BZO4i9Ad6CuXx1Qw/yaekGNbSHnQ35 88RtQzei/Sy1qY4Tl4uOTknMpobqussSXyCZ0bKCpc2LSsrmXlMHAA/a1o+yMhzDU+PZwVH /WrFf7bGPenCWeuhV7Yp3BProxcLkZMfS+p4+SmAmp/lpztAVDtqvdXlCAVgPizreqGgDzM MYJX4N1cpdr/wuYcj0ccg== X-UI-Out-Filterresults: notjunk:1;V03:K0:SO7kBJM5vSo=:OMyjZJEIX4h8VNf1TG5MSE O5fj4gJuw8We970cYtfluVV7/7FgwEeqAxxc1fa5A/4ByA65aGnKexAHPnfnzAcLdguc0IB8z KPaTxUZqgiWIz2/yPw4Wuk3xWz8tPzVDlSXLk6/RzgWgy4K2QYb01/F19h9vEHVkMG5W1yZS9 0/cjWmZfB9WrwxhDDj16RgRF5Q9ycfA7c6hD6x0gDV+zrFAL3vKDw96czejHMgAzff6P00Qur 7rPKBO4YuUozaGnMXZkZ8LrHgKNdwcKfHI96iowN0l/qHS3KnoiOXBe6rI0qOsHZVslRRBZzG rbaxLA85BVEuZgJFeFgsobHIKgOZc2vGC5Fl22ovLY6qikhpapdlsHiHgm+VaBLsKmflXQKYU MVNc/rddxYQEHOCfy7nrqzvJt4IqK4Ps67yCSdWNHbU14Q4QJUY15qBcYy0Wfu0jnukpPL4TD VB9Iads299k7qpIq9WJc9HU4sg0c/yG+93weVBfylyC7JohjQUe3lds+dhmRNWyoVgvEThQ47 /Hshqf3EuD2RnGr+q6WUkBScgXeSRKPRY5BrJGaEKZtXP3cQhqM0JbcMpeo9TH1p825xHX5Ss ydqbI64JGMvqHQ3ER6LCTYQJhinEWi0NQtk6bg+aTZyX023rRmsiApsVTyDVeo8PZomLeHQgL 7NPhteLZco5oqcA0Q6ljHCgJvyvAR4FlecBPkFh6FkPpZAD/0E8BsQCsyQhB/dloG/IIuMNPI 7xUOSruxKbn25Upeg27FpUVbPXqQiAUAyG0/SWfce6jOxBm1U7y6ZXL84cuMhcJLPabvRLmyb +0DaHmpAQBFMoNwvX4Pxyn7bXpd7CHG7pOux4GHV+q3S+wcV60= X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B37BE4006D X-Stat-Signature: d7wcj8dmjjizzhcco4s9zwd687tor9z7 Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.187) smtp.mailfrom=arnd@arndb.de X-HE-Tag: 1651562526-944474 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > From: kernel test robot > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Reported-by: kernel test robot > Signed-off-by: kernel test robot I checked the patch, and unfortunately it is wrong, the current code needs to stay. The problem is the SET_DMA_ERRATA() macro that accesses the local 'errata' variable. Arnd