From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64983C433ED for ; Tue, 18 May 2021 07:48:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04E0861353 for ; Tue, 18 May 2021 07:48:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04E0861353 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7BD8A6B00AE; Tue, 18 May 2021 03:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 793806B00AF; Tue, 18 May 2021 03:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65B098E000C; Tue, 18 May 2021 03:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 32E386B00AE for ; Tue, 18 May 2021 03:48:41 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ACB1E8784 for ; Tue, 18 May 2021 07:48:40 +0000 (UTC) X-FDA: 78153574800.35.B4A8496 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP id C06EA40002CB for ; Tue, 18 May 2021 07:48:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E99C61350 for ; Tue, 18 May 2021 07:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621324119; bh=ZvGkPYlYj2nqGmESCnOClTJykmU52wuUqDlRt38OfA0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DxfI8vWupsEgScwwsgAAWaxLJODkg+jRKN42nvXRZIK7KuL5kQQLP99tuTwCTBXnS uafZ90muV++LA/p87BnSyCSSaSthDNw8iBlfyRmq3XSQhoQPVu2hIXJIJ4bLVwGCNQ S6g5yQPH9vfxZAL3h5odLDBQ/uENnw/EUrtB8sOw+AsUfN0dwdy8Z9p0/fu00Or1YG HSfkXCgy+lvz5mtA05ZmHPfItVnnUAt6A9a1FiPhBIeOkuAuxW0MXsfBgkAd2C5L6J uVWbchBFvSPmyqEWTUmAMeA5EeJ7XTJN9VrrFIhLkPltUvZRkWLmk2Jq9qQqWHsU8C 5eJ6eIHy6orkA== Received: by mail-wm1-f48.google.com with SMTP id h3-20020a05600c3503b0290176f13c7715so905713wmq.5 for ; Tue, 18 May 2021 00:48:39 -0700 (PDT) X-Gm-Message-State: AOAM532knO4ZZya4V5zUqzDwXh4BZG1RFC/BAv3qM8xsBVLDtWbPdCvx /6u94OG5dqsutbbDc6intFcyZSg8Ss0Esq9OCvU= X-Google-Smtp-Source: ABdhPJz4k8XxX24/Dox9+GySTr8wlMSmxqo+SuzqOQF2aXlWbf96HeHqVkq/eJMb4rVErJpv4OfcoAmTm6cuSeTNHgA= X-Received: by 2002:a7b:c849:: with SMTP id c9mr3442580wml.84.1621324118063; Tue, 18 May 2021 00:48:38 -0700 (PDT) MIME-Version: 1.0 References: <20210517203343.3941777-1-arnd@kernel.org> <20210517203343.3941777-2-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Tue, 18 May 2021 09:47:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/4] kexec: simplify compat_sys_kexec_load To: Christoph Hellwig Cc: linux-arch , Alexander Viro , Andrew Morton , Borislav Petkov , Brian Gerst , Eric Biederman , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Linux ARM , Linux Kernel Mailing List , Linux-MM , kexec@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C06EA40002CB Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DxfI8vWu; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of arnd@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=arnd@kernel.org X-Rspamd-Server: rspam03 X-Stat-Signature: 73czmk7hjyoix47nw1zdxhxcz5dfwwuo X-HE-Tag: 1621324118-937852 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 8:38 AM Christoph Hellwig wrote: > > > + if (in_compat_syscall()) > > + return copy_user_compat_segment_list(image, nr_segments, segments); > > Annoying overly lone line here. Oops, I was sure I had fixed all of these when you pointed this out before. I probably rebased a slightly older branch that did not have the fixes. > Otherwise: > > Reviewed-by: Christoph Hellwig Thanks, Arnd