From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61CDC31D97 for ; Wed, 3 Jul 2024 23:22:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E606B0089; Wed, 3 Jul 2024 19:22:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CD486B008A; Wed, 3 Jul 2024 19:22:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2952E6B008C; Wed, 3 Jul 2024 19:22:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0AEBB6B0089 for ; Wed, 3 Jul 2024 19:22:46 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 88293160EDE for ; Wed, 3 Jul 2024 23:22:45 +0000 (UTC) X-FDA: 82300018290.25.56C2355 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf29.hostedemail.com (Postfix) with ESMTP id B45BA120010 for ; Wed, 3 Jul 2024 23:22:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V4oKycrX; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720048939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c/Wm/ZqWSe9+vVjjHuOE+3B7vmuCMEHlN8ZTqW1NnMo=; b=yn6W1H6z3eFnDJbyH5C4zd2mrtAa5XwO9T1WbAXWP3qggsnzAN5Evb2/rJmhrVw/dsiqqu vG62d6jkbDW7/BvKeuRTxL9OPgYlTM/HhDxNEYd10LRFS1XsNB1DSu5tuUc+vDFqJvCkhy dU3idoWE7dhK4gvRjhuTr96LFP8sM3s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720048939; a=rsa-sha256; cv=none; b=tFJtY83RFCzUau80936iYuOJYlBm5Lf3AtSWbFsSnEYds+3cA7st00bsCrJr1/hA1FDyJ9 6Ws4iUHtsjdyqC2KSwGbyiYasjPp5MkAim3VF9Adt8i5J4Z3C0TzTq97qraHwraPZ6+Bv0 xYM33dytsMkRLm2RGugeRyr94BQk+rA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V4oKycrX; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6b5ecafbf88so107466d6.3 for ; Wed, 03 Jul 2024 16:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720048962; x=1720653762; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c/Wm/ZqWSe9+vVjjHuOE+3B7vmuCMEHlN8ZTqW1NnMo=; b=V4oKycrX6lCKzGHOa26iju0Y9GfeamPDm9izx/YI8FZSPKmn3pD67oF06Aq9yCzKnR xMrs1b4oe2j32k3nPp4dlFfyTz9JdI/CJhkKLCbiyOMoz1izVgMQ6pm+HlG97/7C1ar9 uGA4q20mJwjeyZnRDuxfpQ3yBwYUX6I1QvDH9up1cigwGuKejpThL3cmiBMZRlz5/oJ3 xsVJPQ60freo9KFJoDMHWruSt2OrvTin3W0ED+QrqIBD+ibgaZ0RYcxNfsRG5NavWp0k LS6SeJAJ2TYQAUA/pTiW3iv9JgSFZmyiHF9fsFiwoquJTLZJ2Pp5s2r0ET61D8yLaAbZ UyJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720048962; x=1720653762; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c/Wm/ZqWSe9+vVjjHuOE+3B7vmuCMEHlN8ZTqW1NnMo=; b=W8VuFn17azf/tL0FnEKgrzFX6pYoNrxmlwNbrxGkQ3+7wnKz1XGF/FziL8K/xRHCwB 4EJjA97Dn6OXDyq/q5dGgc/V427St/2HCaD37QnE8E4Q0llG2y+OlwNeUuwAkrwCZ0wx iC87fS/UHY4Us7L4S7YYpBMQoY9vrXEZldPRRiHMyblaZtxzdY42xKwMH0A2/SOmm6Dc oJfkyp1bf1NDxLoc88+jPnxh9R5BCBfBgAOmv/q+/MYxHApAJ01nkRYlQniT7Xn24A8x ngwaQQIlQkm9LgjB2+zpnLM+B7n2uygqhZ9jrC4a4lvPOr9xUNoNnUVQys5TClHC0NDP sKBg== X-Forwarded-Encrypted: i=1; AJvYcCVVJ+kTBOfgut5fRfrQXinfbgTfd2kT4ElgZ3mAfrcaLeCYQrp+1dEwH6MaBdY9YnxjHTL5WoyegV+ZGZmI0YGTUC4= X-Gm-Message-State: AOJu0Yy8n8AlE+SinhwmgE0XpDKgmU1MI2fCzosxWKWit2+GIpuOYTAy 5OZkrpvqGYSN7zQbMbSTN39CXoyh6bv2zlGeHJzczbmeyciioW2u2NnI9UohwZO5jHsgd7QXOYl ma1xSS9B3jnssEwfxknmUHEBkQXM= X-Google-Smtp-Source: AGHT+IHpIyrGd39TptNfNvOFCTvHEAO0R0DdmzXwWGK3QjB9m5iJJWzkJBfbszzKGIo5FUXMzv6vx8+tBZY1/xVX6l4= X-Received: by 2002:a05:6214:252c:b0:6b0:7864:90ac with SMTP id 6a1803df08f44-6b5b704fa55mr178712816d6.11.1720048961729; Wed, 03 Jul 2024 16:22:41 -0700 (PDT) MIME-Version: 1.0 References: <20240629232231.42394-1-21cnbao@gmail.com> In-Reply-To: <20240629232231.42394-1-21cnbao@gmail.com> From: Nhat Pham Date: Wed, 3 Jul 2024 16:22:30 -0700 Message-ID: Subject: Re: [PATCH] mm: zswap: fix zswap_never_enabled() for CONFIG_ZSWAP==N To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Yosry Ahmed , Chengming Zhou , Chris Li , David Hildenbrand , Johannes Weiner , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B45BA120010 X-Stat-Signature: snncn77seuyu9kzkc79g5uguuzbi9cxs X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720048962-497078 X-HE-Meta: U2FsdGVkX18xtWSeM5qYHglmUfnnDAokipsKnHT1X5ZgqyvOcLpKCwvuaJyvI4QD6wH6Wexl+Eg1eWXlburVGq+ysumBuWplMysmFcrlpZFMkSuEY2UrKvvmsurggGl0DNjbvkFoBP+KDg5hQdAxsHt0uTnRRQTBfvpoykyL25CwAT6RHUHxmBnJzGBsJR009JUtoWutmVCCCI+iUFEhTQc4TzNSdkIbfXuOIUwzvSsahn22vh4gn5Z0IL1TphUwuTw5U87CX6MChFdpCuwR01QYBwTGDWc5fYHiP/XWOqGuoJ361k7mBG3QVxEsYOQM6ka5vThaYVED6RodevLpEFvqvr9zTdIEoim5qgL5UWxvc5MHBYvTA01Pie7UbG91WGPJcU8iWC3JbmYxxWQMrMlG/JZUkrMNM9b8khfObOBLkYJUtd3Oaeqmkz7OiEiPYOGV7eYoN/es8ALiObLGJZsYVsWUE8sNYYYp2RxfDZ9WgCz5js98KqcbRIEahv1k8ATTxesP1LjRguNZEWwKu0YfSFwKcXcUvxb3eDFrFImw4cTsRWCxUcTDjHngrg7hIWiFZDQ8POJ2VdQMdy82Tv3F5634CHwzxONx5YU8O/fMgmN7G1xDzmAoL1fD5yb4QxLYz2eqJJ1xsTy6YRBldDZtdwdDl2fhONhGckaKAeFUFcuOR25CvWH0DORt+H6hzPsG9M44oVEedAVgWax1gU7i0iV5BnPSmFAeN3ljIPyJi5zVYnjBi5NXYcxp64rt3pUKxQIxNo6z31J7DRxJUx1HuW25sKQJg2RGIlxPd3wD6cZjSGTLqD4el6WgLBz0zASJmtYJJJZABr/YvEprWbjSCxFNK7jVnzIe27Xi/xfUUuG+hXdoFt94S0veSUCSHO/OvMnJg18CD8Y8xmOuZCuS+HK9r16DRFiKL+Fxl9sS51nA/6FIK+3Kn/7mp2y1r3oqPJiummVCLLx5ALu SHiIMWMK Bubfy7UUBSHAmkCBgudaAq895FTM+L/S21HAQ/6dOtHCbvHm60ERaQAlwDEdPpLR8sS/xF71HAr6rD2gTLq4sM0A0teJe4CT477Ie5VM/hU4u6G9meFtqOxvjZpI9n/njz6Boo/33ozvd5tnFRn+8/45TI5H9XdigBNRoRjm6H1Rpl0SUGPu0MnUWhggm/LF9DDg6v5OwFFjikk5mlICUbcQAunUkmHlO9T4cxuo2E0GvoeuOe18ZHLB1Ds7BCpyrTk6IG/D5PaUrStyhO7wkUnfKWiXwQHC0gE9dSAzCsbJPYslY/6a+LL0nlEOEI96HHp7M4/3+hguo7rGg9KtvemwaS7vcJfO3/EHv/7AEXot2W/1HlPuUnSIPL6q0HI1xGIwmQn6kv2+3+24heuhjYKH7V8QxOUtvsSvLi4nbDhCKGb4oLqUALyMYlAFTv2xlbrWtOEBW3fwGZRT4Iv7F7P0y6ZFBsRvEQ3cqc1MuR1WIcelBtlQdS/eJ1ilz7EY69JS6nN0e+XYSAus1fI2jHrKsI546h/JJDsxsJivUJxPcTk8A7M/YHkpUdf+AW6ycCzwSLqhQ3qDADAmVpw4BN1fVB2Zi3IxDkHAaUK6zcheM3vzx8Jzq57uMrbYgQfSwIfqVZLT3l0HKY8OmWbg/lYvr7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 4:22=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot= e: > > From: Barry Song > > If CONFIG_ZSWAP is set to N, it means zswap cannot be enabled. > zswap_never_enabled() should return true. > > Fixes: 0300e17d67c3 ("mm: zswap: add zswap_never_enabled()") > Signed-off-by: Barry Song > Cc: Yosry Ahmed > Cc: Nhat Pham > Cc: Chengming Zhou > Cc: Chris Li > Cc: David Hildenbrand > Cc: Johannes Weiner > Cc: Matthew Wilcox (Oracle) > --- > include/linux/zswap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/zswap.h b/include/linux/zswap.h > index bf83ae5e285d..6cecb4a4f68b 100644 > --- a/include/linux/zswap.h > +++ b/include/linux/zswap.h > @@ -68,7 +68,7 @@ static inline bool zswap_is_enabled(void) > > static inline bool zswap_never_enabled(void) > { > - return false; > + return true; > } > > #endif > -- > 2.34.1 > That's some pretty yikesy bug :) Thankfully this seems unused thus far (which is probably why it is not caught until now). Thanks for fixing this, Barry! Reviewed-by: Nhat Pham