From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE29C83030 for ; Mon, 7 Jul 2025 21:36:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5CCD6B03DD; Mon, 7 Jul 2025 17:36:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0D2F6B03DE; Mon, 7 Jul 2025 17:36:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFB916B03DF; Mon, 7 Jul 2025 17:36:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B8F116B03DD for ; Mon, 7 Jul 2025 17:36:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3440B58B67 for ; Mon, 7 Jul 2025 21:36:18 +0000 (UTC) X-FDA: 83638777236.22.0EC7094 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 5547A80007 for ; Mon, 7 Jul 2025 21:36:16 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YYuxrNyB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751924176; a=rsa-sha256; cv=none; b=vaL88VaVJVJjgbX7dEcuBL3ibjCLJzCnukySWKV7zPtmglxs6DE4gO5O/qFzQ+T/XBQeNR Yl4WsdEiMfWOtpggFxlhRneCNIi0APhQVAInwKP5J5GOvVIqPreIvjR3OdYQW4OKlGDbx3 xCcKSEa+gMdfeV3/UVdnjKfA6oertvw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YYuxrNyB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751924176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AgXzm5BjSI3KcAbN6iTh4ah/yGVIdDZDH2WwHNES0rE=; b=TJQimpfEvKKWXzPUC7qUS83SF6i/Vj8EBy/k9TzyPDXcp++v/OjCrmHp2FINfzsjXmkwTK LSG7dIPbP4PnsS43692Q8FbMWhvjbsdFCf/pHz/zcKe5Glbgv1ZLNs9PUw3EK/rsl6nkfT kKmJEvLTDCo+qe7jVU5y20PJwpVCJ1M= Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-70478ba562aso12476886d6.1 for ; Mon, 07 Jul 2025 14:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751924175; x=1752528975; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AgXzm5BjSI3KcAbN6iTh4ah/yGVIdDZDH2WwHNES0rE=; b=YYuxrNyBAKPDMCunME+FO2y5Cc/TlrxFc3oBEWnKyvGEZLmWajoIz3ohqcGoEmeG9w KAsjn/mndxUgSv4DV9qmEbdplqNq35oNyPLcOkBNER7/IZvPApD2l5JUBRybKNTgl+qx f74JHmpIegtWXEtjo8OujxNhXzB3Oe41bSdvbE67RWSv3ytC9Zfb9GhEsr5FnwWrR8Zl Ms3KvmSKXGONBABO/z2+9XTY3gityaUtlYYP2LnuUEqybf1xIisewYk5uaWbEnwzX+jL x/nhGd0pp1rng9GnqzSEBWNtFjk5lDb/OFT3M9dyBEYEvZlliKWOWy2jEe+s1gruCOAU nEiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751924175; x=1752528975; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AgXzm5BjSI3KcAbN6iTh4ah/yGVIdDZDH2WwHNES0rE=; b=wxQtUQPiXpwCj7soHnZSu0b1VeDFSrmVwHmRIb6dv65sq3AkPI45wlEtsEckmVWaFo C3PXZxmtOjo6ZS2s8C7wf3OlDIQScnq26YQ09sic75w7D7LC2Mmz2M/9g+gT1VzZatGi 71zV412ERsl3IvY+v+EtrhkPWE4rE9uCJFKGK34+ppAF75n3PFbQieKL61Jw4V3x0LPS fkpzM/iHaqRINS+iVGJ2L5IKMVM1Vz1vcJSiHn1ozNcjEYlgJPS3hFT6b4ZKm+uaxX2k siG/encEBSO2NWKwOjtdm2I/aBxFfCQ2pHwZ8iHI5Vnwf9IQvFOP0mpHpFYEqpubYz6e VElA== X-Forwarded-Encrypted: i=1; AJvYcCVZH+RNmM7KtCLERi6HbOn6dK6BVQFLj+G/rXzETvhZxMzK1pqAlN9bwkhoWzdFhPAK+4zy4DHzHw==@kvack.org X-Gm-Message-State: AOJu0YzwSurwuWeNwP+P8LgTkFq4Z3qBb6eFXmxf7oSFDlg87WOUO1/3 owBH4wZW9/RNWGP/9OuSVd3OLBOnvLTHd4zeb+fK+UPvJc+G7emrHSJtcM4uFwg69/q4MEbGP4p 2oyhFlHJvi5kmAgbw05TO037Vx0v7aZY= X-Gm-Gg: ASbGnctndWpfu3j96rokyEPb7B12RM7UTM2cT0eNmSvnOdMMmh2FIIS2/T8skjqvUmR qNWEC06cYxawI4YjS/jg2UCJtfQO5CseIuCTqX06AsvD+7QWS1hVeayFvxBk6vKpYhUhkunxJLb W/AFUHlsC28Oq2P7OQp/c9q4aZ0YObNAfiipKXnRd2ynE= X-Google-Smtp-Source: AGHT+IGjQ/jAhJbZ8lc0yUb07O5YCQVwfwf8m5we2B2vz9P93WDuTrr4vdLvtjNUbGlJx2iSClfUmslSNSuXi5OYq3Y= X-Received: by 2002:a05:6214:4002:b0:6fa:c22c:f78e with SMTP id 6a1803df08f44-7047de5b94bmr3902996d6.14.1751924175262; Mon, 07 Jul 2025 14:36:15 -0700 (PDT) MIME-Version: 1.0 References: <20250707201315.9497-1-kanchana.p.sridhar@intel.com> <20250707201315.9497-3-kanchana.p.sridhar@intel.com> In-Reply-To: <20250707201315.9497-3-kanchana.p.sridhar@intel.com> From: Nhat Pham Date: Mon, 7 Jul 2025 14:36:04 -0700 X-Gm-Features: Ac12FXzC_peXj9DZsfELh_JiiOkUC7_stiNLJlf9zPBVkwkWQY1Girc7jHdTnK0 Message-ID: Subject: Re: [PATCH v1 2/2] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5547A80007 X-Stat-Signature: 1kc4ak78wjfiiah8x3o59xfhfkw4jhqp X-Rspam-User: X-HE-Tag: 1751924176-644779 X-HE-Meta: U2FsdGVkX18RW+o+KEImNTBOZlFrpy2O+XXKVB8ZcL/u4/xR8HPFaJRAI7cUX5x75+nkYmK54LaaJwEEPDaKDsLZXTLsz1M/ylycgwEnWYKs//x7RsStppkL5goshGnnh4zH6qzaB2hpEBaYk9UoCV8Jh46IKZLmv5TDYYYGXg4jD2rfcBq8KFotl3p48unCo2RWleTlPmIfKz77XIYahi/TiEgRUIulPhU7osTNWOI+4KeHKY/FBrL2O0UqKeB5LAXlRfLxafWBOATHOmn9DZTkVfO55X9v+kOhfdaduhGNKTcDrHvMZNcdBpUTih1jvjAJmzoJ77xrGwMxI7Tyo5yoCNJYBtRqGxq/hW0IqgzBFg1R3BgZiJ4epjwILgRJjSQ+E70L1bOfvBSzOK/aVBM+i1LUCVlDGChKsvkT5JEesrnFhXW8Jd7/UJ58Q0WTMoqg82O8Y4UD/wadoCm3P6bbxqUIDmUq/vBzlZU8xdaUHYQQiC1qhdiRHlSNWaLeU6bfECXQNAHWXDNNObPbaN+f81gy4f1DW2E/WoLXbCZ9Oe+09Pq9Lj/E+kXcXW3H0sjl6ruOgfv6YY+P15MlBJ7x623dZa6M/ycZlp9pnI0bEzeuWKcwvzIbFFEnXiyq4T6mtc++5qMrhVcxiCHt7fFDKh+xdmWQoX7Te3L/lDBDHuQSCbCuZWf1WYYnSiI6qAQbrojtV1djOuLvkEh8Qw7TfUmV36AjS/uMRwQxr0FbnsvC8SRpsAtQ2PB96lPQPv9Vc2p17VcEsuN8pW8Nkys7uQ2yUF3hDLLz6XbZPolTFZyk5mnGGKSYOVRihMM9arpKM3R5bKcmSXgcuQWQZG6fUImdN1Xgh6K/0whrjqsjHTy/Cacws6HAF09OoBU0FFhUfj4KyVmrxmL+rGdHwvNTwXfFYLb3XFlh9410QHw55Ysta2uMTtRmWpemhc/CZYPjMFG12u6z66onBws OXsXoUWI j4y2UXZuWTL5kwTQLmL9f3rEmS/3FmnJQ33oinaENa+cFzPPsValNw54bpLEb5mZK8S6+/6/frFJvajRk9paSL0VCxqwC+gJnpRX87T7yw4tZeCbvJCyYJR+IvP83bbRdBwD3ydU5lWdDU8Pya6LLLyg4Go0dxZMAlteKvcrpaabWAIGr8chMqFAKz56GlO0o1o3xmX+ljp6T7SLMCMFrQA1MQnsUVk/O4JhOhKKNAoowxWsCjtlwtkmIT4fddhxZcPCoPDASZ3E7zT1kvmv29f6LsBT74c0deus9p825tOmOseV8qpaM/mPGDxldvN6NZkl/+DInS8NprUMJok9GwQVpk4ceiHZTAPF9PLUEjLDmUdN9Da1zimt3oAjq3gKkCJTOYR/qB7gKM4g+vQnR+iKF2wasyr1EkavR9C13Wmuh/04= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 7, 2025 at 1:13=E2=80=AFPM Kanchana P Sridhar wrote: > > This patch uses IS_ERR_OR_NULL() in zswap_cpu_comp_prepare() to check > for valid acomp/req, thereby making it consistent with acomp_ctx_dealloc(= ). Is acomp_ctx_dealloc() introduced by the other patch series? I can't seem to find it. Also, why IS_ERR_OR_NULL() in the first place. Can crypto_alloc_acomp_node() returns NULL? > > Signed-off-by: Kanchana P Sridhar > --- > mm/zswap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 7970bd67f010..efd501a7fe29 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -893,7 +893,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, s= truct hlist_node *node) > return ret; > > acomp_ctx->acomp =3D crypto_alloc_acomp_node(pool->tfm_name, 0, 0= , cpu_to_node(cpu)); > - if (IS_ERR(acomp_ctx->acomp)) { > + if (IS_ERR_OR_NULL(acomp_ctx->acomp)) { > pr_err("could not alloc crypto acomp %s : %ld\n", > pool->tfm_name, PTR_ERR(acomp_ctx->acomp)= ); > ret =3D PTR_ERR(acomp_ctx->acomp); > @@ -902,7 +902,7 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, s= truct hlist_node *node) > acomp_ctx->is_sleepable =3D acomp_is_async(acomp_ctx->acomp); > > acomp_ctx->req =3D acomp_request_alloc(acomp_ctx->acomp); > - if (!acomp_ctx->req) { > + if (IS_ERR_OR_NULL(acomp_ctx->req)) { > pr_err("could not alloc crypto acomp_request %s\n", > pool->tfm_name); > goto fail; > -- > 2.27.0 >