From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2F6C4345F for ; Mon, 29 Apr 2024 20:01:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F9866B0092; Mon, 29 Apr 2024 16:01:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 680C06B00A2; Mon, 29 Apr 2024 16:01:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FB686B00A3; Mon, 29 Apr 2024 16:01:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2D9BC6B00A2 for ; Mon, 29 Apr 2024 16:01:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D5BBD140250 for ; Mon, 29 Apr 2024 20:01:46 +0000 (UTC) X-FDA: 82063639812.13.110A040 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf04.hostedemail.com (Postfix) with ESMTP id EADF540025 for ; Mon, 29 Apr 2024 20:01:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Yyr+nm90; spf=pass (imf04.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714420904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gt3s+UzBw6kM3wJOvLkf2xGMTIu2IRgPL+I5Y7L6Qrw=; b=EIj/ysMwAWAFPXHaAJ+6jg1hmEVndnm7IKkEDU8/mpFKDaMrJVzyEoQAeeplD7zNF0kL1F +f5EuBaXYplkxsxQjVAYTAIS+bwQaAPp8Ccjvo7jgCRTV29gP9wrzkel+ssM73GybtsnJ0 4jKKE14lJpuhVCUoILkmZsHwkIyZoL8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714420904; a=rsa-sha256; cv=none; b=aVMZtoZrhzLwZoNwKGWNbnhdNpIYoJ1yUuDjLppK5NtXmgqBeS0mX9wnZA7OOTutZfB7lS 8g775NEX9V6eDmkp9YAzWIzfxJzl/woC1IN5As1BkvQa8dW2ZVRtxyUFwvjXmotTWlRhU4 howgD4dN3EUdU9zAQpfOAfMs8vo/agM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Yyr+nm90; spf=pass (imf04.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2dd041acff1so56863011fa.1 for ; Mon, 29 Apr 2024 13:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714420902; x=1715025702; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gt3s+UzBw6kM3wJOvLkf2xGMTIu2IRgPL+I5Y7L6Qrw=; b=Yyr+nm90b4q6xpWJ1s5cn7hEXPAObU0WNZnosxkgQnpg62jZASPVqcK73EM1zefn9D KjN/N+jdKGmPWQvIzp4pWwX/mg2VCmSJ5AWuUFANivauc/2qRVd8JdYxs3z0A48l+cdw okN4TzGdubpmJMMb3EXbjBrhRy/y2sdsdhXlHsZ+mjFTbvcHpJ4IKWiNO2+n9Kn+7lVQ fDXTC9qHAYQMEo7eUbPOJkBGL6x7+2h009ICy4wSBpkxqeYY1C1ObF/oqIw+ugX9+aVe qyUW6C+iWMmiyd64YGS8PosIR6k88MrGWVPnWY2dkFK1xgR9ORbZuvUd6QY02hRNot7U MSCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714420902; x=1715025702; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gt3s+UzBw6kM3wJOvLkf2xGMTIu2IRgPL+I5Y7L6Qrw=; b=PWjwVSptHiAzxYlejHcmGrDU04C1RpRYz+25Yk+t1sufr3rRqsPjP2XYsZHZPhzmr5 1IaykTOEktJilYhJjQAiRkCsoHpGf5OqjBonfrjkZ4ryBUSn5voyt3b64dZd/N54SCNv /acbXJmEuLwBCG78nojY4OS9zT+2r7XZB99Lc6RR0ms2gI5u78Tv5BvMxT27x6v1HDqH j5nQV2ef4BxDeejodUInV/wkFPUIjMaEFOlXdhwp4sHPwaTUv4RYmzhitz2fd1csqLO4 kAjPwEM2oe/6D2jqOlEFryyww64B7xLCqT6abWhNP7rM5V2LDUzxeMUTre5gG7UZ+XHf yojA== X-Gm-Message-State: AOJu0YyzChtJczlhfvQMPZ+0Hd1PvjJJ7/AmU1VM+bF5m7V5/+rdnNhp BsvGd7J9WKsdd+lwo4n132a59DadymkIgp+4yTaFL02BtHqmAxrvUbL0t+TpraQXiDQQd2stXVp 9GZXaMCvSXaoXKMcfJzOynA23SUE= X-Google-Smtp-Source: AGHT+IEUwVSZGAkL0NmCiPGfPRW7x955qFnKQc6XQIgknlcmV/FRn4nEWgAGVLy6zxpOCntcK+HxFa6yyP83rfcnZa8= X-Received: by 2002:a2e:8802:0:b0:2dc:c95f:984d with SMTP id x2-20020a2e8802000000b002dcc95f984dmr7214308ljh.5.1714420901889; Mon, 29 Apr 2024 13:01:41 -0700 (PDT) MIME-Version: 1.0 References: <20240429190500.30979-1-ryncsn@gmail.com> <20240429190500.30979-3-ryncsn@gmail.com> In-Reply-To: From: Ryusuke Konishi Date: Tue, 30 Apr 2024 05:01:25 +0900 Message-ID: Subject: Re: [PATCH v3 02/12] nilfs2: drop usage of page_index To: Matthew Wilcox , Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: fa8uwegnkgwqff4xn3sds1nmmgg367f9 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EADF540025 X-HE-Tag: 1714420903-849110 X-HE-Meta: U2FsdGVkX19kk1MEyrD7A6DML0OHbocCpiXpOU/88wy893LVb0bxhsXdOs0Y3ajwfyCnH7eaRnbKYf85/2UwF+sdLSjlUqZiO6QrjRxiQppdNJxF1nbt4HZZDc9dcpEnpmgnq/01IJE+ETB6FoTmKnkD0IOL7SQLpv31B+j30bsxa3cp42AG5rJO/R1NmGqk+sg43X9XljBs4mY7N1i6PiHtGYBhRfS8+58HPscEdFtp7lTntjqeaCe/s6X07HU8AzIzIinYJb30RCtvoFkX99v2gIHwec+n0MH1lDRhJLJuZkrw0DFMczvAcX2Spuk1Cv/unNR/CsGDQYqPtA1V+T1k1pjK6eZYCclV8ShvcIEDSCyN4CKjMJuFG/yvpwx/u+BWB1Tbxwodo5JsGcjcAnqzccvVZPxrmkgaDThKCOsBJXMtXyGz1WJHNSKth/aivCQgvm+aPMCeACYvxy6MhJfcV79hFgLEzUm10gN+/Pz1B8FqZSZzq2ZGSO+fFWWRwS/K/U5KG3spo/agrtdlztUAow54Sei4j04YHZBsAFG4lPxjuU4IdKD9gMqEhbuFcYJw5wV//Qmi3uOBl9rL9/CKWYrAt0DnsmxU6ROcNQZwrUe1DnpENuJS7gwlYSq+XNqSWrmLE6m8YdsokPYp0OqDOHPTsbYk0u7Au9TV5GNoi+zDR0JBl2kJ6T+f3xU2QUtbdpmoRk9hVEF4X6Nl10qAbvv3J7D83Scu9nU4x3qcaerg8gycqlFdxPogzN8Q84wXSGWqNyP88pypl/3f4/eBiNYZXj2pztJ/am+0eNqSConfkZ+i7hv+fFZqF70Fs1kOvm2gAWVlNv/ZGfXJNfE/ACNUSQlCwzMLXTQ9k/6xpYvjpF4bDcxUxmaENpb/3c4JtEeVeOnnzWLEbB0szaG+rLXwPv2BmaybY7qHsHT7QGTra6kEqRUF728ADQmafA51E2VYX1vkEIvYHg9 fkCNEPfX GjeXCqhGbHZmRzMY9yzer3j71grami1Be3YGjX5Zc3+3mvxpuzYVOaAPkg7Tu0Sh9RY0YQYFICb40giDWAZg6lYsrs0TMdnOOLyfEoZkFm6ADq+LxLy4Wja1XCLx6ZqyhAYJY7EI31oKnfyo2epr2Da+PGNc7pKx0xGRp+Wpo5RR9zMgUnI3SO3O/vUDifEQcxB1ExB7yJqSQ1tQdoRQfs/xCINxmFxIjl/7qrSn05RTM5GIlzyRuyB8PoGT+1YSnlPXFEm/HsOxMWtVYVZEMBmLvGiy27t6LYWRymhi2JRo6IWc4BSKFNM68Zbx0w+ZQppw2/1QFYgIw9Ep9zV7HO+ONH7RtjSMM0GkB/QEzbWIlDu3v3pTmDvhBIxaAlD6P9F84k+wg9Yb/g7xTBastq59devgARE6faSTyH0cVRf5dHHmTH4TAhMaJkzLp3uwKry4f6uPqy/4kT+szrQQPFEVF6JSOuTddANQxcKbcjubV0i1V54oePoJv0DjbSuiirOjWyE/Y783C/BLlaO27KA4b3KQbGJ+oeJTq+wfAVFrFEQuKuLSVJinWcTdjKegcjVdWAc8U9xOVlNVIUiqPfLlhab5XSVHfhdffTJWEMTyTAlE9WDJO2hbymHqewwtzH0BB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 4:38=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Apr 30, 2024 at 04:28:41AM +0900, Ryusuke Konishi wrote: > > On Tue, Apr 30, 2024 at 4:22=E2=80=AFAM Kairui Song = wrote: > > > > > > On Tue, Apr 30, 2024 at 3:14=E2=80=AFAM Matthew Wilcox wrote: > > > > > > > > On Tue, Apr 30, 2024 at 03:04:50AM +0800, Kairui Song wrote: > > > > > From: Kairui Song > > > > > > > > > > page_index is only for mixed usage of page cache and swap cache, = for > > > > > pure page cache usage, the caller can just use page->index instea= d. > > > > > > > > > > It can't be a swap cache page here (being part of buffer head), > > > > > so just drop it, also convert it to use folio. > > > > > > > > > > Signed-off-by: Kairui Song > > > > > Cc: Ryusuke Konishi > > > > > Cc: linux-nilfs@vger.kernel.org > > > > > --- > > > > > fs/nilfs2/bmap.c | 5 ++--- > > > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c > > > > > index 383f0afa2cea..f4e5df0cd720 100644 > > > > > --- a/fs/nilfs2/bmap.c > > > > > +++ b/fs/nilfs2/bmap.c > > > > > @@ -453,9 +453,8 @@ __u64 nilfs_bmap_data_get_key(const struct ni= lfs_bmap *bmap, > > > > > struct buffer_head *pbh; > > > > > __u64 key; > > > > > > > > > > - key =3D page_index(bh->b_page) << (PAGE_SHIFT - > > > > > - bmap->b_inode->i_blkbits); > > > > > - for (pbh =3D page_buffers(bh->b_page); pbh !=3D bh; pbh =3D= pbh->b_this_page) > > > > > + key =3D bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->= i_blkbits); > > > > > + for (pbh =3D folio_buffers(bh->b_folio); pbh !=3D bh; pbh = =3D pbh->b_this_page) > > > > > key++; > > > > > > > > > > return key; > > > > > > > > Why isn't this entire function simply: > > > > > > > > return bh->b_blocknr; > > > > > > > > > > Nice idea, I didn't plan for extra clean up and test for fs code, but > > > this might be OK to have, will check it. > > > > Wait a minute. > > > > This function returns a key that corresponds to the cache offset of > > the data block, not the disk block number. > > > > Why is returning to bh->b_blocknr an alternative ? > > Am I missing something? > > Sorry, I forgot how b_blocknr was used. What I meant was: > > u64 key =3D bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_= blkbits); > > return key + bh_offset(bh) >> bmap->b_inode->i_blkbits; > > The point is to get rid of the loop. We could simplify this (and make > it ready for bs>PS) by doing: > > loff_t pos =3D folio_pos(bh->b_folio) + bh_offset(bh); > return pos >> bmap->b_inode->i_blkbits; I see, I understand the idea that it would be better to eliminate the loop. The above conversion looks fine. What are you going to do, Kairui ? Thanks, Ryusuke Konishi