From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08A6C4345F for ; Mon, 29 Apr 2024 19:29:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C0286B00A6; Mon, 29 Apr 2024 15:29:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66F6B6B00A7; Mon, 29 Apr 2024 15:29:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 537576B00A8; Mon, 29 Apr 2024 15:29:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3601A6B00A6 for ; Mon, 29 Apr 2024 15:29:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D1C2BC0200 for ; Mon, 29 Apr 2024 19:29:01 +0000 (UTC) X-FDA: 82063557282.08.3E2112D Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf28.hostedemail.com (Postfix) with ESMTP id 3F190C0032 for ; Mon, 29 Apr 2024 19:29:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A/Y8P0vy"; spf=pass (imf28.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714418940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Id47GDLJX/lNIbckbHqS7aCM9UEs1NMxnMsPlIfT5U=; b=E8SsZ0+x7B6XNPnx36o3eOzgGR3eI920s3YPUX8G86bEd+2z8nN43xkP8mdTi7WDYG2OZP UN6udMoUns+EPfXbRoQ51OqT/pWz/50WxJ9vD0zxBhFyIhUvR9yznQiQbU+Lrl3D4Fn+6H T2hULNi9nrv6oVVQwZYuXtO47Q8rA2Q= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A/Y8P0vy"; spf=pass (imf28.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714418940; a=rsa-sha256; cv=none; b=vf4ruMkq8tZluNES8GDcL0zz38lraEoQitEi5x0bEc5V9JSyv/xwgVZ6y+cKXon4goRMZy /X7ZKShHHiYKGQq7o1iWVRsh4XKjF1CCJUnNubW/xkA/PE+J86cIBevvlD9mR79R0I8aP1 FDqFjwb+Q8R/+a2AjGhQJhjhgBtBQlY= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-de603e3072dso878704276.1 for ; Mon, 29 Apr 2024 12:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714418939; x=1715023739; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2Id47GDLJX/lNIbckbHqS7aCM9UEs1NMxnMsPlIfT5U=; b=A/Y8P0vyGvfiw8znN/Gp/McA0S9GIn7Qai5/JKTsfrvjjVvHuTzD+VR/MDvz10Lfik hZ90Tr0lsinAhZSykhPubfEmSQeTBsvBtlQEsmz1UURY6EoV0zer4d/cLRCLYag7od9l mL+bSpKayNKJdQkfZgR9RzbYwJ3cv0PvYuTi4czEtIVEgSM9smow9UAfIgg6cCIRCs9J IAJ9t1VMiT4lYMPiroSHtyBapCGOTueRuSG1zOqcB47R31+OR8P5yuewUxZm87e4IYZM dGmP5J/VFHYG4mBviQ5+3cn3RNlbuKB8aXy5t4xsQGsuHN4QT7Y19m0vu9XuKN1+WNmP CWCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714418939; x=1715023739; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Id47GDLJX/lNIbckbHqS7aCM9UEs1NMxnMsPlIfT5U=; b=CFtL/oQr5csk2nDzmt3kc7GOryegFgUNFyMvwO76VMHiYbb0yxYtfmKLEfFcFgiKcW hVNdhNjZ+So/MzhtjKuVksfD3NPlC+otxDUE0vA0+7YxVGzsFx1BVijbTx330SzTFgYw +C4UnvOfZqxP78lJzzDzkdx+GqkA1Q293xZ+A+kh+5l7PRWe+OP8e9SO6kFUYS19l0be 7dX6AobhDVh+PmiMkvTHrkK5lv2npH2jFQYBzefX4rWwb0XVwgShW0+1vCxJ4cc7rhx+ vNOfPHzA97l3QHFTxuTXaYkl4qrYIDsd3m50XDhJGY7SFsyla4HvO8sEs091FS+RJr0V MZhw== X-Forwarded-Encrypted: i=1; AJvYcCVCkFI9iSXsGTXCBzeKFxhnAjPZbg3cKzteN5hHM679MZ9/LscSkiRg1fK8xptpSfF+NrX3XeGKtVlZBe7WtrxWNLQ= X-Gm-Message-State: AOJu0Yw3GO7VMDbYpQkqBm7xGZvIwpNqrwEjo+Z/ZKUefeF9DfUWVTpZ U83PCDXsNISl7tGYXgm9B7QYekiiROtwtUQNDCX+lu6mjohq0kk+qPP3KFxtQWRX/YxgjCiqpHp vh5N3xtc70D0XIEeGTG8LGlRj0Nc= X-Google-Smtp-Source: AGHT+IGnykyuLXCrJmmx0CN8EyQRfA8e+LNcgun2TNRNAmKdNprludRbilUzZT/X2nWgoMq7eBz6w63uJZ7OvZ8nzOA= X-Received: by 2002:a25:7587:0:b0:de5:8427:d669 with SMTP id q129-20020a257587000000b00de58427d669mr8497299ybc.53.1714418939241; Mon, 29 Apr 2024 12:28:59 -0700 (PDT) MIME-Version: 1.0 References: <20240429190500.30979-1-ryncsn@gmail.com> <20240429190500.30979-3-ryncsn@gmail.com> In-Reply-To: From: Ryusuke Konishi Date: Tue, 30 Apr 2024 04:28:41 +0900 Message-ID: Subject: Re: [PATCH v3 02/12] nilfs2: drop usage of page_index To: Kairui Song Cc: Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3F190C0032 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: n9t8b66qja95m4twtfcn9c6k9qje9eya X-HE-Tag: 1714418940-768731 X-HE-Meta: U2FsdGVkX1+3ZsMrYjrKhaxQrb+OznCrZlK6UR+3exIOdJRLEehsM1l+T0g6noxP5TRYaQJ3/389M9ejy/l8Sm0jN7n9QV6VMiA7Onx6UM9LzSmxjEORbigQH7z70A3jzN6S9vugpzDqtikTX+r2bSREAeQlNSVdINNDfkzHIIAJv0kIrzWSPu81pFSE4YCSDf7Lo/Vh2KbTWuDcyrdljUud/S/V88dbq0zBxNczP9JiHUtv4A4xZPnfpwmZLfu9QHV0Cf4RMEhxuf/mrppxrpnHNHpb+MlDK5aswHQDpSeOz2q4uGM3r/kB26onXvVLw2BOujDvcD1cnC7yoAieH59VhSEPtQMM3zNXxgKAxwVBhXI4fW/9BPP5LHHz8OaqdsBMMZxlTY537Ji8fGEUA45i1XwkqUfPsiTg4lQlFctrYnV8AZ2ujUHLXagaAtmbWATymfDUEDpC9dxxACPjpNmPXgJCQ8/Kk/BJTuDAzCx9NsThEySO0sOWKxmhIyxLQfXcyXKsAAlh9Nsndn7eaDUSgWRpzeseCcJXBQM6f01AzinC1J/2zVaerxhjJS3ssPaIHlHWle7TwrnMUhux2p7Tt6nzUSRNnW9aBtL4FchdGaJlH2BSWs9/QHtaJVqm+je8EsYABRIY+WKD6Y8nbiX6lvVdx3mU9/uSchu9yp3xdXCUattIIV3aEfw6Wl6B6J7zad513857T+s07ZnueXlrPLI0z2pMfMG6bYmGXM5dtqU5AP8xHr1MJcw4knj0JRNzBwRQVbISi3/4E00+lLHNYWMR/t7qDllfPYDthuJBQbKSoA/6H9bI7vUUSGFX217FLrC2Yw3k1WDX29vxQdZI1Nr8v9E5OQRJ/6L85mnR8cqc6ANJVH9iKtywNdKwIS8qqlenjRjLz6VEzRtV+peT91jCNisFwzXRHhurJAM9J7UD8iQWlcm4S29ra/ZfqpIECM36X30hzSKqmDY kdNwlkLq AGx8nlsVgrPRlpP9yt53o+UV0Zbqm19QTazVIJfyRYnanM7ZUbwQ8TOLjYpWEQAJ8svqcNY7K+Ae7NjhePkEU/52uo+vWNTEMGAthLeDkI3bvzdvmEOffq8hOUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 4:22=E2=80=AFAM Kairui Song wrot= e: > > On Tue, Apr 30, 2024 at 3:14=E2=80=AFAM Matthew Wilcox wrote: > > > > On Tue, Apr 30, 2024 at 03:04:50AM +0800, Kairui Song wrote: > > > From: Kairui Song > > > > > > page_index is only for mixed usage of page cache and swap cache, for > > > pure page cache usage, the caller can just use page->index instead. > > > > > > It can't be a swap cache page here (being part of buffer head), > > > so just drop it, also convert it to use folio. > > > > > > Signed-off-by: Kairui Song > > > Cc: Ryusuke Konishi > > > Cc: linux-nilfs@vger.kernel.org > > > --- > > > fs/nilfs2/bmap.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c > > > index 383f0afa2cea..f4e5df0cd720 100644 > > > --- a/fs/nilfs2/bmap.c > > > +++ b/fs/nilfs2/bmap.c > > > @@ -453,9 +453,8 @@ __u64 nilfs_bmap_data_get_key(const struct nilfs_= bmap *bmap, > > > struct buffer_head *pbh; > > > __u64 key; > > > > > > - key =3D page_index(bh->b_page) << (PAGE_SHIFT - > > > - bmap->b_inode->i_blkbits); > > > - for (pbh =3D page_buffers(bh->b_page); pbh !=3D bh; pbh =3D pbh= ->b_this_page) > > > + key =3D bh->b_folio->index << (PAGE_SHIFT - bmap->b_inode->i_bl= kbits); > > > + for (pbh =3D folio_buffers(bh->b_folio); pbh !=3D bh; pbh =3D p= bh->b_this_page) > > > key++; > > > > > > return key; > > > > Why isn't this entire function simply: > > > > return bh->b_blocknr; > > > > Nice idea, I didn't plan for extra clean up and test for fs code, but > this might be OK to have, will check it. Wait a minute. This function returns a key that corresponds to the cache offset of the data block, not the disk block number. Why is returning to bh->b_blocknr an alternative ? Am I missing something? Ryusuke Konishi