From: Max Kellermann <max.kellermann@ionos.com>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: akpm@linux-foundation.org, david@redhat.com,
axelrasmussen@google.com, yuanchu@google.com,
willy@infradead.org, hughd@google.com, mhocko@suse.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com
Subject: Re: [PATCH 05/12] mm/oom_kill: add `const` to pointer parameter
Date: Sat, 30 Aug 2025 08:26:07 +0200 [thread overview]
Message-ID: <CAKPOu+9MBokh6z2o8=GKwTeU61Ce8Pbs7zjTSxo9=d+vKCYZWw@mail.gmail.com> (raw)
In-Reply-To: <aLIxs1cFhneGU5D9@fedora>
On Sat, Aug 30, 2025 at 1:03 AM Vishal Moola (Oracle)
<vishal.moola@gmail.com> wrote:
> > -extern bool process_shares_mm(struct task_struct *p, struct mm_struct *mm);
> > +extern bool process_shares_mm(struct task_struct *p, const struct mm_struct *mm);
>
> Nowadays we're dropping the extern keyword.
I can do that - is it acceptable to do that in the same patch?
> Also, Is there any reason you didn't also make the task_struct pointer const?
I wasn't sure whether for_each_thread() is const-safe. I think I
looked at the wrong definition; for_each_thread() looks safe, only
for_other_threads() is not because it uses next_thread() which takes a
non-const pointer. I'll amend the patch.
next prev parent reply other threads:[~2025-08-30 6:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 18:31 [PATCH 00/12] mm: add `const` to lots of pointer parameters Max Kellermann
2025-08-29 18:31 ` [PATCH 01/12] mm/shmem: " Max Kellermann
2025-08-29 20:44 ` Yuanchu Xie
2025-08-29 22:52 ` Vishal Moola (Oracle)
2025-08-29 22:45 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 02/12] include/pagemap.h: " Max Kellermann
2025-08-29 22:55 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 03/12] include/mmzone.h: " Max Kellermann
2025-08-29 22:56 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 04/12] include/fs.h: add `const` to several " Max Kellermann
2025-08-29 23:11 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 05/12] mm/oom_kill: add `const` to pointer parameter Max Kellermann
2025-08-29 23:03 ` Vishal Moola (Oracle)
2025-08-30 6:26 ` Max Kellermann [this message]
2025-08-31 1:49 ` Andrew Morton
2025-08-29 18:31 ` [PATCH 06/12] mm/util: add `const` to several pointer parameters Max Kellermann
2025-08-29 23:10 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 07/12] parisc/sys_parisc.c: add `const` to mmap_upper_limit() parameter Max Kellermann
2025-08-29 23:13 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 08/12] arch, mm/util: add const to arch_pick_mmap_layout() parameter Max Kellermann
2025-08-29 23:36 ` Vishal Moola (Oracle)
2025-08-31 9:07 ` Max Kellermann
2025-08-30 16:03 ` kernel test robot
2025-08-30 17:26 ` kernel test robot
2025-08-29 18:31 ` [PATCH 09/12] include/mm_types.h: add `const` to several pointer parameters Max Kellermann
2025-08-29 23:37 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 10/12] include/mm_inline.h: add `const` to lots of " Max Kellermann
2025-08-29 23:37 ` Vishal Moola (Oracle)
2025-08-29 18:31 ` [PATCH 11/12] include/mm.h: " Max Kellermann
2025-08-29 18:31 ` [PATCH 12/12] mm/highmem: " Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKPOu+9MBokh6z2o8=GKwTeU61Ce8Pbs7zjTSxo9=d+vKCYZWw@mail.gmail.com' \
--to=max.kellermann@ionos.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).