From: Chunxin Zang <zangchunxin@bytedance.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Hocko <mhocko@suse.com>
Subject: Re: [External] [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node
Date: Wed, 30 Sep 2020 10:42:46 +0800 [thread overview]
Message-ID: <CAKRVAeMWhetOCnt5vcC9ov3aG38gSrUrH2NVUXPiDyd49dnmww@mail.gmail.com> (raw)
In-Reply-To: <20200930020659.139283-1-wangkefeng.wang@huawei.com>
On Wed, Sep 30, 2020 at 10:07 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> The following patches fix same issue and both add fatal
> signal check in drop_slab_node, kill a duplicated check.
>
> "mm/vmscan: add a fatal signals check in drop_slab_node"
> "mm/vmscan: fix infinite loop in drop_slab_node"
>
> Cc: Chunxin Zang <zangchunxin@bytedance.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> mm/vmscan.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index eae57d092931..980155e257bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -699,9 +699,6 @@ void drop_slab_node(int nid)
> do {
> struct mem_cgroup *memcg = NULL;
>
> - if (fatal_signal_pending(current))
> - return;
> -
> if (fatal_signal_pending(current))
> return;
>
> --
> 2.26.2
>
Yes, there are the same patch. Because the 'add a fatal signals
check in drop_slab_node' description is more accurate.
The mail list please see https://lkml.org/lkml/2020/9/15/20
Andrew, can you update it , thanks so much.
Best wishes
Chunxin Zang
prev parent reply other threads:[~2020-09-30 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 2:06 [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node Kefeng Wang
2020-09-30 2:42 ` Chunxin Zang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKRVAeMWhetOCnt5vcC9ov3aG38gSrUrH2NVUXPiDyd49dnmww@mail.gmail.com \
--to=zangchunxin@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).