From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B02EDC4727C for ; Wed, 30 Sep 2020 02:43:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FD5220874 for ; Wed, 30 Sep 2020 02:43:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="xayrkaOb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FD5220874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 326B96B005C; Tue, 29 Sep 2020 22:43:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D7746B005D; Tue, 29 Sep 2020 22:43:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ED636B0068; Tue, 29 Sep 2020 22:43:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 0A24E6B005C for ; Tue, 29 Sep 2020 22:43:00 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B841B181AC9CC for ; Wed, 30 Sep 2020 02:42:59 +0000 (UTC) X-FDA: 77318180478.04.beds82_28020eb2718f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 9DD9C800DE06 for ; Wed, 30 Sep 2020 02:42:59 +0000 (UTC) X-HE-Tag: beds82_28020eb2718f X-Filterd-Recvd-Size: 3941 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Sep 2020 02:42:58 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id z19so285359lfr.4 for ; Tue, 29 Sep 2020 19:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FzMSyDG+4uOgzBHpqfZT/MbeTBRLHtt1WS9WK/I7PZQ=; b=xayrkaObU3Il4H+nuaMMdxgn7/aPj3l/vOTE98XE+9p44U4yqEX3ptVUiFWrUZjZaH SVn3ZlpvWfT0qV+yyqzrvjqp8t52q7zNJxXyOk5+z/BAfMsZMb7yQrbO0A8Ab8T24Wyw gsd0+7DSYyH3wDO0Ucx8SPrVNRvO4LQ0kn7f03Xj+9JsQ45ObPmgI8k4/KoFPObElwqa jl08z/WnBfJJsl/IAO3ENsKFFoDzljwKCPI/FrJsA0Cl2BPx7b8SWHyevU6sKW5gY8ZN mJmiYjRqrlSh3PNHrZfCe+nDOCy9EIrzy5+OG/lsifoeejM2dyFgBPM3nLUQl/5uZy01 yRzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FzMSyDG+4uOgzBHpqfZT/MbeTBRLHtt1WS9WK/I7PZQ=; b=nff/gjhHV53xdtOPnaVEgMhqt2ocLbp3USFgKgiaTsr+0t8d85+nkaKqJbhnlT0/Ze zHNmMsqfcCc6pAhlwhVdqahm2PZvPSDhRLG3asrXBAcMSk5w6lESr75UDylbC3QHmO/L 3cLVJemL7ta7NBuarDeNhfbejSbAWCah8EHskTJkmOVW+XcrACl0C+xJ8izBlp0B57sb 5zFo1IXKIUplXMHSg0YvtP8sFElpKCuwVkn0Wpmz2LRjoda5oS0lZw6ALq0EPiw2AuZD qioTl1iCNJQ0CYpR93o7lgk7AWfrMBvFDIQ2EP3Ht2s28ywMw9WZ2vivVGkBT7rw7Hrs sVFQ== X-Gm-Message-State: AOAM5315fe++WX+aa5mqMq+JvrLyIYy4ZkydsCjPY1PxMFYkR61wl3Oc huEwMmdSGtGyCLflC5/1xSV1YpRcmPkMK4SouapEZA== X-Google-Smtp-Source: ABdhPJwSX5vMWCiJ89BIqCV30L9yZv296SgzIKsfSRd2CaRZj71yTXsgfifUdIfaiXvgOXTVCF0DGGPG0c2Gi8pwfJE= X-Received: by 2002:a19:cc4d:: with SMTP id c74mr94470lfg.188.1601433777411; Tue, 29 Sep 2020 19:42:57 -0700 (PDT) MIME-Version: 1.0 References: <20200930020659.139283-1-wangkefeng.wang@huawei.com> In-Reply-To: <20200930020659.139283-1-wangkefeng.wang@huawei.com> From: Chunxin Zang Date: Wed, 30 Sep 2020 10:42:46 +0800 Message-ID: Subject: Re: [External] [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node To: Andrew Morton Cc: Linux Memory Management List , LKML , Kefeng Wang , Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 30, 2020 at 10:07 AM Kefeng Wang wrote: > > The following patches fix same issue and both add fatal > signal check in drop_slab_node, kill a duplicated check. > > "mm/vmscan: add a fatal signals check in drop_slab_node" > "mm/vmscan: fix infinite loop in drop_slab_node" > > Cc: Chunxin Zang > Signed-off-by: Kefeng Wang > --- > mm/vmscan.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index eae57d092931..980155e257bf 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -699,9 +699,6 @@ void drop_slab_node(int nid) > do { > struct mem_cgroup *memcg = NULL; > > - if (fatal_signal_pending(current)) > - return; > - > if (fatal_signal_pending(current)) > return; > > -- > 2.26.2 > Yes, there are the same patch. Because the 'add a fatal signals check in drop_slab_node' description is more accurate. The mail list please see https://lkml.org/lkml/2020/9/15/20 Andrew, can you update it , thanks so much. Best wishes Chunxin Zang