[PATCH] mm: update the comment for high_memory

[PATCH] mm: update the comment for high_memory

[Wang Sheng-Hui]

The system variable is not used for x86 only now. Remove the
"x86" strings.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
 mm/memory.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index 93e332d..1615a64 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
 #endif

 /*
- * A number of key systems in x86 including ioremap() rely on the assumption
- * that high_memory defines the upper bound on direct map memory, then end
- * of ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
+ * A number of key systems including ioremap() rely on the assumption that
+ * high_memory defines the upper bound on direct map memory, then end of
+ * ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
  * highstart_pfn must be the same; there must be no gap between ZONE_NORMAL
  * and ZONE_HIGHMEM.
  */
 void * high_memory;
-
 EXPORT_SYMBOL(high_memory);

 /*
-- 
1.8.3.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: update the comment for high_memory

[Ingo Molnar]

* Wang Sheng-Hui <shhuiw@gmail.com> wrote:

> 
> The system variable is not used for x86 only now. Remove the
> "x86" strings.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>  mm/memory.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 93e332d..1615a64 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
>  #endif
> 
>  /*
> - * A number of key systems in x86 including ioremap() rely on the assumption
> - * that high_memory defines the upper bound on direct map memory, then end
> - * of ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
> + * A number of key systems including ioremap() rely on the assumption that
> + * high_memory defines the upper bound on direct map memory, then end of
> + * ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
>   * highstart_pfn must be the same; there must be no gap between ZONE_NORMAL
>   * and ZONE_HIGHMEM.

ioremap() is not a 'key system', so if we are touching it then the 
comment should be fixed in other ways as well.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: update the comment for high_memory

[Wang Sheng-Hui]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

Got it, Ingo.

Will figure out more fine comment.


2014-04-27 19:46 GMT+08:00 Ingo Molnar <mingo@kernel.org>:

>
> * Wang Sheng-Hui <shhuiw@gmail.com> wrote:
>
> >
> > The system variable is not used for x86 only now. Remove the
> > "x86" strings.
> >
> > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> > ---
> >  mm/memory.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/mm/memory.c b/mm/memory.c
> > index 93e332d..1615a64 100644
> > --- a/mm/memory.c
> > +++ b/mm/memory.c
> > @@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
> >  #endif
> >
> >  /*
> > - * A number of key systems in x86 including ioremap() rely on the
> assumption
> > - * that high_memory defines the upper bound on direct map memory, then
> end
> > - * of ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn
> and
> > + * A number of key systems including ioremap() rely on the assumption
> that
> > + * high_memory defines the upper bound on direct map memory, then end of
> > + * ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
> >   * highstart_pfn must be the same; there must be no gap between
> ZONE_NORMAL
> >   * and ZONE_HIGHMEM.
>
> ioremap() is not a 'key system', so if we are touching it then the
> comment should be fixed in other ways as well.
>
> Thanks,
>
>         Ingo
>

[-- Attachment #2: Type: text/html, Size: 1994 bytes --]