From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B167C52D7C for ; Wed, 21 Aug 2024 17:36:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7DBB6B0121; Wed, 21 Aug 2024 13:36:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2E0C6B0162; Wed, 21 Aug 2024 13:36:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCF036B0163; Wed, 21 Aug 2024 13:36:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AAA996B0121 for ; Wed, 21 Aug 2024 13:36:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 32DFF140F27 for ; Wed, 21 Aug 2024 17:36:48 +0000 (UTC) X-FDA: 82476957696.04.D4AB77B Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by imf22.hostedemail.com (Postfix) with ESMTP id 506BFC0015 for ; Wed, 21 Aug 2024 17:36:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="BJxvh/WH"; spf=pass (imf22.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724261766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VzmV3dq/6WL1tHil16o4FRJDEyqanWxlT+lh/pdRUxA=; b=QIhC1Mf2XHC2SxTLp544Y8jpeJCL3YBq9oq83dJPT2H/Mr9VQ8HsInqdM34hTjnXXo0Np4 ibjYPfVYbSLtYVz9rUFzrSKxIbTL51ERNyU2Q2PnbhoHNccNBri63+d+uLYlnHnwVhdZPD u5pIxhCeby1T58QU4lUwn8IE5qvva10= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="BJxvh/WH"; spf=pass (imf22.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724261766; a=rsa-sha256; cv=none; b=4d27qm6N0gZJpa+S/zuh65xxdjYVSqSSasbAe4i8FtlK+4TitguQvHS6Sr6RgG3OC2eib8 OtAvcO62+Bb805IqEXFY+tK5/oLzpBGOtjEjDpZkD2WEtN4MWqtSV5CvRHJ8zQgsylNXdU gua8qi+vBIYCSWnRsOQvw+pm7E0FiSw= Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-498d7ab8fefso350724137.1 for ; Wed, 21 Aug 2024 10:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724261805; x=1724866605; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VzmV3dq/6WL1tHil16o4FRJDEyqanWxlT+lh/pdRUxA=; b=BJxvh/WHhLbuUBjBPUihd9JsXvaDdfyj+cfYoN7iuZA0pM+E4pbtgQDL0w0fNhe8V8 8wGabrez+oW3YbvoZjXhdLJYTn9Mdxhrq0M7q+gJ8zgSWxFyHzzAMfrwM9XrDhqLsjLP M3Vy9xexaMTws81JhdzQyCQT+qnJ6Jg/SpJcsI3AvuXRtAoaXYewbbMsH3TsquYFqCXA EDK0WuOph49xNn3vv9PJ5/rvgXe0sKOveLzcn78iST4rBOuPCnd2OQJCglRDHMwYCnK9 RiFKGsWPbchbJgJSuDbaveoUx2VNqp0NqgUdlZCY2UrUtIM4A7+4mlx7FNfc9qusr05M tGqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724261805; x=1724866605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VzmV3dq/6WL1tHil16o4FRJDEyqanWxlT+lh/pdRUxA=; b=r/EF+DbG4qEaC9qwXQ7oYSgbYAnVpkpElZ/qvsss7a3XEogJYH800wD01ZgN4rry1Z DHFfAirJZrUlijCBaJ/Oiax7zBlwciX6UXxgAGiSdljKOwhcefKFygAHYM2LR2qFGfNb CsIs862Sq/ah5v3hO7SAnW5bngqv2iXJ1vMyEHQx00yM0BggQzYkhs5mNSZuBFVdT5e9 EPItZxOoJ4fkq6Bc4Ku2BKdqQEb1XAhqzDfdzssWAdQWBkdbJN7WjZw/sndJG4/EV6nR HPowbPXQSuV/zxs4mUctNeA6EPwChh2hdruLy/fHKl4eI6DCzDRBH0swMYyD+Dd9UDuV B7iQ== X-Forwarded-Encrypted: i=1; AJvYcCVaCsVnagyVU6NjYMHreWJdITUBOzftO7TF7gJ7AhbFc1rHrO4gWukBypa8oR0zDmEc2Km1ybmORQ==@kvack.org X-Gm-Message-State: AOJu0Yxmmhr7wlbywtdVaQNBUUgsxnLzDe5Y7hsEc6DJCre5evDHkbEm 6cusT9CA7MxhgBP7GxX7PqHCa4gExyzeOiVvd2z/TnmmgqMFzPKDyG1IWp/cd5G8JGpBBn8flke +6Yoeht8Ao9xvL+gTujLcTR8rNLk= X-Google-Smtp-Source: AGHT+IGZ6NGVAvhIhrLmHVtAEJ3MrzrRe11p5YEwxDxGQJGa5BkvBZS8kr5jvmZ0pUzzyyzH4ZW8NEbARZf733g7LB4= X-Received: by 2002:a05:6102:b13:b0:492:a883:e1d with SMTP id ada2fe7eead31-498d2eab0damr3810936137.11.1724261805127; Wed, 21 Aug 2024 10:36:45 -0700 (PDT) MIME-Version: 1.0 References: <20240817-mseal-depessimize-v3-0-d8d2e037df30@gmail.com> <20240817-mseal-depessimize-v3-7-d8d2e037df30@gmail.com> In-Reply-To: From: Pedro Falcato Date: Wed, 21 Aug 2024 18:36:33 +0100 Message-ID: Subject: Re: [PATCH v3 7/7] selftests/mm: add more mseal traversal tests To: Jeff Xu Cc: Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Shuah Khan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, oliver.sang@intel.com, torvalds@linux-foundation.org, Michael Ellerman , Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 506BFC0015 X-Stat-Signature: omrrkgbop41eph3spf8mo7cuq7m6xf89 X-HE-Tag: 1724261806-417875 X-HE-Meta: U2FsdGVkX19nzojf5kUJXKQEweKgLXm5pIBEpZNtjicz6bdS0sU8wF0wNI4oAZ/rcDaLlDISUvFavO2MAWT7e0cP0GfP/Sbp2SNiyOM+poWzPowGhDci4R55IEQ4PQhQuT/5WvrlXXQOfY6Y7rwlDORCKmPK6z+1GNatxRoYy7t3Y03vhMD2O5eO3X0kad4TGwFoDXPo5eyf2NLmD7VK3dWz9P4AsN7o9tFC0oaqeHr4/TSyE13i2xjuFPZ4qwmFMsYGk8CXzCgGERMxNLyoIiMpUtPOha767jKPIUaN1mVW1pxZuErlh69GD5z6jm5g6rdZcLFH93e1FNRIjjcoYmytpH1+Ka1AAotUHy0dupcULBrQN0AHYkrOvUpZpioqZ59JL7jZEgBd2M6gBxEHKwTlTbxX7h2VdyKpQJ0oFCueMq8LtcNv9tC3+l/aRhxg1guwPRH9TyVLW08W4enw9EZspVgxXhDNyZICCIA4PMnWR4Qc/VVCcGgpMHpVse5FCgUJMdFVHf+lk3KxUbMIAXNJqwo5a0/yz72yJIEDLyVkSQV00UK4DEh9xZAxdDfKqRDFbh2PFEcWcJPB3Jons5tAPIsLTGqMJVVEoswQpA+CiDKdVN6OMLyCgGf1ubxTfqVJNAKBw0Ut2flbzJsIPSSxjMGm/7edxIEPCWVBeG6ez4ZXP9to3pXalEen/UnWgn8z8K2PB0oXnpgD9Hf6qzX9b7udAR63Rxkj3pINuQZmR+pURnrg7F95Wdpl8Z1XzI1xcKRn35rmDDodM1kU4dWUGHp5Pu3hfbMYdUBIqahZ7T5R/L/wG7b1BBo2HSV7z+KfVbD829etEO/3ONGsKzuRenjtE/WGBwkW2cRANDcalPfgKJ3kCR0JPaRb2DjJWEihK0lmTvIkaZjWSHifCOB9S9NcWj8fKIRz0yUXpG+H+LpppQsGZ8W8plTrfcaEN9CcKOe8b9KatCEBVwH ggw83DtO 4RDpEZpBkYrbY6lzWOJ+YQ0Y0GMq9VIdhxgiTEICXzgR2lAf8eJBPVqLqZ+1zFMtEk7rHJAOpF+Q4Ui83a+W9KGeEzv4HfF2zrkX0dyfXVfSjLD+gs8a+mYXtykkfG91WuwhxMiis+B3sNKHh6gZmHuPgljYdwF+JtXFLMaTIUL/WNFepra2JEucBelcJCyoqm1MTPAw7JL8iZfgYJuvPkxBsmlDNoK+OY23dc0RfTJ/4fKME7DjBwTRXuP92f1/divKTTf4ZaeuCHjxc3O3LSoGBSzENewZB7b1ZMC/7UHvi1oc1sQ0i+i6TUnCOnkk7FGviyLVUSD4OANECYCngF2RtINz1+UcC6lwE X-Bogosity: Ham, tests=bogofilter, spamicity=0.001037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 21, 2024 at 6:28=E2=80=AFPM Pedro Falcato wrote: > > ok. Then this test should be as below ? (need to add PROT_NONE page > > before and after) > > size =3D get_vma_size(ptr, &prot); > > FAIL_TEST_IF_FALSE(size =3D=3D 2 * page_size); > > FAIL_TEST_IF_FALSE(prot=3D=3D0x4) > > That doesn't work because this region spans two vmas. I'll write > something similar for the fixup. Actually, I won't because this might cause spurious test failures on e.g !TOPDOWN mmap architectures. setup_single_address (and co) need a fresh coat of paint (wrt PROT_NONE guard regions around it) and I don't want to be the one to do it, at least not as part of this series. --=20 Pedro