From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9B8C4167B for ; Mon, 27 Nov 2023 04:22:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2E846B0315; Sun, 26 Nov 2023 23:22:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDE9E6B0317; Sun, 26 Nov 2023 23:22:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFE306B0315; Sun, 26 Nov 2023 23:22:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE18C6B0315 for ; Sun, 26 Nov 2023 23:22:18 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 903B51201FF for ; Mon, 27 Nov 2023 04:22:18 +0000 (UTC) X-FDA: 81502437156.19.54A03F2 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf10.hostedemail.com (Postfix) with ESMTP id BD94DC0012 for ; Mon, 27 Nov 2023 04:22:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="K/3PtilY"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701058936; a=rsa-sha256; cv=none; b=i6E/Smpdqzbdx9MUp/XhQ6WUl6GD60GZx5DyAq7sMnbv7O6H5CFYtIG7188lT1MzoUP+lQ c6a3ndFrM7bnBUXCzBT7s0w9Jw1henfGPZMUAXyc6rOwisN7XY2khC8fJ66ALfpz/oTp0y s7dJCIZEhF51EM40961dppYWqvlVQYw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="K/3PtilY"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701058936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=49lWzY5XsjADwKty6dy2uWq7Mp+xzIHwxWbgErKH5RI=; b=jct2z4C3hD3cP3VS3rsAQ+7tBxcFSySwCs77iDV68iFxFkHG+NMk3MWL0OP2M9y2HbL2LS vtqJ3/DwG/Sly7k5Jo9MduR7OQwlNCelBWBxkrr+QLnF9ONsNzqfzSX53qURBvxcSq9Wx5 KOBoZNDQQ6dXZv+wcBz8nqzxOOeGbcE= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-54acdd65c88so3563798a12.2 for ; Sun, 26 Nov 2023 20:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701058935; x=1701663735; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=49lWzY5XsjADwKty6dy2uWq7Mp+xzIHwxWbgErKH5RI=; b=K/3PtilYwYsAykrEgrZiNqQgP0Ll7FBMRWMJwXIQto7Vh+y7fmUhS7wHJzOLmrf6sR oflgriVnm80h9Tu/gJzjl5r8qCJz5vP799KlL/0Ez3IQDTje2TMqTJG+Pi680CFGmHT4 D8S5r2jNbQjwh4N4zk95TwA8aeiWLW4vaWpcjRNIGuYNdLAyiGVubjO8E6h6cD0Tg6mh tPzVfSZQ/n7zRUfnNWO0kqjTEU1ZOzCKdMJAqJYcv5lCbaEqDJ/5F3e9dgQdk/+ggNeS zRMxJjvEzJRDVBlI1kls2fcnbj4BhqA3yjzzF6mZbC8UKnK3moiL4wQ3h1vWA7erMdH1 ROKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701058935; x=1701663735; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=49lWzY5XsjADwKty6dy2uWq7Mp+xzIHwxWbgErKH5RI=; b=SXAw3jbQHVgUIg4H25ECcpAOmLlUU12D0tHeDjRBp2jsHbQej1wkrpDoPDs6EC7ab1 ZgrSjQusWSw4MxBmhWQGBaiTwACTA5skdUisTa900/Ho/3f74/1/iU8gPLJkKVFyy6fT wjtJ2ledZQ0bhhHD+GXXdcLhscb4YFdBTlarj8KKKrQ0GgAngwD1JsELi1N7aTRe1exS 6/uDn5cXTp7zvJqc5LBlqWSKLx49qnu54iVuuycSqQyjuMwb5aDRg0YuV3X0FFisJ9ex +AJs60dLx6ecRNccMSTYqkIRhV3WQR3IK06+JQ2oYXidffAiAItVDLVYyAFFZrqgXd9s m+TA== X-Gm-Message-State: AOJu0YyIuiRsH+4iQWq084SMESNgSCc+s/EtiqHnTSxWqHDSI9Jv6UTq 1TCRPpySmDZeJ0bn6i2bj+/DSLBvVlnFhgZArSs= X-Google-Smtp-Source: AGHT+IGYyL89Nx2uLUsND9lmHCFnvT5aiPjbam5lSNpyum8obkASqpsCKEFqC0/TEkUPZB9jAPsBMFyttPDsR+8wSUo= X-Received: by 2002:a17:906:abd5:b0:a10:b3ba:1942 with SMTP id kq21-20020a170906abd500b00a10b3ba1942mr295768ejb.27.1701058935457; Sun, 26 Nov 2023 20:22:15 -0800 (PST) MIME-Version: 1.0 References: <20231124073439.52626-1-liangchen.linux@gmail.com> <20231124073439.52626-3-liangchen.linux@gmail.com> In-Reply-To: From: Liang Chen Date: Mon, 27 Nov 2023 12:22:02 +0800 Message-ID: Subject: Re: [PATCH net-next v3 2/3] page_pool: halve BIAS_MAX for fragment multiple user references To: Yunsheng Lin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org, netdev@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BD94DC0012 X-Stat-Signature: dbqbowaeudq9ptie3pyu8synsnknk4yj X-HE-Tag: 1701058936-259027 X-HE-Meta: U2FsdGVkX198W/7VbOK6CbZU8KpYljaYLtkSGwAzLVQ2vI5tHpl6IuIYPjqImIB3vtajflsOUHcnX9nQbPBE+x6cLRq4kSMoSl1dpiVUYmBOVKHQSoDHcI+PZQTXOe8/DLKHY0cAQoxuT67MCKd2HCZCfPoyQpSPMBdkkbLT4GLXPJIis4eXJBo5+UT/Wqevk1iXPb0cmpdji29YL1+gTcsZrj9kh7LPcTyeI9RXAWGh7cNdTNRMoTmbfSIXe0NqouvXDLSCaF/q5nNZ2H+hKmkAvoACxSHrMiW6sQWVz89Y49g2iA7KIeIv1oo7YCQ0GVSDFs70AUnZJ4eYD5NlJ9shm3TTRkqsBZ3j2kEX2OoZVfJCwq6aVvbqb+I2KS1pHQW2v4XC1cOPgciuMuUsapnz0lfwJ1m5soE7JoiKnHGfrTDyTKo/Rwls7lSFkW7xDeGdI2vzfE40rakSQRmv6ZYEiUMvAij3VhgxK3QhmPCwN4tLd8XZaHIjsqjK7ia8IGwDH0Jf7OggFHXNIomo7DWuu+q4+lrNs8Y7NOIp7zJijEFSIYv5HEj+fTmimN2BUFP8/nHQ3egduRznboFlzIoI03vupjjqXUCWZNS6X8WNfx2ZLHC3wu9MrdTYmXIRSkHF5iqyIlxR9bVlpuMFLHuxKvdfajf30bkh4rpEkSOT3gzXLg+DbGa0S08acXT8CBy+Dr5J4KO1Q/tFf61ze8XGfZf61cO8zUhK4NwWElAQzE3qqctgxOBbqF7cDmDFq8M34FvzG/apfqVbl5YOLVFyZP8MGmMhpgBSt6jaU/Zi211SoZZrMdJdWBV/DVlLkL29J0IcgxxBYiiWXMy8FgDQcxzB+tLwR09NYqTCU/XdnS7aexNUgazTTgJ5hdjGUrBQVI3nMWsXr/SvU+WzIV9dqEu8R5jHIojHS/WrV3GpxyjoAOn6fMLDHwLNNAClMcB/t0vyQHSMKXAiVwq 9ApyaxBV G7NmDx1AUFb7/4ILiuv2eE2+jvW0nS+ya0oW7wiFzUrfGd7y+ADwOxKKahZZoB1gD8qnPj89xisCpGptJvDnOKrefhUv0jn5u8An+YsWZDP2UxhrjRzHYXMt6PnE0bki5x6nT9xgQ5+J/Jh9xTtKMx7+vrIWCRHuLUi2W1X1FYMExwYRqFEWfNQx+Ua/O6668Oakwoe9RzNQNiPPHlJsYWOl+8QBCH/UWdcRD68BjCjY0PDDOwzbPK+3fokw0n6XwnrcB6o8umd1eyBExjNH3e5+200QKhxFzWU51wo5cjrmzY9/gcdpwAA94J1CaB4WFDW+2SbtDZaSw8ioEmsss1AWB+78L9+dmSi4uQ3F0ZXx9O6z99aIIy5VxgzUTN+UdZ+Utr+TuY/djRgfoyLRL+N7AvOiYX4zXB2qOciuUKeVP8fIKdm6mQH623UrGQ1HeDCqP X-Bogosity: Ham, tests=bogofilter, spamicity=0.126642, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 25, 2023 at 8:01=E2=80=AFPM Yunsheng Lin wrote: > > On 2023/11/24 15:34, Liang Chen wrote: > > The title seems a little hard for me to understand, but the description > below does seem clear to me, so LGTM. > > Reviewed-by: Yunsheng Lin > Thanks! I will change the title to "halve BIAS_MAX for multiple user references of a fragment" > > Referring to patch [1], in order to support multiple users referencing = the > > same fragment and prevent overflow from pp_ref_count growing, the initi= al > > value of pp_ref_count is halved, leaving room for pp_ref_count to incre= ment > > before the page is drained.