From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 978A0C6379D for ; Mon, 23 Nov 2020 18:44:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FFFE20702 for ; Mon, 23 Nov 2020 18:44:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="szQM99MU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FFFE20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7A3086B006E; Mon, 23 Nov 2020 13:44:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 751B16B0070; Mon, 23 Nov 2020 13:44:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 668D56B0072; Mon, 23 Nov 2020 13:44:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 3A57A6B006E for ; Mon, 23 Nov 2020 13:44:10 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E16598249980 for ; Mon, 23 Nov 2020 18:44:09 +0000 (UTC) X-FDA: 77516557818.23.slope13_58174f627367 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id C451437604 for ; Mon, 23 Nov 2020 18:44:09 +0000 (UTC) X-HE-Tag: slope13_58174f627367 X-Filterd-Recvd-Size: 6260 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Nov 2020 18:44:09 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id j19so15062536pgg.5 for ; Mon, 23 Nov 2020 10:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BWpJZTEbYYqdTndkJGPxB+inYZkPNeNKjK+AcWxClLU=; b=szQM99MUWB2Wyul7qI32qwELH8rheFKKRFflNwGL7g4nXUIC5bTWgygJQzT0i/fHHD +g3epirl+0GuU3lZ74ypvWJeJazqafDOMzGurj+nkGrGvHqZ/+k+0srsVKsL4FsddWW9 Qg6XfRAmi+lWJkaOuZTtNRMcKgV/mbhjPqQ17XPq/MA2JxbU3dfJB1KOEsdYtFbfGhDD 8w+Wo6JTUuVMLyV2aRdA8Bg3DNapR4F31XhD9143jJ0mHWeU0t296sJCVMYNU3UwKtz7 /8Dx4VTrt6uv4+cn4nJtFHn6zQqmdeoXbVzL4JOvEUXY0pEgPk0Y8/Qq9g9mZBadSOE2 7LFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BWpJZTEbYYqdTndkJGPxB+inYZkPNeNKjK+AcWxClLU=; b=qWMXl3SRI29NTZdmANWnVnQlxDBBJWqB8xpd9/NrrZpU09v0uxjk4gWw0FOEIBsS3m r9++/WCVEAPd3WdxxINGgiZPaiR7cLmPrUrfo9e+9OhQKTPmmQkpm9Snr46jL6i07kFR p3yzlua++kFRyFc2CPo9GxO/EnYGLyszYZjGD+y6nGSCyLMjJjj5seOa27xNXajwJ7xj uGMJcm7FuEJyP4XWKb8jaTwt5pWDm3219iaGuKtJ+yCIkqZEyScyETIBP7uaxTjRMn8q wMLhmcTXJKsLgM7d53csH+HTA+jUfZpzKXAv+vrbpQnq941IIIKCYOcr8t46aHEzykFo D+fQ== X-Gm-Message-State: AOAM531p2u5Qn8O+iBYzXjWf1lYYr1P5Y29LuA7s1btpOLEKSPbrRQfX MmyT3nICbZdxlpOL9e+CwNMo1LY0bEkBmNZgO25cmg== X-Google-Smtp-Source: ABdhPJzV7WgvUGjMsCL5eGYFxkRo9Z74P6af+WKqtJyjDvYYktlRIpjd8mQJ7obwSmcgVAT6r6NWwRH0BBh0hokJBAw= X-Received: by 2002:a17:90a:d250:: with SMTP id o16mr262028pjw.25.1606157047928; Mon, 23 Nov 2020 10:44:07 -0800 (PST) MIME-Version: 1.0 References: <202011220213.McOuf9IB-lkp@intel.com> In-Reply-To: <202011220213.McOuf9IB-lkp@intel.com> From: Nick Desaulniers Date: Mon, 23 Nov 2020 10:43:56 -0800 Message-ID: Subject: Re: arch/riscv/include/asm/vdso/processor.h:14:2: error: implicit declaration of function 'barrier' To: kernel test robot Cc: Arvind Sankar , kbuild-all@lists.01.org, LKML , Randy Dunlap , Andrew Morton , Linux Memory Management List , Kees Cook Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Randy's fix got picked up: https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=fixes&id=f52c08ea5fc8e2057a5913b1f6bfd534e1fb7e4c We're going to need to ensure that this gets backported to stable along with commit: 3347acc6fcd4ee71ad18a9ff9d9dac176b517329 compiler.h: fix barrier_data() on clang On Sat, Nov 21, 2020 at 10:39 AM kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 27bba9c532a8d21050b94224ffd310ad0058c353 > commit: 3347acc6fcd4ee71ad18a9ff9d9dac176b517329 compiler.h: fix barrier_data() on clang > date: 7 days ago > config: riscv-randconfig-r003-20201121 (attached as .config) > compiler: riscv32-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3347acc6fcd4ee71ad18a9ff9d9dac176b517329 > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > git fetch --no-tags linus master > git checkout 3347acc6fcd4ee71ad18a9ff9d9dac176b517329 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from include/vdso/processor.h:10, > from arch/riscv/include/asm/processor.h:11, > from include/linux/prefetch.h:15, > from drivers/net/ethernet/intel/ixgb/ixgb_main.c:6: > arch/riscv/include/asm/vdso/processor.h: In function 'cpu_relax': > >> arch/riscv/include/asm/vdso/processor.h:14:2: error: implicit declaration of function 'barrier' [-Werror=implicit-function-declaration] > 14 | barrier(); > | ^~~~~~~ > cc1: some warnings being treated as errors > > vim +/barrier +14 arch/riscv/include/asm/vdso/processor.h > > ad5d1122b82fbd6 Vincent Chen 2020-06-09 6 > ad5d1122b82fbd6 Vincent Chen 2020-06-09 7 static inline void cpu_relax(void) > ad5d1122b82fbd6 Vincent Chen 2020-06-09 8 { > ad5d1122b82fbd6 Vincent Chen 2020-06-09 9 #ifdef __riscv_muldiv > ad5d1122b82fbd6 Vincent Chen 2020-06-09 10 int dummy; > ad5d1122b82fbd6 Vincent Chen 2020-06-09 11 /* In lieu of a halt instruction, induce a long-latency stall. */ > ad5d1122b82fbd6 Vincent Chen 2020-06-09 12 __asm__ __volatile__ ("div %0, %0, zero" : "=r" (dummy)); > ad5d1122b82fbd6 Vincent Chen 2020-06-09 13 #endif > ad5d1122b82fbd6 Vincent Chen 2020-06-09 @14 barrier(); > ad5d1122b82fbd6 Vincent Chen 2020-06-09 15 } > ad5d1122b82fbd6 Vincent Chen 2020-06-09 16 > > :::::: The code at line 14 was first introduced by commit > :::::: ad5d1122b82fbd6a816d1b9d26ee01a6dbc2d757 riscv: use vDSO common flow to reduce the latency of the time-related functions > > :::::: TO: Vincent Chen > :::::: CC: Palmer Dabbelt > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Thanks, ~Nick Desaulniers