From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E541C433E0 for ; Tue, 16 Mar 2021 18:01:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4F3365127 for ; Tue, 16 Mar 2021 18:01:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4F3365127 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5E2376B006C; Tue, 16 Mar 2021 14:01:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8856B0070; Tue, 16 Mar 2021 14:01:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 480686B0071; Tue, 16 Mar 2021 14:01:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 2E8706B006C for ; Tue, 16 Mar 2021 14:01:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C00536D89 for ; Tue, 16 Mar 2021 18:01:48 +0000 (UTC) X-FDA: 77926505496.11.D2A80F3 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf26.hostedemail.com (Postfix) with ESMTP id 508214080F6D for ; Tue, 16 Mar 2021 18:01:43 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id s17so21677557ljc.5 for ; Tue, 16 Mar 2021 11:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wBDcxnmnlcdmGNIzAX9LfTHLUlQAJdWJ9myTmotHrI4=; b=f9LBS+K0WNsomlx8fjcuF9nm4FhTtT/JNtnRxNvXnRUnt+CHQD47qxSrxFKf1sKuuh SrvV6anjfLUaUg4sBpUAqyk/ShuO7R8vZnHODa58AR5pZIhLZhKt4+Mm3gJ7r/EX8eSK 9RByvVNrw7wDysImHeeqInO9GGJ+9HX9giQnTgpHh75NcQAESI0Gst6iIILMC9TFtYrJ vyq5/vf4QNRhzNtSvp8e2Kt3W4TpqfWqXj0Y1xKLd5CfHuaXE0n9odi70O0itAFO+3P1 5oWb/0fuV0bpGVKA7RtwNlOktmYNkvYr0Q/1apNZ4+HdV9dW0mQ/XDFvR4rrYOOpXsBB 75cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wBDcxnmnlcdmGNIzAX9LfTHLUlQAJdWJ9myTmotHrI4=; b=dmt4CdsJeG7CXlBGefVez4enFjkZtEwOOC5r/91kaOzYNJ1XYJFoghMrtnn2P55oLi iZsY6c0glWesbYrD3iyFWotHQItG/afQGW2Urq01ZLsSWYqpNlW+QbeX1DGWPzZQKG1n 0Hco8Z59W8y95TfVdS4MLVcXqe0JaVx4L8+uoe+6O3cyAmBRZfd+BlqyTPv8tobUsIgZ xZxObaKApB4HHWCK9mHizUiN4v99/sWWQsg7cmpORq4vOtYlo37GOGFUFo17y8+FDOya EbeqWqfMdrLNP40ruQaL9h+EmeENDekvO19rEcjKFO7i+Hok+cBWuV5Ca6Pi7MjLee0z pibQ== X-Gm-Message-State: AOAM531wa2mj/3HUrovVUTEBg43JwSJP58fFk3P23sKL/FM7hTO7o/V8 /TEqTcsyd1kH9rhXhbgqFepK9auYewlfijJWFsPBqw== X-Google-Smtp-Source: ABdhPJw82JldT5/m8o79tV/4+uSZJd9u12QWonMBRW9Vb4pH41u1t2LMv2moA8UqvsPAS9U2tGFCDwAJ/nvlLbVoGqA= X-Received: by 2002:a2e:9a4e:: with SMTP id k14mr3505791ljj.116.1615917695303; Tue, 16 Mar 2021 11:01:35 -0700 (PDT) MIME-Version: 1.0 References: <20210316171347.14084-1-rppt@kernel.org> In-Reply-To: <20210316171347.14084-1-rppt@kernel.org> From: Nick Desaulniers Date: Tue, 16 Mar 2021 11:01:24 -0700 Message-ID: Subject: Re: [PATCH] memblock: fix section mismatch warning again To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , David Hildenbrand , Mike Rapoport , clang-built-linux , kbuild-all@lists.01.org, LKML , Linux Memory Management List , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 508214080F6D X-Stat-Signature: 9e75t4n76boijij67bdno9i3xg9szxam Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-lj1-f169.google.com; client-ip=209.85.208.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615917703-702320 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 16, 2021 at 10:13 AM Mike Rapoport wrote: > > From: Mike Rapoport > > Commit 34dc2efb39a2 ("memblock: fix section mismatch warning") marked > memblock_bottom_up() and memblock_set_bottom_up() as __init, but they could > be referenced from non-init functions like memblock_find_in_range_node() on > architectures that enable CONFIG_ARCH_KEEP_MEMBLOCK. > > For such builds kernel test robot reports: > All warnings (new ones prefixed by >>, old ones prefixed by <<): > > >> WARNING: modpost: vmlinux.o(.text+0x74fea4): Section mismatch in reference from the function memblock_find_in_range_node() to the function .init.text:memblock_bottom_up() > The function memblock_find_in_range_node() references > the function __init memblock_bottom_up(). > This is often because memblock_find_in_range_node lacks a __init > annotation or the annotation of memblock_bottom_up is wrong. > > Replace __init annotations with __init_memblock annotations so that the > appropriate section will be selected depending on > CONFIG_ARCH_KEEP_MEMBLOCK. > > Link: https://lore.kernel.org/lkml/202103160133.UzhgY0wt-lkp@intel.com > Fixes: 34dc2efb39a2 ("memblock: fix section mismatch warning") > Signed-off-by: Mike Rapoport > Reported-by: kernel test robot > Reviewed-by: Arnd Bergmann Thank you Mike. Acked-by: Nick Desaulniers > --- > > @Andrew, please let me know if you'd prefer this merged via memblock tree. > > include/linux/memblock.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index d13e3cd938b4..5984fff3f175 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -460,7 +460,7 @@ static inline void memblock_free_late(phys_addr_t base, phys_addr_t size) > /* > * Set the allocation direction to bottom-up or top-down. > */ > -static inline __init void memblock_set_bottom_up(bool enable) > +static inline __init_memblock void memblock_set_bottom_up(bool enable) > { > memblock.bottom_up = enable; > } > @@ -470,7 +470,7 @@ static inline __init void memblock_set_bottom_up(bool enable) > * if this is true, that said, memblock will allocate memory > * in bottom-up direction. > */ > -static inline __init bool memblock_bottom_up(void) > +static inline __init_memblock bool memblock_bottom_up(void) > { > return memblock.bottom_up; > } > -- > 2.28.0 > -- Thanks, ~Nick Desaulniers