From: Andy Lutomirski <luto@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Christopher Lameter <cl@linux.com>,
kernel test robot <xiaolong.ye@intel.com>,
Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Jiri Slaby <jslaby@suse.cz>,
Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>, LKP <lkp@01.org>,
linux-mm <linux-mm@kvack.org>, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Megha Dey <megha.dey@linux.intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [lkp-robot] [x86/kconfig] 81d3871900: BUG:unable_to_handle_kernel
Date: Fri, 13 Oct 2017 13:01:59 -0700 [thread overview]
Message-ID: <CALCETrV91zeKc__be4otCp_68HYjwobTEPpTEcu69-1FBQBHww@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFyvK+proOBKfc41qSH8hoPU+mBiT0=hLhbt_ZQv4N82iA@mail.gmail.com>
On Fri, Oct 13, 2017 at 12:09 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Oct 13, 2017 at 6:56 AM, Andrey Ryabinin
> <aryabinin@virtuozzo.com> wrote:
>>
>> This could be fixed by s/vmovdqa/vmovdqu change like bellow, but maybe the right fix
>> would be to align the data properly?
>
> I suspect anything that has the SHA extensions should also do
> unaligned loads efficiently. The whole "aligned only" model is broken.
> It's just doing two loads from the state pointer, there's likely no
> point in trying to align it.
>
> So your patch looks fine, but maybe somebody could add the required
> alignment to the sha256 context allocation (which I don't know where
> it is).
IIRC if we try the latter, then we'll risk hitting the #*!&@% gcc bug
that mostly prevents 16-byte alignment from working on GCC before 4.8
or so. That way lies debugging disasters.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-13 20:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171010121513.GC5445@yexl-desktop>
2017-10-11 2:31 ` [lkp-robot] [x86/kconfig] 81d3871900: BUG:unable_to_handle_kernel Josh Poimboeuf
2017-10-11 17:01 ` Josh Poimboeuf
2017-10-12 17:05 ` Christopher Lameter
2017-10-12 17:54 ` Linus Torvalds
2017-10-12 17:54 ` Linus Torvalds
2017-10-12 18:48 ` Andrew Morton
2017-10-12 19:19 ` Geert Uytterhoeven
2017-10-13 4:45 ` Josh Poimboeuf
2017-10-13 13:56 ` Andrey Ryabinin
2017-10-13 16:19 ` Josh Poimboeuf
2017-10-13 19:09 ` Linus Torvalds
2017-10-13 20:01 ` Andy Lutomirski [this message]
2017-10-13 20:17 ` Jeffrey Walton
2017-10-13 15:22 ` Christopher Lameter
2017-10-13 15:37 ` Josh Poimboeuf
2017-10-17 7:33 ` Joonsoo Kim
2017-10-17 7:50 ` Thomas Gleixner
2017-10-18 7:31 ` Joonsoo Kim
2017-10-18 10:40 ` Linus Torvalds
2017-10-18 13:15 ` Thomas Gleixner
2017-10-19 2:14 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrV91zeKc__be4otCp_68HYjwobTEPpTEcu69-1FBQBHww@mail.gmail.com \
--to=luto@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=efault@gmx.de \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@01.org \
--cc=megha.dey@linux.intel.com \
--cc=mingo@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).