From: Andy Lutomirski <luto@amacapital.net>
To: David Rientjes <rientjes@google.com>
Cc: Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: hugetlb oops on 3.1.0-rc8-devel
Date: Tue, 6 Dec 2011 12:43:34 -0800 [thread overview]
Message-ID: <CALCETrW77ZE62dbHJxoL3Ef1gAGeMQaSZrOOiM1_ZrY53zbxUQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112061214590.28251@chino.kir.corp.google.com>
On Tue, Dec 6, 2011 at 12:16 PM, David Rientjes <rientjes@google.com> wrote:
> On Wed, 2 Nov 2011, Andy Lutomirski wrote:
>
>> > --- a/mm/hugetlb.c Sat Aug 13 11:45:14 2011
>> > +++ b/mm/hugetlb.c Wed Nov 2 20:12:00 2011
>> > @@ -2422,6 +2422,8 @@ retry_avoidcopy:
>> > * anon_vma prepared.
>> > */
>> > if (unlikely(anon_vma_prepare(vma))) {
>> > + page_cache_release(new_page);
>> > + page_cache_release(old_page);
>> > /* Caller expects lock to be held */
>> > spin_lock(&mm->page_table_lock);
>> > return VM_FAULT_OOM;
>> >
>>
>> I'll patch it in. My test case took over a week to hit it once, so I
>> can't guarantee I'll spot it.
>>
>
> This patch was merged and released in 3.2-rc3 as ea4039a34c4c ("hugetlb:
> release pages in the error path of hugetlb_cow()"), Andy is this issue
> fixed for you?
I haven't seen it again with or without the patch. I suspect that to
trigger it again I'd have to set up an old, buggy version of my
software to hammer on it for awhile, which I won't have a chance to do
any time soon. Sorry.
If you're interested, the workload that triggered the problem was,
roughly, two programs. Both were set up to use libhugetlbfs for
everything, and the first program spawned (presumably via fork as
opposed to any clone magic) copies of the second program frequently.
The second program was very memory intensive. The result was that,
occasionally, fork had issues because it couldn't find free huge pages
in the pool.
--Andy
--
Andy Lutomirski
AMA Capital Management, LLC
Office: (310) 553-5322
Mobile: (650) 906-0647
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-12-06 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 22:20 hugetlb oops on 3.1.0-rc8-devel Andy Lutomirski
2011-11-02 12:06 ` Hillf Danton
2011-11-02 17:18 ` Andy Lutomirski
2011-12-06 20:16 ` David Rientjes
2011-12-06 20:43 ` Andy Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrW77ZE62dbHJxoL3Ef1gAGeMQaSZrOOiM1_ZrY53zbxUQ@mail.gmail.com \
--to=luto@amacapital.net \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).