From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA665C83F1A for ; Fri, 11 Jul 2025 01:07:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5046B009D; Thu, 10 Jul 2025 21:07:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67E3A6B009E; Thu, 10 Jul 2025 21:07:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BA386B00A0; Thu, 10 Jul 2025 21:07:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4CDC26B009D for ; Thu, 10 Jul 2025 21:07:28 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C9770BE803 for ; Fri, 11 Jul 2025 01:07:27 +0000 (UTC) X-FDA: 83650195734.30.4203438 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf10.hostedemail.com (Postfix) with ESMTP id CB88DC000F for ; Fri, 11 Jul 2025 01:07:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=Rr4ITBeo; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf10.hostedemail.com: domain of cachen@purestorage.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=cachen@purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752196046; a=rsa-sha256; cv=none; b=AMX71j0hnQeTXGqIb9K4B10mDMWpHgaJbvqbpzU5ec1V8a8aK5GhoRE7oKiYdWr37YZr6o EvXyTFDRL3egfoF2MiO8knxwRFEqe5MADUJQSnYErBqMPhSYKVagIHVHSHqslSr62sKpKw ksQlAomBigWK2Uhk1GZcxSmIyfUK1o4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=Rr4ITBeo; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf10.hostedemail.com: domain of cachen@purestorage.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=cachen@purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752196046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pTpOdXsMQLzrcYHow8zySMbXm3VVzD+3w6bdwbkL+9A=; b=6T0Psvj/dcEqAEBe/PEkbAC9IVYzJKwwDsLxSfzSWyaOmmC4upKeLSHnYnDfceX2OkfuKx nWOiH5SoGa7PYoK47Yt64j/eSG/sFT13nBEaMVJxfadtLTSaOeGpUWjpBL6OTCrj+EsHQQ czKT92Y0IotLyJBFAPShEn/ckNRW9Pk= Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-313756c602fso242964a91.3 for ; Thu, 10 Jul 2025 18:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1752196044; x=1752800844; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pTpOdXsMQLzrcYHow8zySMbXm3VVzD+3w6bdwbkL+9A=; b=Rr4ITBeovR5F25dVYwfOaN4ZeW+VQa55jjLP2IAQ9auHUN/wxw6RzGrhdnNe4odldz btalIO1ocrQuACR3RD0vGppKLy5bX8mPhMgyU9l8T9I5HgUZ+vyKSCcxKm33dHYxHyEt 6RZaj4Ov27lVu9YNaR5Q4FE+7RkI1CQaMU0gs3FbCxma/EGVt8rgNi5kiS9Qri40L1g6 imbuR75bZCmuSKKN9rBPs6kViUmRssbvdBx/mbhkVaZEGmm/tCoAmj7TH0n9ibtBRNZW wU8iHG2sMWgBE26uQAOWHXVoXNbSe9XM2BrGKhFqT7kLAQHNAepf4iuHxESl6XygqHlK RaxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752196044; x=1752800844; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pTpOdXsMQLzrcYHow8zySMbXm3VVzD+3w6bdwbkL+9A=; b=RmQrHONnmyM5kCH1JdifKMxg/OBC4zXWZAQ9s9fuoLPZU4panV4svn3mI9Dj85h9Sv ds//30bCr5Qod//DfrEFFxW8HqOJa+mZUuTLOdwxNT17bfbQCyJuJvBHjMPQyGhpGo58 ABobCH8ZgwDQHUxzuuFMg3gW8SsNlupwUF2cOAmcVQWpx/5BdELKukOnBZBSk0xBTFuR dLShSqaMms7OOCO59oj04JQN2YdTrFTpjSxvd+1ufBOI6CQ4sdxv6ph1hgz04Icy66VK Kp/Oofu+2lqqfEZNnmebel99TZ+wKMuTlvWr/h9hRdG9xfRLT8Yo9wqkjNnqQjKcdjT4 PmXw== X-Forwarded-Encrypted: i=1; AJvYcCVU8qk1/+I1muFD4IPDuUzp4hbrYrxzt6DbFUBy1yfLkDiNnX4wgpeGDIr7GewEs7Ihp/LV3c4HSw==@kvack.org X-Gm-Message-State: AOJu0Yzmy4KeWNT0sDFyVCj/a+9bw+Lxb0clCbxZ324Xdjie7zPU45h5 OnffnBHohDAxFj+oF+y3cCrYJuuI/41WNU88sSkDDDGsVDyRha4lQPupg76BbFMsul+FWa0sM4Y Lskc/rA/Ab6Am6pzA6J/lkp1Heqkb5FuMsSQhPea7KA== X-Gm-Gg: ASbGncvueov4EvtRwwF16c1/EVmLxFzKNzJUtTLN569w2FE4+/RPmXZxarKLvK/mdPS MTte4f4by/mwONQ3eojrrJ7e8d1XkdUk/BKCDGGLO2ezKKQJo/uiNKS7TJcind9hMLlMh2eoOON pxvH08Y8qoG6SPRWGKXgxfpSjdwLUhpzQnPSsULWJEWpbqbXxsO2xlU1TsoML9PYA/HwheBn2GA czPumM= X-Google-Smtp-Source: AGHT+IG152UMqrIIRd2Xd90YPDSf5pEnbfvoOgqoYDrpOcF3WJk5ojY35gB4oWHE2yxNeXBAd3hQBEsb+k4GAvmvpHo= X-Received: by 2002:a17:90b:2711:b0:311:9c9a:58e2 with SMTP id 98e67ed59e1d1-31c4f563077mr309964a91.7.1752196044222; Thu, 10 Jul 2025 18:07:24 -0700 (PDT) MIME-Version: 1.0 References: <20250711002322.1303421-1-cachen@purestorage.com> In-Reply-To: From: Casey Chen Date: Thu, 10 Jul 2025 18:07:13 -0700 X-Gm-Features: Ac12FXw6y-q8rSNhM9jBT1X4xydypPX-JJoJktrjXOfl29h8h5Mx4Q3MEQyzFt0 Message-ID: Subject: Re: [PATCH v3] alloc_tag: add per-NUMA node stats To: Kent Overstreet Cc: akpm@linux-foundation.org, surenb@google.com, corbet@lwn.net, dennis@kernel.org, tj@kernel.org, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, rientjes@google.com, roman.gushchin@linux.dev, harry.yoo@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, yzhong@purestorage.com, souravpanda@google.com, 00107082@163.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: c8sgaoqtb83ouzwedmzbr4ww6jqw493w X-Rspamd-Queue-Id: CB88DC000F X-HE-Tag: 1752196045-759172 X-HE-Meta: U2FsdGVkX19tN8qMs7UmLklx/QByKMhMPGw0xWdfm/qe2L6G/aqekaGYFzAl9eEiSOsquYLNkG4FKkxJ2vgcJ2gfFhngNPzp7KGovxscyk0GZ5mwpMMK5Qnv4iC7kKIdAXIlBJ+3ZSHuwdH/hkPoFOC8zALwR/yiJxJCptSIWNO83/yBcuV6AZZSjOnkJGseGqLQEuEgHohmaFn/WTTxEl/D1ID1OZ7gFCoVqh6L+beNYa38forq9h7I5ZGcbnMoBs2U0O1r6NUTwppwVAcjI89QMBqCBbA2cnusfNvQorA9JRob4Ks1o2cohNv9nBQOIA6+/d0WcGMRU0YmQTst/5H9+vye0xHV9VSLuKkr6uvk4tdUfjPRe5A7YAaYEYYOuFHfJDOreyrpVRB3PblEtJujTgKSdwjLKI+c+RTnzCN1pR6LHVwNEXqhqAr5qsxndn+X0iNKnto/KECFFXZjDOo1QXzpeTESc8tNaQiUOxkr85PoZpCRMaexNH239lD01+Zky3TkAcpk6T9hcQLjLt1/rbu3QTufE//toUoh8nnEgGe0Y3Jd2i7bbinDAz3hTC+t5GwZzZEpjD4+uQqqSgeJ9giFD/vF2sYDRaUeE9rWIGdxVWF0ADzezD5rxXCHHqQWQZ1j3V/iAkOQJE9Jx2RoZrsh2MijHCVXpkddhzK++GbFEAIinYveiFt5Vb7vlsuFGbQPmqLFsfVdfU9lLPuzkyU3+5NnAJHsyYm9mebGgYAtssv7hhDqhndZNVEt8GEKyojSO1Ahz0Euf7th1yhO44MmjcYFnmaAwu/j+SJB39EfEJD4uLh6P5IsQYi/vFz7sgQPK9jtZcoEddRuPg6nJ/ek3VPGh4HtXWewLLCmBfWtNshnxWRU5AkttYnMH3+SpZ+PoQavOF/6bpJtg0quT30qrdr8UFdvaqzCtNZ+maFvCPi4BF5H6pojj0baQeLYe7mrLdik75tKqIZ U3jFjm63 ctIKnkzz6dL/bFut1hs0rN3baHwJChdK++SBlCei7DS3pCc7AfsCOYsXN4g/8n/ASVrXulopgbOFaRrX2U6zoSNTHsZKZIVkyG5GSe1zw/Uq3J7wGn2vZqGeMvEepofXWeTRs5lNAKWun6OFpGiesJpVO3EGl0N2mldn6NRAvhRq6jN9MMtY8wNKMplnZ1sNTaQtMmEj4CBFaQI+XnOs6KPtmGAgec56gT8Tz2yBofzRYQ0i+zIbZ/n0nluj0Lo9UApCJlvLcAkK0EY+nbO83cb/vDQF0aEZgEQs1cvn+Wwe9mIr52kZ3QFE/IQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 5:54=E2=80=AFPM Kent Overstreet wrote: > > On Thu, Jul 10, 2025 at 05:42:05PM -0700, Casey Chen wrote: > > Hi All, > > > > Thanks for reviewing my previous patches. I am replying some comments > > in our previous discussion > > https://lore.kernel.org/all/CAJuCfpHhSUhxer-6MP3503w6520YLfgBTGp7Q9Qm9k= gN4TNsfw@mail.gmail.com/T/#u > > > > Most people care about the motivations and usages of this feature. > > Internally, we used to have systems having asymmetric memory to NUMA > > nodes. Node 0 uses a lot of memory but node 1 is pretty empty. > > Requests to allocate memory on node 0 always fail. With this patch, we > > can find the imbalance and optimize the memory usage. Also, David > > Rientjes and Sourav Panda provide their scenarios in which this patch > > would be very useful. It is easy to turn on an off so I think it is > > nice to have, enabling more scenarios in the future. > > > > Andrew / Kent, > > * I agree with Kent on using for_each_possible_cpu rather than > > for_each_online_cpu, considering CPU online/offline. > > * When failing to allocate counters for in-kernel alloc_tag, panic() > > is better than WARN(), eventually the kernel would panic at invalid > > memory access. > > * percpu stats would bloat data structures quite a bit. > > > > David Wang, > > I don't really understand what is 'granularity of calling sites'. If > > NUMA imbalance is found, the calling site could request memory > > allocation from different nodes. Other factors can affect NUMA > > balance, those information can be implemented in a different patch. > > Let's get this functionality in. > > We've already got userspace parsing and consuming /proc/allocinfo, so we > just need to do it without changing that format. You mean keep the format without per-NUMA info the same as before ? My patch v3 changed the header and the alignment of bytes and calls. I can restore them back. - seq_buf_printf(buf, "# \n"); + seq_buf_printf(buf, " \n"); - seq_buf_printf(out, "%12lli %8llu ", bytes, counter.calls); + seq_buf_printf(out, "%-12lli %-8llu ", bytes, counter.calls);