From: Ezequiel Garcia <elezegarcia@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
Glauber Costa <glommer@parallels.com>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH] mm, slob: Drop usage of page->private for storing page-sized allocations
Date: Mon, 3 Sep 2012 18:13:10 -0300 [thread overview]
Message-ID: <CALF0-+VOLiFmh=pLArm9LUtBOZtzqYSMxRS_Qb7t9Zv8ur61mQ@mail.gmail.com> (raw)
In-Reply-To: <CAOJsxLG3DVocuakT91vmgKWFME94PL9_XAqGM_=jru-Tbg4oPw@mail.gmail.com>
Hi Pekka,
On Wed, Aug 15, 2012 at 8:43 AM, Pekka Enberg <penberg@kernel.org> wrote:
> On Tue, Aug 14, 2012 at 11:03 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>> This field was being used to store size allocation so it could be
>> retrieved by ksize(). However, it is a bad practice to not mark a page
>> as a slab page and then use fields for special purposes.
>> There is no need to store the allocated size and
>> ksize() can simply return PAGE_SIZE << compound_order(page).
>>
>> Cc: Pekka Enberg <penberg@kernel.org>
>> Cc: Christoph Lameter <cl@linux.com>
>> Cc: Glauber Costa <glommer@parallels.com>
>> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
>
> Looks good to me. Matt?
>
Will you carry this (and the other 3 patches I sent for mm/) on your tree?
Or do I need to send them to someone else?
Thanks,
Ezequiel.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-03 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 20:03 [PATCH] mm, slob: Drop usage of page->private for storing page-sized allocations Ezequiel Garcia
2012-08-14 20:53 ` Christoph Lameter
2012-08-15 11:38 ` Ezequiel Garcia
2012-08-15 11:42 ` Pekka Enberg
2012-08-15 11:45 ` Ezequiel Garcia
2012-08-15 14:04 ` Christoph Lameter
2012-08-15 11:43 ` Pekka Enberg
2012-09-03 21:13 ` Ezequiel Garcia [this message]
2012-09-04 7:28 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALF0-+VOLiFmh=pLArm9LUtBOZtzqYSMxRS_Qb7t9Zv8ur61mQ@mail.gmail.com' \
--to=elezegarcia@gmail.com \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).