From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx133.postini.com [74.125.245.133]) by kanga.kvack.org (Postfix) with SMTP id 242346B005D for ; Mon, 3 Sep 2012 17:13:11 -0400 (EDT) Received: by iec9 with SMTP id 9so4994688iec.14 for ; Mon, 03 Sep 2012 14:13:10 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1344974585-9701-1-git-send-email-elezegarcia@gmail.com> Date: Mon, 3 Sep 2012 18:13:10 -0300 Message-ID: Subject: Re: [PATCH] mm, slob: Drop usage of page->private for storing page-sized allocations From: Ezequiel Garcia Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: linux-mm@kvack.org, Christoph Lameter , Glauber Costa , Matt Mackall Hi Pekka, On Wed, Aug 15, 2012 at 8:43 AM, Pekka Enberg wrote: > On Tue, Aug 14, 2012 at 11:03 PM, Ezequiel Garcia wrote: >> This field was being used to store size allocation so it could be >> retrieved by ksize(). However, it is a bad practice to not mark a page >> as a slab page and then use fields for special purposes. >> There is no need to store the allocated size and >> ksize() can simply return PAGE_SIZE << compound_order(page). >> >> Cc: Pekka Enberg >> Cc: Christoph Lameter >> Cc: Glauber Costa >> Signed-off-by: Ezequiel Garcia > > Looks good to me. Matt? > Will you carry this (and the other 3 patches I sent for mm/) on your tree? Or do I need to send them to someone else? Thanks, Ezequiel. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org