From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F9AC433EF for ; Thu, 9 Dec 2021 02:43:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A775B6B0071; Wed, 8 Dec 2021 21:43:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A26156B0073; Wed, 8 Dec 2021 21:43:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C7816B0074; Wed, 8 Dec 2021 21:43:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 7AEA26B0071 for ; Wed, 8 Dec 2021 21:43:02 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2D32718597A1B for ; Thu, 9 Dec 2021 02:42:52 +0000 (UTC) X-FDA: 78896708184.23.1EFC413 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf31.hostedemail.com (Postfix) with ESMTP id D421D20003 for ; Thu, 9 Dec 2021 02:42:51 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id m186so3856230qkb.4 for ; Wed, 08 Dec 2021 18:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ni8ukBhnwq4xfJn2KEfRGFk9CvW/EaamTsKpCF9U5jw=; b=FledoWYccQAWv6FRpva8r4lIbEIfgQM+BjswBkDz+Ede5Wkeo8QjIZfKPDzFnpjhRl QxEn1AjrahGgFvRzd0cqSJ2eUckDV58c4ITNjL0+zpwShqj3e3GzQEJJrRPRDFoVUbqy o30GCFnGk5euP4CXUr97UvPvq8KYjwaf3iQZUJP4LvlcPSpLmp29dzjB+vLPQnYPOImv 5/62MrA1RYw6hgl+MJlK/vZBz7MfRRWvJC7nVMIx/grd+5AnrUm6g22228Or3MWIOGMV FijRDzb8IFS4aOCXYGiqC2nBprxecfD8vuc9vHLcuwXLUJiobdQUv/tz+wefcirK74rv ty3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ni8ukBhnwq4xfJn2KEfRGFk9CvW/EaamTsKpCF9U5jw=; b=FzpSzfOs0q1EtUlPzlWJyeQnnhdyUYRp8LtTL5BHvStpCEfLsjpy7ADqobgMeeFAAF 3vsfRV3HPJpIodg5OSlW8dNym+snAFSRkxYniGqW/YspVvy+lor2/UcuV7Kle9j3fIsD y5X7R2TvgtSKXAe/HRyDYc2XWXy9bcbIqn95AAzp2LEE8w5vpOw3pCJovLoOnsMLAvz/ CD+DiFS9olH3jl/tsMafYW4z4CvaM7Y4TQOeyER+NzxUuAb49L5DGOdFbXTKcvgS7hEH D0x+ni5xgxWS0xejqLdsNU8zAoHqhKOdB56l/q2e004dAkDG90aI91N+Lh5T9yg5BT6B s+Zw== X-Gm-Message-State: AOAM530AU69G59+MAz2FDEzQ7hdXMmv8B5VgAWMarorKBIdyurbytXUk q8SurqN5Yhrc58XE1jSKiy+VHqI0WMAHqe050Wg= X-Google-Smtp-Source: ABdhPJzPyV2mTICg4ujehOAo8kaXJvx2de02S+39TMWQ8+kUht18v3fGS9QAWvbiXI0QEc1UOZ9N36zfY4aRtfuIbw0= X-Received: by 2002:a05:620a:2e3:: with SMTP id a3mr10866422qko.451.1639017771202; Wed, 08 Dec 2021 18:42:51 -0800 (PST) MIME-Version: 1.0 References: <20211204095256.78042-1-laoar.shao@gmail.com> <20211204095256.78042-5-laoar.shao@gmail.com> <20211208134304.615abbbf@gandalf.local.home> In-Reply-To: <20211208134304.615abbbf@gandalf.local.home> From: Yafang Shao Date: Thu, 9 Dec 2021 10:42:15 +0800 Message-ID: Subject: Re: [PATCH -mm 4/5] tools/perf: replace hard-coded 16 with TASK_COMM_LEN To: Steven Rostedt Cc: Andrew Morton , Kees Cook , Petr Mladek , David Hildenbrand , Arnaldo Carvalho de Melo , Andrii Nakryiko , Linux MM , bpf , "linux-perf-use." , Linux-Fsdevel , LKML , Mathieu Desnoyers , Alexei Starovoitov , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D421D20003 X-Stat-Signature: rjrfpd9njp77czbbiqz8k6zu1p7u7jod Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FledoWYc; spf=pass (imf31.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.179 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1639017771-302500 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 9, 2021 at 2:43 AM Steven Rostedt wrote: > > On Sat, 4 Dec 2021 09:52:55 +0000 > Yafang Shao wrote: > > > @@ -43,7 +45,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > > return -1; > > } > > > > - if (evsel__test_field(evsel, "prev_comm", 16, false)) > > + if (evsel__test_field(evsel, "prev_comm", TASK_COMM_LEN, false)) > > ret = -1; > > > > if (evsel__test_field(evsel, "prev_pid", 4, true)) > > @@ -55,7 +57,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > > if (evsel__test_field(evsel, "prev_state", sizeof(long), true)) > > ret = -1; > > > > - if (evsel__test_field(evsel, "next_comm", 16, false)) > > + if (evsel__test_field(evsel, "next_comm", TASK_COMM_LEN, false)) > > ret = -1; > > > > if (evsel__test_field(evsel, "next_pid", 4, true)) > > @@ -73,7 +75,7 @@ static int test__perf_evsel__tp_sched_test(struct test_suite *test __maybe_unuse > > return -1; > > } > > > > - if (evsel__test_field(evsel, "comm", 16, false)) > > + if (evsel__test_field(evsel, "comm", TASK_COMM_LEN, false)) > > Shouldn't all these be TASK_COMM_LEN_16? > The value here must be the same with TASK_COMM_LEN, so I use TASK_COMM_LEN here. But we may also change the code as https://lore.kernel.org/lkml/20211101060419.4682-9-laoar.shao@gmail.com/ if TASK_COMM_LEN is changed, so TASK_COMM_LEN_16 is also okay here. I will change it to TASK_COMM_LEN_16 in the next version. > > > ret = -1; > > > > if (evsel__test_field(evsel, "pid", 4, true)) > -- Thanks Yafang