From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59114C433E0 for ; Thu, 9 Jul 2020 07:41:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 196872070E for ; Thu, 9 Jul 2020 07:41:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eJAzwKEr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 196872070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8CB96B0010; Thu, 9 Jul 2020 03:41:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3C026B0022; Thu, 9 Jul 2020 03:41:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 903F66B0023; Thu, 9 Jul 2020 03:41:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 77F656B0010 for ; Thu, 9 Jul 2020 03:41:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 25D9C1EF3 for ; Thu, 9 Jul 2020 07:41:48 +0000 (UTC) X-FDA: 77017743096.16.desk12_0e1409e26ec4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id E8177100E690C for ; Thu, 9 Jul 2020 07:41:47 +0000 (UTC) X-HE-Tag: desk12_0e1409e26ec4 X-Filterd-Recvd-Size: 4436 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 07:41:47 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id v6so1343433iob.4 for ; Thu, 09 Jul 2020 00:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ybapX9dwUgXdpA8lRB7iW1jwbA7bfvk+OO92kUSz9So=; b=eJAzwKErSdND8yQvAjVbkFMN+mP21Epkm7M3ODvXiiaw/5tkwNE498gAicfbklyZA8 ciW2LvRm7CAZmUsjNWqepJjKVyIX5eSHyZ5IpQ/F5/My63+YNeebIEtU2dFuL8K7YAtL bGuIAWDJ/BUm7wWRlC1FT9O0UXdkmS+2d5ycLYgiDezVXINwjjgWtVPvzSYl3VLIcrNe HmRw1TUxS3VSGbv3u9lbPzFAqcRO/xng98Ebm7oODcSZiew11NLhuz+eAlJNBj2oNV1O uY+aMSpJJTskjcQvL5i1fWv/k7TIc3DKSFjusa2+RDo7MdvzJAW3POc5/cvBJWLO+Z7v zFqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ybapX9dwUgXdpA8lRB7iW1jwbA7bfvk+OO92kUSz9So=; b=dN8qPWX+n3fiEws7HvMU9KGMraqGHB37u6MIfiAPy2QyPw2zGC/rukw5UHSPySRTsj oEc8JFlMZocfJnGgODwUw30crvDTATiPDBh661xO3DWOCriAu7kPMbFQ7jO1Wgr0hAH4 NhzosG7ssUjCnKr2Y9r4KbcSq7r9Dl2u3sSLLtphUw/2BAxjhjgx3HanVhG3tztldZ2O SuKupQXmlDwKNupVhGhMWPMp06wLiEpCn2oi4ie23oqE9UOyuDB1p+ECVKr/KE5snS2c 4TDB+oNEEI7Ko625CIzCl6CbsCjt6HwcQbWYzEILOPUyIaj73uQk9dEH4BRQE80XHuVf 65zg== X-Gm-Message-State: AOAM532Gvg5L7TeeQC81JIDGjif3O9BqyvbuST1D3AvrFQ++3GhH846Z vh3rI2ED845fpSubQpAwHHIG0GRuXn3Pd9x5dJtwbBKiDsw= X-Google-Smtp-Source: ABdhPJznZggohMXyEmUhVJ7YSeuhvxMLrSKbinlNGmMG9HQ7dy2PuiqPDtU6kHkJzrzCvpVyi+YL4LVSW0Bs/2kOdbg= X-Received: by 2002:a05:6602:2dd4:: with SMTP id l20mr40765009iow.13.1594280507020; Thu, 09 Jul 2020 00:41:47 -0700 (PDT) MIME-Version: 1.0 References: <20200709062603.18480-1-mhocko@kernel.org> <20200709062603.18480-2-mhocko@kernel.org> In-Reply-To: <20200709062603.18480-2-mhocko@kernel.org> From: Yafang Shao Date: Thu, 9 Jul 2020 15:41:11 +0800 Message-ID: Subject: Re: [PATCH 2/2] doc, mm: clarify /proc//oom_score value range To: Michal Hocko Cc: Jonathan Corbet , Andrew Morton , David Rientjes , Linux MM , LKML , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E8177100E690C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 9, 2020 at 2:26 PM Michal Hocko wrote: > > From: Michal Hocko > > The exported value includes oom_score_adj so the range is no [0, 1000] > as described in the previous section but rather [0, 2000]. Mention that > fact explicitly. > > Signed-off-by: Michal Hocko > --- > Documentation/filesystems/proc.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 8e3b5dffcfa8..78a0dec323a3 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -1673,6 +1673,9 @@ requires CAP_SYS_RESOURCE. > 3.2 /proc//oom_score - Display current oom-killer score > ------------------------------------------------------------- > > +Please note that the exported value includes oom_score_adj so it is effectively > +in range [0,2000]. > + [0, 2000] may be not a proper range, see my reply in another thread.[1] As this value hasn't been documented before and nobody notices that, I think there might be no user really care about it before. So we should discuss the proper range if we really think the user will care about this value. [1]. https://lore.kernel.org/linux-mm/CALOAHbAvj-gWZMLef=PuKTfDScwfM8gPPX0evzjoref1bG=zwA@mail.gmail.com/T/#m2332c3e6b7f869383cb74ab3a0f7b6c670b3b23b > This file can be used to check the current score used by the oom-killer is for > any given . Use it together with /proc//oom_score_adj to tune which > process should be killed in an out-of-memory situation. > -- > 2.27.0 > -- Thanks Yafang