From: Yafang Shao <laoar.shao@gmail.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
shaoyafang@didiglobal.com
Subject: Re: [PATCH] mm/memcontrol: split pgscan into direct and kswapd for memcg
Date: Wed, 10 Apr 2019 09:16:21 +0800 [thread overview]
Message-ID: <CALOAHbAz9ZL1vfWOQP7-1YXcko5VGt+-DtCkDikL8gysZy66Bg@mail.gmail.com> (raw)
In-Reply-To: <20190409175545.GA13122@cmpxchg.org>
On Wed, Apr 10, 2019 at 1:55 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Tue, Apr 09, 2019 at 09:13:43PM +0800, Yafang Shao wrote:
> > Now we count PGSCAN_KSWAPD and PGSCAN_DIRECT into one single item
> > 'pgscan', that's not proper.
> >
> > PGSCAN_DIRECT is triggered by the tasks in this memcg, which directly
> > indicates the memory status of this memcg;
>
> PGSCAN_DIRECT occurs independent of cgroups when kswapd is overwhelmed
> or when allocations don't pass __GFP_KSWAPD_RECLAIM. You'll get direct
> reclaim inside memcgs that don't have a limit.
Oh yes.
Plus PGSCAN_DIRECT may also triggered by the tasks in the parent memcg.
'pgscan' here only cares about the memory in this memcg, other than
the tasks in this memcg.
Seems we'd better introduce another counter to reflect the tasks in this memcg.
Thanks
Yafang
prev parent reply other threads:[~2019-04-10 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 13:13 [PATCH] mm/memcontrol: split pgscan into direct and kswapd for memcg Yafang Shao
2019-04-09 13:25 ` Chris Down
2019-04-09 14:04 ` Yafang Shao
2019-04-09 17:55 ` Johannes Weiner
2019-04-10 1:16 ` Yafang Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbAz9ZL1vfWOQP7-1YXcko5VGt+-DtCkDikL8gysZy66Bg@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shaoyafang@didiglobal.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).