Re: [PATCH] mm: make __invalidate_mapping_pages() static

[Yafang Shao <laoar.shao@gmail.com>]

On Thu, Oct 15, 2020 at 1:44 PM Jason Yan <yanaijie@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> mm/truncate.c:531:15: warning: symbol '__invalidate_mapping_pages' was
> not declared. Should it be static?
>
> Fixes: eb1d7a65f08a ("mm, fadvise: improve the expensive remote LRU cache draining after FADV_DONTNEED")
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  mm/truncate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 18cec39a9f53..960edf5803ca 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -528,7 +528,7 @@ void truncate_inode_pages_final(struct address_space *mapping)
>  }
>  EXPORT_SYMBOL(truncate_inode_pages_final);
>
> -unsigned long __invalidate_mapping_pages(struct address_space *mapping,
> +static unsigned long __invalidate_mapping_pages(struct address_space *mapping,
>                 pgoff_t start, pgoff_t end, unsigned long *nr_pagevec)
>  {
>         pgoff_t indices[PAGEVEC_SIZE];
> --
> 2.25.4
>

Ah, this new helper is only used in truncate.c, so it should be static.
Thanks for catching it.

Reviewed-by: Yafang Shao <laoar.shao@gmail.com>

-- 
Thanks
Yafang