From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBBEC433EF for ; Thu, 7 Jul 2022 16:22:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A91BE6B0072; Thu, 7 Jul 2022 12:22:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A40AC6B0073; Thu, 7 Jul 2022 12:22:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92EDE6B0074; Thu, 7 Jul 2022 12:22:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8816D6B0072 for ; Thu, 7 Jul 2022 12:22:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6B6B533F80 for ; Thu, 7 Jul 2022 16:22:45 +0000 (UTC) X-FDA: 79660822290.23.A4455B9 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf06.hostedemail.com (Postfix) with ESMTP id E1F6E18000F for ; Thu, 7 Jul 2022 16:22:44 +0000 (UTC) Received: by mail-ua1-f52.google.com with SMTP id s38so4812671uac.6 for ; Thu, 07 Jul 2022 09:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YL2NT3tF2m6OvX44lYMQ92EPibm/ACpLuEg/IDa4O3o=; b=B7TEEskLpwWChFwIltTmK/3j3mQ9tBBcdFzHZkg7MBDpolgePNLC8ZlBmjyw3TapVu ZWi1KdYl1bQfobVWu93oLN1kNdsUz2o/hRDAhZgWLDnI1SbruchneDC9gH8KF4e1uBfB QHSHdd6RZxpFbOLWSXIUiOQa1nyag3CA9mqhyvsyl73ZOMJ3X/I+QCHAb8tuVffBF/ni 1rFFgTRcmlMO8ZyRiVqH5SqyEL0cI89XvgPfhMOHGbhVQstY9gEjY+sYX0vEQyXOL0Yi AcFSSgd8kSJrj78F2VPni2ToTK+d/phrfSoga3vUPRbC5oOaKYYbBUfbIl4LIuV4sdsW c7bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YL2NT3tF2m6OvX44lYMQ92EPibm/ACpLuEg/IDa4O3o=; b=YJt5qjJIWpFUumPymwuMdosskaBgo6eWMysAReCu01pS96CDL+HnAdKZUmBFveiNnT muoOJB4N3yicj5fw7b4JEm8DBW+MI1wiaUpQuctP+un5xjFMoWywxmyE1RoP6FxVkkoQ XTzztVM977+xwRzgKG+Rby5Wb6JPWBMeD9etCHJfGpY+UIw8e7EpjWwZ4M52n9hVbuGj 5HtmCQGnwR9cFM+mJ/iEHHK1dVAmA9KKiI1NkgT8bEkVIRSG73liAk6JsHUC90Z3dt4+ 7wbuGPf49GaR9htXeL5U6001gI3QfAH4EcBdN97Fk88ZQZnxWEOlpZuCFk9OAoiroOh/ cLPw== X-Gm-Message-State: AJIora8PeP6HLv6qAJpjCf4mYH7qJy0lq1VwYyGjiJHKiGAWiFbxbO2w C6ov2FyNyV4yiCAwHkz9xuEVMMArKiQtu0gbtB6tIw5WcpM9dA== X-Google-Smtp-Source: AGRyM1tNUpyVSeFrARrIwLJGLqqgOSoKfOz4fvnsoo21L9zR1v17rJbz4t2hIZlPAAgTZCW/bG0q4b7byFCuBKJ/SI4= X-Received: by 2002:a9f:3245:0:b0:382:ecc2:e174 with SMTP id y5-20020a9f3245000000b00382ecc2e174mr4908062uad.38.1657210964257; Thu, 07 Jul 2022 09:22:44 -0700 (PDT) MIME-Version: 1.0 References: <20220706155848.4939-1-laoar.shao@gmail.com> <20220706155848.4939-3-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Fri, 8 Jul 2022 00:22:07 +0800 Message-ID: Subject: Re: [PATCH bpf-next v2 2/2] bpf: Warn on non-preallocated case for missed trace types To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Roman Gushchin , Hao Luo , bpf , linux-mm Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657210965; a=rsa-sha256; cv=none; b=dRh0zaWYq7ZZytA3PKEzaK0OgmJz6zkbkZo8TSs/RpGp21qDuwYUFzGQDtj5u1H5VNAmQq PBPoEmaj0Dec/8PtaOlA51cHmZ+w0DGnv0CqmnjZPPEQqo3kmjK5OyuYrGsgiMf3m5Cc5p hj8ptlq00N2nM2ZquwtzAVziIybNzw4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B7TEEskL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657210965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YL2NT3tF2m6OvX44lYMQ92EPibm/ACpLuEg/IDa4O3o=; b=A9gZFakGe53G3eLGAXRYGFbRDiQ38iG5aMn1AIGld8BGqCZh62zLZuQr8BH1xDu2aG5Aw0 DUKxgPmYxuTWDO68NqsY7Xmw65Ki4Q7ia74+3gqEcyq7cld6siyACIzYaNUFB7kLic7XLA 1U0kXdzbWynv4xhHeDf2qP2yOMl6I/M= Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B7TEEskL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-Stat-Signature: 5tyz8t4c1amoo69zetd5uyey6f719jq7 X-Rspamd-Queue-Id: E1F6E18000F X-Rspamd-Server: rspam05 X-Rspam-User: X-HE-Tag: 1657210964-947067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 7, 2022 at 11:45 PM Alexei Starovoitov wrote: > > On Thu, Jul 7, 2022 at 3:30 AM Yafang Shao wrote: > > > > On Thu, Jul 7, 2022 at 12:50 AM Alexei Starovoitov > > wrote: > > > > > > On Wed, Jul 6, 2022 at 8:59 AM Yafang Shao wrote: > > > > > > > > BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE and BPF_PROG_TYPE_TRACING are > > > > trace type as well, which may also cause unexpected memory allocation if > > > > we set BPF_F_NO_PREALLOC. > > > > Let's also warn on both of them. > > > > > > > > Signed-off-by: Yafang Shao > > > > --- > > > > kernel/bpf/verifier.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > > > index df3ec6b05f05..f9c0f4889a3a 100644 > > > > --- a/kernel/bpf/verifier.c > > > > +++ b/kernel/bpf/verifier.c > > > > @@ -12570,6 +12570,8 @@ static bool is_tracing_prog_type(enum bpf_prog_type type) > > > > case BPF_PROG_TYPE_TRACEPOINT: > > > > case BPF_PROG_TYPE_PERF_EVENT: > > > > case BPF_PROG_TYPE_RAW_TRACEPOINT: > > > > + case BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE: > > > > + case BPF_PROG_TYPE_TRACING: > > > > > > BPF_TRACE_ITER should probably be excluded. > > > > Right, I have verified that BPF_TRACE_ITER can be excluded. > > Will change it. > > Probably more than that. See that your change broke BPF CI > and selftests are failing. > Which means it breaks existing bpf programs. Ah, yes, "#194 timer:FAIL" which is caused by this change. I will be more careful here. -- Regards Yafang