From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF908C54756 for ; Thu, 22 May 2025 06:15:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70F596B0082; Thu, 22 May 2025 02:15:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C0506B0083; Thu, 22 May 2025 02:15:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D5BA6B0085; Thu, 22 May 2025 02:15:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 403026B0082 for ; Thu, 22 May 2025 02:15:53 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D46A680575 for ; Thu, 22 May 2025 06:15:52 +0000 (UTC) X-FDA: 83469532944.15.7797420 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf29.hostedemail.com (Postfix) with ESMTP id F290D12000B for ; Thu, 22 May 2025 06:15:50 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PrvfwvgG; spf=pass (imf29.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747894551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZXdrQudC82M+RXWv3KT75ifthrQS/0PqWGPX1TzmJn0=; b=YwxAteyjGls03vDGforP/yWshPE0BMRn5RSjRjLZ/6kpkF+yNSYfUE14TRIdZ0AzFulGHs xc7gOmPZyI5NETfDRyD1sSB9Nx0O+88rpHYniQY97roMwSJEklwlPGWuBOleIKoLD5Q5Mv LKBy7qIoHmUmb8RkV2r7n6Rjn0pp2RY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PrvfwvgG; spf=pass (imf29.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747894551; a=rsa-sha256; cv=none; b=27F4eKgT609HpsXeh+miAcYptAaBcL5txHFliY2JErTBPdws1+YETiMA685WKOqtLsGfWQ bIAvy4mC7WvaecIF+YDAJfJLbSDrFhfdeP1ExknbXbETbRq/FhsRfS2o/jAfjHNuZT8XrK u6r32a/5yW0SR/mWhRdIDoCVlfN4Pik= Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6f8b9c6b453so69003236d6.2 for ; Wed, 21 May 2025 23:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747894550; x=1748499350; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZXdrQudC82M+RXWv3KT75ifthrQS/0PqWGPX1TzmJn0=; b=PrvfwvgG+JOoHbtJhbim76bU/7Y9jOzzE0Q408Y6YvV8PS3Us2KdcgqOb6xca1PMwY Ok9jYfPEpSlRMOSyg0npUMwAN+r+SepUThzA5txDazMbsmYmwPQhIbgYCwOYy8TAgLlP GK+UgWRJdpMQku8sWjJMyfxSnXy6m/yftYVYB8YTXOOKLg6Z/zjEdfTea9g2x4Ow2NAh ZoEexM/ZdYJQiZ3XzkuRsevHtcW9GCvheh/80ArutJomQQKihgI3Ruyid9sTnhUmv3M2 39hDg3Ovs+HSZEw3Jf5jDMoyrlso01lUkvsJUdB9DzXUmGZemdOmSYdOoNkXq3gZuT1M 1mHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747894550; x=1748499350; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZXdrQudC82M+RXWv3KT75ifthrQS/0PqWGPX1TzmJn0=; b=r3fp/9Krqljz51hgO1E5+rdoEfIVVBrMq3O7BgFtk1b5HMob58FUuTvEa6nZIOTYd4 3Z4QPpyztPt2U/9agDFffCfM+XNSAQKfnPW3vq8TExe6u+76nVAVFiXUFz2WR1c+RwDP XipSqQ5ehd112YoHRaWP+NQyck7FQoG06TXl0V9HS+x0ESAPCtd7vlTvdLhIebgVPc6a hCTlGbQD8Wk3eL/486pG/FiXsNDigqcvgZEtwSNCOJwzcblwjHt6EyO+WxWmU2NOTYOs m8iLHyC+Ffrok6wuh90qY/N5g0Osk1/RFdLue7EKHVLOSYdHI7Lg7H9vNmxKXwQNW/Ff VuIg== X-Forwarded-Encrypted: i=1; AJvYcCXCV9LPeDJZGiVDlNyKZQO44rsUuoOiVLECIEjDCCRFcefcLV+zlpDfpOhc7VPNfiQ149sFmDa62w==@kvack.org X-Gm-Message-State: AOJu0YxR9yF6xu3VRuF/e4/n9etf0J/8SumuK7eAL9xMGc9uPXNLjbIu PUCRaNVEuSeB3rITDDuRpHH5YelO5aviFPWhq8gd1kfNsFiJM9fvvgplEKCWyglRtjZf0TGSP7V TKhWj/+f5RVBVPTqGMxi4wPPzqWOnlQc= X-Gm-Gg: ASbGncv7NxFnLUXRuq/gBmqDBYkOKxlRg2sl1BcAoKCOvzQQTU0+wS7z+eIg2d34yl6 bIUHMjl44cte4CU6lMbOYbkG6ZPmVadZ+32BFXAsG8pVxsqb/aIKj3a3jkuZbCY3YYe10yGySV9 IOIOOR9u9ymghmcWAb7RtnirDfwIg1bxUTPw== X-Google-Smtp-Source: AGHT+IFKOC9mEYSOYCwZB+hNIAN37e7Pn0LuF6NZH6cBUxj4agI/PryyRfq8gu07V1D2LotWOWiLP5xa0GVKeJ6VviA= X-Received: by 2002:ad4:5ec8:0:b0:6f5:4f18:81d9 with SMTP id 6a1803df08f44-6f8b2d41e47mr406849736d6.23.1747894550006; Wed, 21 May 2025 23:15:50 -0700 (PDT) MIME-Version: 1.0 References: <20250521062337.53262-1-bhupesh@igalia.com> <20250521062337.53262-3-bhupesh@igalia.com> In-Reply-To: <20250521062337.53262-3-bhupesh@igalia.com> From: Yafang Shao Date: Thu, 22 May 2025 14:15:13 +0800 X-Gm-Features: AX0GCFvAMu94jah4jA_vOqZJoCDzlxV3FYoqVXzO2soNYAKD2LF9n-3UXNqK9FI Message-ID: Subject: Re: [PATCH v4 2/3] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation To: Bhupesh Cc: akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-trace-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F290D12000B X-Stat-Signature: hcq6yrkimwjf3fixrcfwym4gyodrxi1w X-Rspam-User: X-HE-Tag: 1747894550-7132 X-HE-Meta: U2FsdGVkX1/ZzOU8nzIxVGf2i7mm3K+pY1Z/swh+XVe4g6IECF1xwNBCas7i4QPJ6q3cR44fWQQKyxfpyuryvnsZtTyjanIOYPRCvtqZMmIh9uTLu8KLygS5mh5dBhLZIBpCt73nAgJ0+Wg8d2JQ9fXE6T7DljXBJ6+mIBYtFAWO0tc47S8Fhsmjcw/ElCbMXcRbLsQbQfV5sSQ4Zr3RlZug9+O7DN2kou/WQwrhDhCvPOyvdEpbT7cj47m+oofurEUHe/mjH72TSWrALDvApo9tq6hbl0Sv0fmj90DNVoPeC3bjB7ICaGAtv8SGl0hg6Cd+dPtkbKR+IDpFHVh8mN8TUi/3uaGzwWjBzhzCfO1fAadmrvquNwk2t6CbPvQnerHsqEP1vk2b+iNUAQ5cvblqOc37VsOYuA+zAzupCNOjij/LqsPw7jSI2IIFOJdUiwWgjHlZs19tVQvuosBWDtBy/wCLy5D16jH5uX/2YJMuJ34mKIH/C7d6uvks/Uau4pAC6E0yxqtWaIpaZK6T8Y7sieqS6aQcCj/3kbgsSrR/q22MNkvD8MjlQrkaC/bDfdLt6l4ECAH4BzmqtPWIylKiz8xHBLjBtxmZ7zKjx6b5wRVjx6+1L1eZSbbUp0ja2V0PM1QEfPnxqpS781V3N0AVnr7+7w74KLflwy0KwDe2VqSFv0M3SWBSerM6k9FDDSRdLphqslxTKqo58yQTur362WpAn5iCBhmWQd/NNDsfzcARE46f6vMhN4kKpkyEbUKE+k0twMXtM2iANSqB0RJgEaW/Sik58oDIN/T+uD1efld5n22ZYMwkPuq+UCA6PKx3Yu163ZEb68fmaGknuo9+H2MDOYeSLr+Peg6JV+yBNNpVLZuzCXjrrEY3KN6Pc3kA3sUBopGbbb3j2HVpvhU4KMGDJd4bvvQxTWw5wXG5kyfrU4YFTbHtWeUWebyjHR8jnYl5rr78mXUltbG sgVti4JU mt6cE7+Dv7mu8ljDQR0arjwD8tOvGF2HwWl16ansslwdGrcCH3nPIhXXnk18wgg+4FnWTYm84mS5k7N1bzPCHHnuChQLpoWgOdx8o8VisPSFU2FxsY+DlsU+nbR1rQovUuHFigUmqhSuTQ0R88xYOT1nZD91ARg80ShcpQSvE+ob2HJwv26PeQSudhhMN/AihLGCdtfaVvkx3TmVrSaYNjOIAoyRPvBNfNIwgk+0uVat8TGa6GiVrvj05CqtYAU6F9Bxoac0ha3/uG92kBR1hI+ciIeZuZFOVr1HboTNjZbJbU/Q+AyNNyo5zpLCDNJ3TLVwxUEJbNUcO2Xw18a7W1+bozgFyt+K/Lbv13AH0cZs2+AKwfnKRiQr8pHu3jvz4b8b6pue/bCVnV2bUu+PAs0Ja/lBJoIksezeETaqcIlekjDuq7akeL9CgwGvF/XcJaSmN0no6h+ll1fvZB4nXQUV5DJUAZ70l6zOIlMY8fb1rrEw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 21, 2025 at 2:24=E2=80=AFPM Bhupesh wrote: > > As Linus mentioned in [1], currently we have several memcpy() use-cases > which use 'current->comm' to copy the task name over to local copies. > For an example: > > ... > char comm[TASK_COMM_LEN]; > memcpy(comm, current->comm, TASK_COMM_LEN); > ... > > These should be modified so that we can later implement approaches > to handle the task->comm's 16-byte length limitation (TASK_COMM_LEN) > is a more modular way (follow-up patches do the same): > > ... > char comm[TASK_COMM_LEN]; > memcpy(comm, current->comm, TASK_COMM_LEN); > comm[TASK_COMM_LEN - 1] =3D '\0'; > ... > > The relevant 'memcpy()' users were identified using the following search > pattern: > $ git grep 'memcpy.*->comm\>' Hello Bhupesh, Several BPF programs currently read task->comm directly, as seen in: // tools/testing/selftests/bpf/progs/test_skb_helpers.c [0] bpf_probe_read_kernel_str(&comm, sizeof(comm), &task->comm); This approach may cause issues after the follow-up patch. I believe we should replace it with the safer bpf_get_current_comm() or explicitly null-terminate it with "comm[sizeof(comm) - 1] =3D '\0'". Out-of-tree BPF programs like BCC[1] or bpftrace[2] relying on direct task->comm access may also break and require updates. [0]. https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/= tools/testing/selftests/bpf/progs/test_skb_helpers.c#n26 [1]. https://github.com/iovisor/bcc [2]. https://github.com/bpftrace/bpftrace --=20 Regards Yafang