From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57385C83F27 for ; Sun, 20 Jul 2025 02:38:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D94FF6B0093; Sat, 19 Jul 2025 22:38:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6B406B0095; Sat, 19 Jul 2025 22:38:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C81116B0096; Sat, 19 Jul 2025 22:38:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B6CB96B0093 for ; Sat, 19 Jul 2025 22:38:14 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7BF9D140444 for ; Sun, 20 Jul 2025 02:38:14 +0000 (UTC) X-FDA: 83683083708.19.D6211F5 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf20.hostedemail.com (Postfix) with ESMTP id B007E1C0007 for ; Sun, 20 Jul 2025 02:38:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="On/z0ZJT"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752979092; a=rsa-sha256; cv=none; b=S2W8Tc7gfMPq9jYdAMI8XFJbOv4bGsBYlIoAEonlPunTzKlZgF0GeJTpKk97omxj7d+3zW vUzoUxomVzB8Cc94ggPFxDbnNnVOqc2YdzdWj2w40YlpTtqPnkQZx1jEeXNCCPPrFlp9rr x0bpa9z06l2BWxD3kYrrlLTZNwbaC+I= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="On/z0ZJT"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752979092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yF03xpuSOoou9NLC5lBz2Tyb2HkfAsm4fkuAmAQafhc=; b=gcGVm5MD6FV6TdEy/DVB2lNLgf1Chz9rnP9SbvQLBS9DshYZgSrxqD/sT8a+dr5PCgDi4W cjbiDRrl58HGaFhmhQQOJ6V2eVNhO0FsPcRqNc8kyf0QctPNhuqa9R68tJRD0rtu30dqp5 +wk0dNJVkl6EKpEa+WP2n5xSEhcs130= Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4ab61ecc1e8so24590691cf.1 for ; Sat, 19 Jul 2025 19:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752979092; x=1753583892; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yF03xpuSOoou9NLC5lBz2Tyb2HkfAsm4fkuAmAQafhc=; b=On/z0ZJT023DUc0QL9sgCnQWhH8F1V9qM2Wrh2jlpD0jYDQLCyAsuxuOhFqWEWCTM/ /0/I9EFScZRO1/9xTdwRdkduH/l580+6yrupOo1wWHdKlazu8YUF01kpNvHvXmH9y/zt LtY31comOeypR/lEWNcO7s429+r444i/ECGYpeQzpQsOqnJOQBUiyEqziHskpfRICVue lySlePDiQi2gTJmoacBSERnCVm2AXajK5pyD0nslCnv2UQz+PU/qkpmP6s3DOlCQWTEm ObVADwmG3OuhKfiP2gS8Vl+QcbIiQu4axM3xVz0FF6LehvljB8XIa2IPHZ8Kx0e0LfeH yxMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752979092; x=1753583892; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yF03xpuSOoou9NLC5lBz2Tyb2HkfAsm4fkuAmAQafhc=; b=SByhHl7k+tlGwWKmI8ovrNSh0W3ddrQ7JeDTvXZ3OGUxujDOE5jQvOifEAak9M4t9w a2Su+PW4X5DaeSofSUlvhJAreG5U9s9EBMvc672+N3xn11VnKIIT+RBn10G4VYK1QK8m gka1Zg7payCMnPJQOTM+AkX9Q6eq3Iq9LVg2F1Zi7lmiaEx/nXy+uuPdXozVYqKfhrnO VcR1vOdLfBDXLZtuk4JKEHuVUlBOUQ23UzVS1Nf4dSk0r8z1V44HuAIWrO1xZmEvHpLn 1lxOedu0xBIY1r0Fskdtzkx2dg8svNPo5zXUI5NTZu6LvtUzhLDYykxrnDE5QH2IdWeg wCig== X-Forwarded-Encrypted: i=1; AJvYcCUc5Ag0BzFH/9ezfNCyPZBPWupQV9ma4Q+Pg0KX8WbkaWYz+nvJI7ByP+rg/a5ARyFoB/DCakT2hg==@kvack.org X-Gm-Message-State: AOJu0YzHsyJNnhUSPwaldd0Wh6/BjjVMWQkv+hyTrQUn9TYKRzA5FSsH r3E1k7WaoHqQgte5fGC4J56h/Igt6jBbdF6OsWJm7LbqS9fVtQ/ojlJQCPuCV75COM1Z4ocJMTk YEIAloYopdjCVApwRz90+QQAJsfJZuqs= X-Gm-Gg: ASbGnctX/1Nzk2SAL8c/he7yi0ESqiJ7MI2ry2sePbRmwkhlODd5F051fRWOA9ufGsG W6MKjyFxBoqpvcwUB1qlLEYBRfq2W/ysdqnPCGn2VY9YTbYoD5jL3QgraK5bHCmjEWcXt/SMe3z LTVdyPUGXzHGBYYkDKdG5WpxGHkjpMjvcED3L1j2s++kcpSC7LNdOiI4Q3j6GsUgZRXMs7QzTUN 21MfhAc X-Google-Smtp-Source: AGHT+IH0N8N1xY2U+UiK0og+zn9/dYy5EoUw2d16L3MJvCxnXLffYXLd4rqiDHFz/MRXrhBx+oGMQcjIHvzp+E7DIH4= X-Received: by 2002:ad4:4ea6:0:b0:704:999b:e5a0 with SMTP id 6a1803df08f44-704f6ad3e7cmr280117146d6.34.1752979091866; Sat, 19 Jul 2025 19:38:11 -0700 (PDT) MIME-Version: 1.0 References: <20250608073516.22415-1-laoar.shao@gmail.com> <20250608073516.22415-2-laoar.shao@gmail.com> <58c82190-e7b7-499b-9463-527312a28a3d@gmail.com> In-Reply-To: <58c82190-e7b7-499b-9463-527312a28a3d@gmail.com> From: Yafang Shao Date: Sun, 20 Jul 2025 10:37:35 +0800 X-Gm-Features: Ac12FXxMqgfOvyX0tW-DoBRC4l60DBz94py3UG5A4cnl1liihoxjNk3wW6Ld1Pw Message-ID: Subject: Re: [RFC PATCH v3 1/5] mm, thp: use __thp_vma_allowable_orders() in khugepaged_enter_vma() To: Usama Arif Cc: akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, hannes@cmpxchg.org, gutierrez.asier@huawei-partners.com, willy@infradead.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: o97w8daibtor8dtm5tsjwb9qsiqagyp1 X-Rspam-User: X-Rspamd-Queue-Id: B007E1C0007 X-Rspamd-Server: rspam02 X-HE-Tag: 1752979092-975683 X-HE-Meta: U2FsdGVkX1+69VFEyZzabVynf9wl3bNNZVHGFDI3owoCVw6boDyfaRCCvVLk64sXQbbTFqMkaaOBMtysXyrrYx6YZKsjGRDah/JTPVqUS/h3EhOFi3JKwIs1wZaV7EtOuPNzTNEsPTuDpwgEIiMbRImqnsoTbrs17ovf53o2Hy1wL5RjRxatfvJA7b6lanCFUchg7iNHOcBVi5se9ln5JkZ7UfMJIl+5gFRm7M6ScHyXOq+HzuhhKJtPmK64XX5taRxntcrrQetMqHKsiQO4cjUhGJcrkk2nb3zb7DQoWK5kYbuW9aiIem+VV/rSJ3T7ZxAcpH183uZXpcVaiVop5Go1wKTpQ1S2Qmgm0mb1mBVdYp+Y3PkisEgqIDZS4xu8P9GJnAeDE0zYATs/DZ3JcQxJzNK5gdQkjdy9HaWi7uTNN+mERgUggTABrNb9TBmycNjEw0z27P5GtF0wJCq2coJGCrMkbgc2MOlwwMhyzNNzAx/XOg6unkVkeUWgJlKWRglJOb6KXRp2jnkSiH9UeFJtPISxR5N+0OiU/2jH3wq6xY4RpgPqxqEhw18RwLHEV9Gl96FRYR6F10o4QkBhcJR3rxLzKm2llQ157pMamp7ESwJ/IY7m6W4M+yqzsPau+HmU2uz8vv/fTZVEBVgc9iuFXHLRuf4fxBpw7ttN+iUxM1KHFVDe4XIAK0P7oQX5Abrc3wFcjbQPWhUikiVYWwXf7jTJOHadEhJ/mT4rFKvLILddkOMnwtYkrSXWuOYeAMYs65mKoHVg/mjzlpl2o3wIsTN0m8TxEaOWa+aJULqJ4DXZaLDxSsyOwMZKG2UsWdMfITn0u4EburHv4wEpnTFxtPFJw+8iIzXYzK0Z9OtqPibx1K+gW8K11kq/TcXqvHwIeah8EmWDJpJVeNDnWkZ9aTXatojsnxwArYnrHVDV1mx6SETIP545qxYUTn39QDOyVZdvReUwH2FZb16 hEq0hQ8m CuBZG2yP7PeojjC+mXUNLDtMv3risYTegjiKosMcBkK3v7fRnLu0dCfhajjO1ntptsqXX028W2x3HupWZd8kFg2XO+Ve/wIL0tG+ueJ5NuEO34sh4N2ZWEgkjR9xMFaRq/wJ8ILF6zEBONLHU69TWUPs5iRmx2jkG3pCTz3cuV5FS0rUGnhkuMFOIzNslpCXprSKPS7QCfISFH2+ZEr2Sz0vnEmpkTtpkNVH/QziPOFWhaRdOeZROWuhD9OYahr0nja6cFXhYg1H59ySFnZeNS7/x+7uYpGi+eqrhS3tMKRO2cDi680fdwUv/DY5heDlyXKipT7x8/0eGRnRWbyFvY9FCTQb39ssFkW+XMG9RIEROdz0Tn0YEy0USCX3ciWjF8NG2hw7Bm9mcYqUaLNeUx6D/XIxtnGgk94XB7HmV5lgOac23wYTWqPwJ+JTzc2eEy5SdlxAHaD8Z/ZY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 10:48=E2=80=AFPM Usama Arif wrote: > > > > On 08/06/2025 08:35, Yafang Shao wrote: > > The order has already been validated in hugepage_pmd_enabled(), so ther= e's > > no need to recheck it in thp_vma_allowable_orders(). > > > > > The checks are not equivalent. > > hugepage_pmd_enabled just checks if the sysfs entries allow hugification. > thp_vma_allowable_orders modifies the orders that can be used based on vm= _flags, > which is not done in hugepage_pmd_enabled. Thank you for catching that. I overlooked the vm_flags check. --=20 Regards Yafang