From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB16C2BBCA for ; Sun, 23 Jun 2024 06:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C9936B057F; Sun, 23 Jun 2024 02:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 279916B0581; Sun, 23 Jun 2024 02:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1416F6B0582; Sun, 23 Jun 2024 02:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EB6A16B057F for ; Sun, 23 Jun 2024 02:01:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4AAE31C0C5D for ; Sun, 23 Jun 2024 06:01:08 +0000 (UTC) X-FDA: 82261105416.20.F92EF8A Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf03.hostedemail.com (Postfix) with ESMTP id 8C36B2000D for ; Sun, 23 Jun 2024 06:01:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mZBeWqTy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719122456; a=rsa-sha256; cv=none; b=4ty66aHEGpB4ohTgHjPSLrVHmRUpYL3hcVWTWsQ3OuSOgBu/ucTXzhjAqcO9V/BB4oLcMf F4H9RKckjNJFxrqgyXnBrvHzxIf8BrmOZol2HGKee2hG2u/hCCmwfsn+eBfblHY+2Y7TTA uX196fzdhIwbTtcIvAOOHnUHlI55PLU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mZBeWqTy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719122456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=639B1VhzkVRiQ3egX05fSRdoRLJZKUd3UI9/6wfJ8lw=; b=cNhOEurhNIXa5OySxLhe3qYsJ6znbM+N/86s8dWOtnZy4T7w+6o+ELlH5WK3Wgew613Ve3 q/4kVuaRtJRXg2hV9hYQcCzT5RJIvvi66NRCTi7Hm2TWLmX+B6TIyP6PQL36uPR4e7BQFn VKFG1Q+kVwoU8O8ervBOfnDE64x8amA= Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-79767180a15so203186985a.1 for ; Sat, 22 Jun 2024 23:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719122465; x=1719727265; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=639B1VhzkVRiQ3egX05fSRdoRLJZKUd3UI9/6wfJ8lw=; b=mZBeWqTyZKieqoOciBYO56MHCpWuvvBgQmcjMbSc4oOzsC75e9O/V8PMkpIOVrMiTr CBRe/hQDVTI6aTNbXjCT7PnKIOZbiXXzUn7NDyVeeEpih6GhUY7glajsJBuGJs0mlWaH FaacUl8TF5LSoYl39R3wDj5lEIN/GBuntWYzVhRdWG2q613YW6gpgEkxEnUQ7rOig6AY yPp3ZZdSsUweITe3EgGgjP/k83VRfH6sL1cLvlIXg7ahv1o0HXo+BcM2gNfyxBcJ2NfN YiRvsQk/UDrdPi/MHL86+BtgtszyrtLHNSHUiBaCbT6/Br8wZWpmu0kqMeA8bjsjLVz+ caaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719122465; x=1719727265; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=639B1VhzkVRiQ3egX05fSRdoRLJZKUd3UI9/6wfJ8lw=; b=hqGAfyET9C7SLdB43sYkV4rJJEeTE8Wyd4saoRBCztKtJpB0XI8Ns92EKnPs5BYlYL IRL+7B2YDYfLJFMofDHgCyGNDQOfUwTQ7KJDFXKC5ZW/X5+Hy0MSNB/YxzFU0tQax0es qLLIOTKTXDFvl/QISRzIXQxefjooo54VKgVbsjeMtUquVnVTVFY1n1gDzsc1AyCQa6Us fdaSPrg7p7AIKD+SKLtqArdWcbB1rUXVZM/WRiKehP7owtue8Aip+idEMhSZIORiM0kN ewCqYk+/vweJpkFuD2IInp/KP+b6m9wqeAuxu/LNAxGOvMmkd+RXDEUu3gQYaE2N/0po /QJQ== X-Forwarded-Encrypted: i=1; AJvYcCWYl6iV/eT1P8PfiOHC1PZL6TPV3pKBitVIC04nX+7IniojXKXnZ6uxSrtvStHjtGFk0oyz8sEJhq3cSNX0wJzKWko= X-Gm-Message-State: AOJu0YwptLdA5UAFwgVR4FNOKRUH9StuWZzcQ9NA8MxGdctqsX2gua2i 4gM8Ts113ZZtkAyhScYtrLFfqqIDg4poVpFCNXHVDMIRzWalun9NqfecF1d5amflmvHtWCIhVnn OW6XQM3Tr9YENXI1FzfXu6MRhDO8= X-Google-Smtp-Source: AGHT+IHcXR+ehU+k0C/NmM/DLF8W1FSfgc1FOoi+9SruG7tbvTjl8bMu8+dVhBmSjLDe3SkqoqwwTUGvFNLK0f3vidI= X-Received: by 2002:ad4:5228:0:b0:6b4:f644:9d87 with SMTP id 6a1803df08f44-6b53debf738mr17899726d6.21.1719122465581; Sat, 22 Jun 2024 23:01:05 -0700 (PDT) MIME-Version: 1.0 References: <20240621022959.9124-1-laoar.shao@gmail.com> <20240621022959.9124-7-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Sun, 23 Jun 2024 14:00:29 +0800 Message-ID: Subject: Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} To: Matthew Wilcox Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8C36B2000D X-Stat-Signature: zjstg8e5y81srjicmyb6nekgo3zfsji1 X-Rspam-User: X-HE-Tag: 1719122466-373140 X-HE-Meta: U2FsdGVkX1+EbR/Sai06L6rnG0ZMUsehU29f0f7zvLJSrWWeQniMDyNqk2FElFkLt7rDmM4eizDxS659vkiokcBwgmXskVu2ueLiDQVQwyIyVHx/k9zjWX91NFtAOGW4uMEuXMDos1xj1IJ3o+9KCP7bdA8ECMw253cweJ+xaCjgayvg3SBTMsWTVvXsnZt+4dToPfgPJGcmCbMt5K5+gy5SwpUGFT5Y1gRQojkHksptqBuhv5B4V7zq/yf1Yg9pUK3ps3S+b7B4yOJrsJQB/84yulTrQkTEcY3mTm3tPp8PsOIGTN266/mzR/rSuyCer7q59UrzLbol5NSCXUPjQ7eScJGINQ+ZIZfheg8V+KlXQFnRBL2/6Z3hP7075UQZW7WfR5Sd5PUI1Oi7QTETYODeKMexIXsoomCfyke2QU/g4zFEyEHtj+XrSsydqQoXyqO/44TkNeUFnoB+S1/MSWjyvmJ/tHKyjGtM8YvOD3gF9DhpjJwOQdtH7J93yvyic/eii8WlzF3fKca9V6vYEfu3kSbEHHxdzJ9sGA8Dd/6+IM/Eqth3w9Aq+sE4531UzM9yqSW8XEqSPHco7GXwOmpevouR90xC6r/arrXjok5AC6naxls/5Or/1AsC2mALejKX6xMujojTBu5juX/VMS/Wbb4kSe0wcHcSGZ3gYOVvn3zkiYPIojg6Y6Pn8ii2cyu/wGXLNoXPOtE2da1lmzIm5aAacLTrDjDAuzAXxT2KcXAd7qSE1il9dnfDX12mEf6GePYhdLo3cT8t6izM9svQmFWC9Y3dYEDn1ttJ8Ab+C1uJ7QrnI1Uydam2VxoWnUUNIG1lXFdY65WJqCpNF5Pcf9wNMZ5pEzJFt7qx29MngmG/pLA7Lmjhb/EL9tW++XXyxwnRjKW8RHB+I3LSO+ISdFr2KXdiKzYryNjBM5/oeIwhSQy1niOyhPET/7Hhk4nSoIe/v+jMWevOmbr 3WL+V2B4 8PVv6d1PHjmJU7KTlWghYjgEKoofiQDdMoTP1b2G0GJTFROrdxnPg+NjGeBupvnZ79tU4Mtk20yNvKQeD1plZzbUhLg5ESqlEp1gM7CDJ/U5dcq4a9JBoKk5Kj2TrOLTYsiPUUXtGVzHlL9hLoMHy/MZ5Y2b0W0ZVJOfYw4adOcxGd2hmAQu+DVl4SeTLf/9WmvvDwqBmFcflcqcobGen6iLliIaK0Aky9YtXT0SXkCukzQ1gaNdYIErIbpSFYimJWFtlQNZFRbnsFOPXx6JtvoQ6rEPiHaFb2aFWJGbpk6qwAubJDDdS8mzTknCXNN5/WzEewIxKOdQ/PdUP47alj187wSwFx7NPvlvLl0RakD6jKpO4A2x1n5MTGcBcl4sMUfgZZ43NaRLgVyaVB7ApMtywfwDcG1pAz/hcJA6+19ZZHg7siuCurgFDAC9OjZggfo2zB+JfVUNEZP/xU+t3cLHGxtx1w1vko2fIWTdq7SYgXoYHu1mGGmVRdsjTtcr6pwVf X-Bogosity: Ham, tests=bogofilter, spamicity=0.002966, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 23, 2024 at 11:11=E2=80=AFAM Matthew Wilcox wrote: > > On Sun, Jun 23, 2024 at 10:29:30AM +0800, Yafang Shao wrote: > > On Fri, Jun 21, 2024 at 9:57=E2=80=AFPM Matthew Wilcox wrote: > > > > > > On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote: > > > > +++ b/mm/internal.h > > > > > > Why are you putting __kstrndup in a header file when it's only used > > > in util.c? > > > > I want to make it always inlined. However, it is not recommended to > > define an inline function in a .c file, right ? > > I'm not aware of any such recommendation. Better than putting it in > a .h file that everybody has to look at but nobody uses. Understood. Will change it. --=20 Regards Yafang