From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04F4C5B549 for ; Fri, 30 May 2025 07:45:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E7186B0082; Fri, 30 May 2025 03:45:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 398196B0083; Fri, 30 May 2025 03:45:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AE1E6B0085; Fri, 30 May 2025 03:45:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 136BC6B0082 for ; Fri, 30 May 2025 03:45:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A595C142838 for ; Fri, 30 May 2025 07:45:29 +0000 (UTC) X-FDA: 83498789178.06.67E94F3 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf06.hostedemail.com (Postfix) with ESMTP id C82D718000B for ; Fri, 30 May 2025 07:45:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JprJplpJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748591127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pzOa/UgrS9Umku7hdGQ7ovp+X/tJyw92DDjRJCHRzbI=; b=OSNHXquyaHoz/MTHsp679tAdST8TCM7hNw2ONBkIIKVFDrxvkcLRyc7K0AVu9NvHtJQyvp 8d5RKhcsoRCtYPRklq2qh9yKL8qBODPA/sZvZg1+HoN1TlE580mmgRKtRwVJR3EHjf6ka4 AGRVH07FIY2YAdzj4X9MnEmDtdRgLFg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748591127; a=rsa-sha256; cv=none; b=AVyhn74Syp1/bKZi8uKrzJYM2tx4PnuOj6mNYbjLmYWwp+oIlpL2sQv6j6L7hojKL4T/oy 7eAsTXw1VxIbKZqIpbHfD44SBkvMHCJCq/G7aTdZIBpC8ae7uAu9hGy++r0vQicVDW11wM LtXP/Vmi2NyUxNEMzyyRiKKCSKR6GBQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JprJplpJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-742af848148so1101991b3a.1 for ; Fri, 30 May 2025 00:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748591126; x=1749195926; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pzOa/UgrS9Umku7hdGQ7ovp+X/tJyw92DDjRJCHRzbI=; b=JprJplpJMFMuG9j1HD93h9oImXjYyLQ+j4Qvdy5cbm/aHFUkUfDhVxLZc+GqQrn0De WReNPiw+c5iET8TcdejZzqpsDpFw13s/q4KVAdrqQ/6/4Up9umkWID2nP8lbl12Cu1ui dJs3kCV7M/ktt3r8T4DxoAP5aKY+hMUvr56GjU9myj9g5ghCjHx++q6jYYjpwsNOfWjc YvhAqsfRCX00jLnT2Pbkt8cmBCHvKO0haCXTfy8CqDWbOXzedGH3sw4pSwBlRsNYF60l jtXFfHvmUB2ct4ElV/Hb39wP6BiPkvafBT9TG1yBoWQL5gXDWMkjWzhia1aEiCy9PuRl x1fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748591126; x=1749195926; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pzOa/UgrS9Umku7hdGQ7ovp+X/tJyw92DDjRJCHRzbI=; b=ilvhgmOsODUfOflzjU6Z+26NKfsnZ+P8f+pev2zMGwghJ6bm7+bqqFWtJ/39ZCtOTF veiK5jpJbT+sn2zIects/XLfO8I85HJvVPiFKBA/HNkPEkbpeNFTjJmrus0ZpMlwwqDb H5oKJR3iVbBXBw6YZhe5JPrXb5+X+dx5di7OU+ucLLLX+z+4humuV1K03t01ceUQhy64 cFgGVGRFxUIZZeBiOF1Ti+48ING9PGZKXyYQZrM0pXtpA1HOudnRkXm0hENk1I7LOTJf x2IXNqujwjoE44M4OWC5cBmNqzOwh3dOE8twWNgyoJZHlR54uli2krMEWMQGAMOYJEGV l4vA== X-Forwarded-Encrypted: i=1; AJvYcCUwRQDISRyThUilVyZYLwXZFUilSML9BMewG+48t64tnH3dOsiQ1y5d/K8+lX4Kuo9UK1yu4EydVQ==@kvack.org X-Gm-Message-State: AOJu0YwpezosMwe6hC2E1hcqhGd0y6TGp1PHdHnmnilX1c7KUoVHCi/G kMVm5Qu/S3bcDBeofP1U7C9SG+wFxUvzGsUlgnDsKn7GIrbPduE3834a+QBnLh86q4cGEXNZOf7 AX/9P6wIMHX1RTIGpG2R1067zSu4WvA== X-Gm-Gg: ASbGncvX2S/eN5p38KZ5Hxf+vEhIwRCDcBFD39GiJe5tr0rjE/l84yaCfsvszFwQfEE RSMtlga8EwtLE/c9nb4TbW4BX/1qfY8vvMz9tmVWx4JrjJ5wq+f1Ue6wxIvzTcuqc47rOtPR2ec hHv8s6wdFKnPSj5p1vJUSCyQpEzzm+GK8i6vhosFucf806RSUTsANZFqugQUKylMMtDxH7Hl/vf 4o= X-Google-Smtp-Source: AGHT+IGjkyt+5maMLA3DqnIou9TTiHmTo5+xl6kXpbOGFBDFFRIUaD90grOdP2fLlk7ybBrIk+t94W9pQB2C97dcVy0= X-Received: by 2002:a05:6a00:a29:b0:746:2a0b:3dc8 with SMTP id d2e1a72fcca58-747bd9ed7c6mr2995642b3a.17.1748591126498; Fri, 30 May 2025 00:45:26 -0700 (PDT) MIME-Version: 1.0 References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250510160335.1898-1-ujwal.kundur@gmail.com> In-Reply-To: From: Ujwal Kundur Date: Fri, 30 May 2025 13:15:14 +0530 X-Gm-Features: AX0GCFvl1t3aZ635dE3UAXR9Vmuz_M0u8DD3KfxntZ3wNAPx5Iro3jK1qTCBrQU Message-ID: Subject: Re: [PATCH v3 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct To: Brendan Jackman Cc: akpm@linux-foundation.org, peterx@redhat.com, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C82D718000B X-Stat-Signature: mhz3ggpoo3hx9u9h6ib73xbjm6somttp X-Rspam-User: X-HE-Tag: 1748591127-897532 X-HE-Meta: U2FsdGVkX18pQgTE33ZpxbujT0ahH6cTe19FeiBzUGwoNHBKHkCnE7nRR48x/FFesTEJ1WSD0EekE1l9dPRpM8LRRsF7DBOwP/R+Osfi1lDsEF6FY+XEdl3vuZZmmCRhuvkGf78YJIOA+2fhiCoCT7LftI+xkaSXO9eDLo9ENgJLOk2NIhIvYvNuKp4rNCH0Jftq1eIh6nrPKQX/1DVQqyML20oWPqC7LjgGAt96Yo2pavcy98akkg7A20ODdCGkZvPVjC2rN76MY8hRk9zfJT8I4KyKuQ05XajZQuGimiwBlhvnbjYA+LfvNXaM+90b7DYv/LdZKOB+1nKg4wZHsyBwtZ9e9nhQcJk0IGdVhM0wVyat9/QvBglwEDvDxniXBougi0vGMW0uhLlrMfdM/jlrdS9hbypwlBBzzs08+OUW0dkCPoHu0tE19VeAB8E1znQHyzDNgMnwsKTMSgPHUQql7UsKsbej3eJkJNMUKZfA17MnmB+h9jHghUkgSGyhbQLv3Bp/BjI+rBMEaj857jSpRNAbgBSFREL9D6ohfs25n0Nr0r6rV8K30dVon2Q6dR/kpI9YvtlcVk0iuoGWUWXC+zFZFKFLAfNdUrLjkgrh/v0ib/RQvipFHT3zUjhgIya0o1hT31cVfnYLu7f/O/WdMetEkAGYkOS9vAANlCkUWIyMQ8NIE1kzWr+IwcdJJ5exg/hk2dFPVgywg8nJeAPafr5NCNqeuWedDchQPZQ9Ynb1UVWUj/NGS9GOFYOEZ7khMy9CLljiX1WV7+5WGFkfG00qtV7MLF4NL8rFzq4jl6/3aKI49So//aWnDzf4ySL9z5k9jccIYHCbDXMu2Qoy71+PJ0SSKErOc40L0VS1jwcqzrW/9ESMsbX8OSUSWsndi/iAytlJi6VVVg/qo4WPZPHOMnfV764DYyTqU3WJfIcE/2PjqizMDmq6Q/QroF/k1b7DAbrds9F/I/Y EUqCzPnD tZVc6VJUApmWe5Mpg2YbnHbKlYJyg4P08Y45kBqyiJWLcWVCIieZqIGk6PDnerCNmYMxMoofGXPXc8rmn2SW3har7ZTsNg6OgYkL297rzoEhpnqQkecqmpi2U/6SylzJrKAsKtOlxUBURE219+U+xAT1uO2NnZPxZzqEaVycUNOWCXjI7+/zmN9B1P6K4kzcc1PQ2pWycql7B5zx+Dw0AtEe7YwQ4iYjPGYegYHlu4aEoIs9FkG5avCv0GL7xZvRkN740ZbUHx9AaAW6xhN5Fi+SZVK8HUNDxEsTAG3gPIOSvr86JEKzNJ737/17YO0mF1be7d59/4KHIZ73dsor8sqbE0qsbS1Ltu1Ox X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Sorry I don't have an opinion on which of these is the best (I can try > to find some time to form an opionion on this later!), but: > > Fixing the flakiness sounds great, but I would suggest decoupling that > from the refactoring. If it's practical, focus on removing the globals > first, while leaving the fundamental logic the same, even if it's bad. > Then as a separate series, fix the logic. Thanks, much appreciated. I'll send a patch with the refactoring + a comment regarding this variable left-in and follow-up with a fix.