From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02757C433F5 for ; Tue, 19 Oct 2021 05:34:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 90C5C6115B for ; Tue, 19 Oct 2021 05:34:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 90C5C6115B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 36468900003; Tue, 19 Oct 2021 01:34:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 314AD6B0071; Tue, 19 Oct 2021 01:34:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DC1A900003; Tue, 19 Oct 2021 01:34:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 0F3906B006C for ; Tue, 19 Oct 2021 01:34:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BFF423C7DF for ; Tue, 19 Oct 2021 05:34:14 +0000 (UTC) X-FDA: 78712071228.14.C0C987A Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf14.hostedemail.com (Postfix) with ESMTP id 8DEB96001983 for ; Tue, 19 Oct 2021 05:34:15 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id u32so860062ybd.9 for ; Mon, 18 Oct 2021 22:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RMl6loCX4NFJfsa056nJx2CwFXuES2+tyFDbKn9//yc=; b=hTuEcyIcrJwowhVFmr1Ryqylewdeyhe839N+rtYyyw854YKwj82YG8tP3ZrEIcyUj5 3nBKlC3W5LVY6eQAImanPJUjibQ2OFhlBjIXWvcj2b550FKbwFt67vooTKvLoWjRuFz+ vb66bneS468dgNCIaTDlsyxaW8tRR74sxQXupOSnhApyXlJrCGorx2qEVSZzrHLJOcg4 7DJeN1Rb8uMxygEDTe9aPIOPDEEIox9moleQaYtIuNRyEX3FrwitftCf088a/A3nVgse nI1z4VydJxhIZ4l+CA5FkztaMVms9AWrRNAnd89DDLG0OEi9tvgc+rLPZVB/KtClHEcA 9PJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RMl6loCX4NFJfsa056nJx2CwFXuES2+tyFDbKn9//yc=; b=Li0b/G86dOiojLa4qDaNHH6e6DZZsxIYb472HCaU5DrgF3l5msFSmQb3ZW+BZquNVw E4RDw2eiuX5duLTM9ITVaLu8fQvh6M/7Dz+/xy2FEtGMAgL69cyyz25TpbuPtyrkMbnq 1LmpmglJzLbHdg1NkvszuneifhH8O2un1St3mR9qsfPPq2wY4DeI7cySpl6C7GMb1onA 39jPzcyFeWnkLzeJiryiA5MEI6rHcAfWGv2pJllc58A6zGrjnjoOpozv/Vjy68RlmtqH HXIhIPuMc1Kj/iIQlX4WL9Synlf+B/mi5yj3cQvfkzQtdUVu7dVlgJv89sJoy2WywFPg fPqA== X-Gm-Message-State: AOAM532ycQyAhlGW6EjbIMPnmbve9OpDFff1NYY5nZPwWJAHIgvZ0qUH yZ4tAOBcjpmTY5YNRFCBSxIavg9Z2u7imLoaHeG4rg== X-Google-Smtp-Source: ABdhPJw4muOArPUxsbdZlRPVYrKgei9bVqqkp4GtRd9nh/grse1BR6U0QaqtB8AGSLTeeVP4yYeQ9AI24xDMfblDJWk= X-Received: by 2002:a25:dc53:: with SMTP id y80mr35915639ybe.68.1634621653611; Mon, 18 Oct 2021 22:34:13 -0700 (PDT) MIME-Version: 1.0 References: <9d10df01-0127-fb40-81c3-cc53c9733c3e@virtuozzo.com> <6b751abe-aa52-d1d8-2631-ec471975cc3a@virtuozzo.com> <27dc0c49-a0d6-875b-49c6-0ef5c0cc3ac8@virtuozzo.com> <153f7aa6-39ef-f064-8745-a9489e088239@virtuozzo.com> <4a30aa18-e2a2-693c-8237-b75fffac9838@virtuozzo.com> In-Reply-To: <4a30aa18-e2a2-693c-8237-b75fffac9838@virtuozzo.com> From: Shakeel Butt Date: Mon, 18 Oct 2021 22:34:02 -0700 Message-ID: Subject: Re: [PATCH memcg 0/1] false global OOM triggered by memcg-limited task To: Vasily Averin Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Mel Gorman , Cgroups , Linux MM , LKML , kernel@openvz.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ohefttcrtkyrk7d88k7c1yud71cgr18c Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hTuEcyIc; spf=pass (imf14.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8DEB96001983 X-HE-Tag: 1634621655-137296 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 18, 2021 at 12:19 PM Vasily Averin wrote: > > On 18.10.2021 21:52, Vasily Averin wrote: > > On 18.10.2021 18:07, Shakeel Butt wrote: > >> On Mon, Oct 18, 2021 at 5:27 AM Michal Hocko wrote: > >>> > >>> [restore the cc list] > >>> > >>> On Mon 18-10-21 15:14:26, Vasily Averin wrote: > >>>> On 18.10.2021 14:53, Michal Hocko wrote: > >>>>> On Mon 18-10-21 13:05:35, Vasily Averin wrote: > >>>>>> On 18.10.2021 12:04, Michal Hocko wrote: > >>>>>> Here we call try_charge_memcg() that return success and approve the allocation, > >>>>>> however then we hit into kmem limit and fail the allocation. > >>>>> > >>>>> Just to make sure I understand this would be for the v1 kmem explicit > >>>>> limit, correct? > >>>> > >>>> yes, I mean this limit. > >>> > >>> OK, thanks for the clarification. This is a known problem. Have a look > >>> at I think we consider that one to 0158115f702b ("memcg, kmem: deprecate > >>> kmem.limit_in_bytes"). We are reporting the deprecated and to-be removed > >>> status since 2019 without any actual report sugested by the kernel > >>> message. Maybe we should try and remove it and see whether that prompts > >>> some pushback. > >>> > >> > >> Yes, I think now should be the right time to take the next step for > >> deprecation of kmem limits: > >> https://lore.kernel.org/all/20201118175726.2453120-1-shakeelb@google.com/ > > > > Are you going to push it to stable kernels too? > > Btw CONFIG_MEMCG_KMEM=y is set both in RHEL8 kernels and in ubuntu 20.04 LTS kernel 5.11.0-37. > CONFIG_MEMCG_KMEM is orthogonal to setting kmem limits. We are not disabling the kmem accounting.