From: Shakeel Butt <shakeelb@google.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Vasily Averin <vvs@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg: replace in_interrupt() with !in_task()
Date: Fri, 28 Jan 2022 08:20:04 -0800 [thread overview]
Message-ID: <CALvZod4Tg8VAPOYriNfQAdW1TM1vf9rQu+7N6jc0Mod096RFCA@mail.gmail.com> (raw)
In-Reply-To: <YfPgRU7Swo0VczUd@dhcp22.suse.cz>
On Fri, Jan 28, 2022 at 4:23 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Thu 27-01-22 08:26:36, Shakeel Butt wrote:
> > Replace the deprecated in_interrupt() with !in_task() because
> > in_interrupt() returns true for BH disabled even if the call happens in
> > the task context. in_task() is the right interface to differentiate
> > task context from NMI, hard IRQ and softirq contexts.
>
> Makes sense. I do not think this will have any visible effect. Except
> for removing a deprecated call, right?
Correct, that is my understanding as well.
prev parent reply other threads:[~2022-01-28 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 16:26 [PATCH] memcg: replace in_interrupt() with !in_task() Shakeel Butt
2022-01-28 12:23 ` Michal Hocko
2022-01-28 16:20 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod4Tg8VAPOYriNfQAdW1TM1vf9rQu+7N6jc0Mod096RFCA@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).