From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B5AC433EF for ; Fri, 28 Jan 2022 16:20:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F6AA6B00C2; Fri, 28 Jan 2022 11:20:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5EA6B00C5; Fri, 28 Jan 2022 11:20:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36E2F6B00C6; Fri, 28 Jan 2022 11:20:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 290646B00C2 for ; Fri, 28 Jan 2022 11:20:19 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E65C295279 for ; Fri, 28 Jan 2022 16:20:18 +0000 (UTC) X-FDA: 79080208116.20.F1297AA Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf28.hostedemail.com (Postfix) with ESMTP id 06CE9C000C for ; Fri, 28 Jan 2022 16:20:17 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id z4so12815302lft.3 for ; Fri, 28 Jan 2022 08:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UGBFjinD6yJ5HceIOydMt3QOO6lels/1FGluycv/zYc=; b=G02sjb+2szznjNomETifI9YkohtNQ5Ie4jFYsqRjS68XxVJWgCSgGyKGgbYaUAJam/ 2xwhNM3jsb1fqTgx1OdfQ+Qlrmsp9Xw1Danw3gmDcQdfs/l1nlJ4ZBl6eDIpdDTeq35O cm7dJ1AO4KG1npRR9zOw1Din8StBatdTPzoQyoEp+DKQmy4z++cNDw+iZWOBd+o5gLqn JY3siIf4mZqdrMjjR4w2BrtqKz6YK2O0HN7DI6RBicicwMku23XLJNbo38QDFrXXOQ0q 6AGzxq2sxVohsWJrugkib4llBEsYOugitESKemCQ874EGK4IzUkwkPhwuqtIQE7lIbB6 LZ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UGBFjinD6yJ5HceIOydMt3QOO6lels/1FGluycv/zYc=; b=FeyJELYj+vq85+OBhetKo7M1JU5MeUazWjZ3tEARQ8hr/7omVJ4Twv/vEpW6kOwjKh iLeaPrEi97Oh5WZ35HJtHxWY2vp7yFtkwLFXkIRlwLUgQa7i3NXvSeEwC/M3h6ldacCl 7/TgkWYZb9cpq8CGSubsntJF0fAwwHlqOnrIJsQoue1bH8ezgUJEgYuK4raLIbAEykzQ G5czLnjRVA0UsUQkNizoJkWWW1UWmlDAPLGoRch7L9RqzEe7knQIg7r38YeRArQ0t2VW PvSKGCGeKQFQzNklWtyLzRErD+thjjDpMzM6NfZMGuCAEHG9WfPL98HHu6ovpeeXNw5I gDTg== X-Gm-Message-State: AOAM530baS2HGlRNRtUnjIsIsP+oVDc7tUYvt4BG2hPj7Lv/pB+7SjHz WkokpODVrgOyv1H90n8KeXrQAk0q4MRbmgSXyM7fLQ== X-Google-Smtp-Source: ABdhPJzSer2f6I/KxwwyaLBqT3ti10NERd3yZ/GqEspFJPWSG/rr+F9z7DJ6EdBp0LIqUxROOUQXhQAdrKuL92AhJUA= X-Received: by 2002:ac2:5095:: with SMTP id f21mr6697631lfm.20.1643386816184; Fri, 28 Jan 2022 08:20:16 -0800 (PST) MIME-Version: 1.0 References: <20220127162636.3461256-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 28 Jan 2022 08:20:04 -0800 Message-ID: Subject: Re: [PATCH] memcg: replace in_interrupt() with !in_task() To: Michal Hocko Cc: Vasily Averin , Johannes Weiner , Roman Gushchin , Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 06CE9C000C X-Stat-Signature: ke3s88bygbrizgwpbuno5zbhngikmzrh X-Rspam-User: nil Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=G02sjb+2; spf=pass (imf28.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1643386817-809941 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 4:23 AM Michal Hocko wrote: > > On Thu 27-01-22 08:26:36, Shakeel Butt wrote: > > Replace the deprecated in_interrupt() with !in_task() because > > in_interrupt() returns true for BH disabled even if the call happens in > > the task context. in_task() is the right interface to differentiate > > task context from NMI, hard IRQ and softirq contexts. > > Makes sense. I do not think this will have any visible effect. Except > for removing a deprecated call, right? Correct, that is my understanding as well.